Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evAIK-00079V-LQ for pgadmin-hackers@arkaria.postgresql.org; Sun, 11 Mar 2018 23:22:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evAII-0000P7-VO for pgadmin-hackers@arkaria.postgresql.org; Sun, 11 Mar 2018 23:22:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evAII-0000Ox-K0 for pgadmin-hackers@lists.postgresql.org; Sun, 11 Mar 2018 23:22:22 +0000 Received: from mail-it0-x229.google.com ([2607:f8b0:4001:c0b::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evAID-0002mm-UW for pgadmin-hackers@postgresql.org; Sun, 11 Mar 2018 23:22:20 +0000 Received: by mail-it0-x229.google.com with SMTP id d13so8891757itf.0 for ; Sun, 11 Mar 2018 16:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9MWJ7icrUXizMG3fA2ZNAF9j+smXP80xalgf3QHmIeQ=; b=VoSdJSgmk0UtJL1rI36zTWPcfIQRt9jDcPpvEZzQxsY+K1b+1unhTXNr2GUOVb0F8J Px5Z4h9vw0oqoEgfLzDXDgT8zkSZ1NVHu0g/1v29qSWAWu2IcueboNjFdpxT2iAtSdrw KluOK/dB0Vl29QX1bOHekVyZhPeaAHC34PI4F7VhdBs5ixZ0nDzW+dBqCq7UaGBF/OUc iGOvpAo0jSD8joXNwL0dgjHJnXuFyHyqh/Af/JLtn+88q7KztESnoUG1x8u8+0TD2Ph7 p82KToohuUo4D5NAkd9k7kiSm1+8HFM2swSOJJnFeVCt2AGx10RhQcOHrt7U27Tgq6eI cHNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9MWJ7icrUXizMG3fA2ZNAF9j+smXP80xalgf3QHmIeQ=; b=iK2uc/1mjG8wlDfvzVyjUuqRPQiloX++3XhZjdwE2ik5byJ7Z1wuxJ5ikzEBen6unW nbnfnsUKEH1J46TTvPpCgMr1iA0yPJR3kS24vLAYnK3XFlYZsOzpRLtTsyeas2ZPDoZb Uu3UK49RCa7p30KGxfoCndVNDaLAA2e2GoqOUcOzFnnziFIw0sf9VupHneZxfTjThNGQ XTm10mNookHwAgCGo8MnTPwqmneHOOl5pa19paQ6ADvF5YiJlSFL/tP9gC0dU0A1SRen qhsRBfytYXK7ilmhE/xb8FfE7TlmGhtOCwswhXL0LdqCa25d70fRY6TLsLSiXYjAP++z HaFg== X-Gm-Message-State: AElRT7GH6XqTJfJ8VfHXaqik4d36LXP5tZEbgHfqXE4HBWzeJ+yOCdks VV+baUZ0PIj/5N7JzqCNK/FHI3sKemKtQtPny0qAUA== X-Google-Smtp-Source: AG47ELuXDkBZ0aEa/IvdK1zDZ85efB6BGk20UDujATWeozS2qjXDFijvw5wVyWThQml/5Yec7bt7VtxUx7ae94VSzt0= X-Received: by 10.36.203.67 with SMTP id u64mr5997593itg.133.1520810535732; Sun, 11 Mar 2018 16:22:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Sun, 11 Mar 2018 23:22:05 +0000 Message-ID: Subject: Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c0af848c0e2f105672b4b63" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c0af848c0e2f105672b4b63 Content-Type: text/plain; charset="UTF-8" Hello, Can you point out an example? Thanks On Sat, Mar 10, 2018, 3:53 PM Dave Page wrote: > Hi > > On Friday, March 9, 2018, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Hackers, >> >> Attached you can find the patch that skip some tests and correct issues >> on SQL that are failing when trying to connect to a GreenPlum database. >> >> We did this by adding a attribute to to test_json called "db_type" that >> will carry the type of database we are running tests against. >> > > Any reason we can't do that dynamically as we do with the EPAS-specific > tests? > > >> >> When we run tests against a GreenPlum instance the configuration would >> look like this: >> >> { >> "name": "GreenPlum", >> "comment": "GreenPlum DB", >> "db_username": "gp", >> "host": "localhost", >> "db_password": "", >> "db_port": 5433, >> "maintenance_db": "postgres", >> "sslmode": "prefer", >> "tablespace_path": "", >> "enabled": true, >> "db_type": "gpdb" >> } >> >> >> >> >> Thanks >> Joao >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > --94eb2c0af848c0e2f105672b4b63 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello,
Can you point out an example?
Thanks

On Sat, Mar 10, 2018, 3:53 PM Dave Page &= lt;dpage@pgadmin.org> wrote:
Hi

On Friday, March 9, 2018, J= oao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers,

Att= ached you can find the patch that skip some tests and correct issues on SQL= that are failing when trying to connect to a GreenPlum database.

We did this by adding a attribute to to test_json called &q= uot;db_type" that will carry the type of database we are running tests= against.

Any reason we can'= ;t do that dynamically as we do with the EPAS-specific tests?
=C2= =A0

When we run tests against a GreenPlum instance the configuration would lo= ok like this:
{
  "name": "GreenPlum",  "comment": "GreenPlum DB&q=
uot;,
  &qu=
ot;db_username": <=
span style=3D"color:rgb(106,135,89)">"gp",
  "host": "localhost",
  "db_password": ""=
,
  "db_port&=
quot;: 5433,  "maintenance_db": "postgr=
es",
  "sslmode": <=
span style=3D"color:rgb(106,135,89)">"prefer",
  "tablespace_path&quo=
t;: "",
  "enabled": true,
  =
"db_type": "gpdb"
}



Thanks
Joao


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--94eb2c0af848c0e2f105672b4b63--