Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evqwS-0006Nn-39 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 20:54:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evqwQ-0000yJ-F9 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 20:54:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evqwQ-0000y8-6X for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 20:54:38 +0000 Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evqwL-0006GL-2g for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 20:54:37 +0000 Received: by mail-io0-x244.google.com with SMTP id k21so1756942ioc.2 for ; Tue, 13 Mar 2018 13:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uOWrMA6PyC7NF4Ib9AlWB5yLhMdapfa0lydRAtbjryw=; b=puQXXWHxALuSl6GESKsaEzApbe7kn80+9turPJrw/WptIRz0sjSWYE+WRH9EYbaPPm MBypm3YS1zmdTO0tI10aXDUhz7501uTwByTfMxRmgCE4M/vFr56pCOVw+Zt2cKVOWvdl FlR2YxeucFvanYV1Bxs6SSJb8RMLJWMKo7npntuplZY3Dp8WOdgRpLZoXCqoP38PYCuV ALY8RIJ8+GA2Hhkeoi7VXftoxTGiPtESGzPt1Oukqi9HxNED4x9juLNxVc4ChhTM8n9o tEr2FrTuvsYOI/qJv3TlZTMbvjkbhe5jecfGBs2iPIePYzQNe3vxB+f9bdRNWN1ELDjf 6x4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uOWrMA6PyC7NF4Ib9AlWB5yLhMdapfa0lydRAtbjryw=; b=s+tj8WlGBafybRuA0dsnSMJhjwmEQNwA5eVEPnwq7T2Ap2LDztG+k7bzRcYGl3roND 2hxg28HIbOftKMkvib6FYdmgwqrnEI9HcDyjU1i2rKZ0IuS1RlzglFYyasEi1Fml8B2m hx0ncI4hMmgsq1iBZFfzY57dQEwDylM5z6jvosZLc4EzuO9JT7AGwJrXfUqeWniT3fRC O8xCgRzG3Wb0xY40CG8dWwMbYAk1U5REIJtsq2jd62QxDySQwbM1t9W0boPH6C0l68ch ULP2joF4vQt3aJT6TbIwRZWB6Pv3hyWbINfPDzi3F/gFxMqL9U9AbSoOVk8arTIqgme4 Kz7g== X-Gm-Message-State: AElRT7EGTbw54DspRn+UrV9xKiTORl/LZTEq3inObpBVhtBmybKrTUt0 oQRG3WZB7vaQqejhuUSkigwa/SeFjPcBpvGPrNtLfg== X-Google-Smtp-Source: AG47ELuCoJMjkHvjr2u4FyOmwbE+5hx2qB6i25hNnn4KVmBifAcLIsFMaNLpfSmU4pYasksBAm4SYY22zYLN7rEDCQI= X-Received: by 10.107.34.199 with SMTP id i190mr2276500ioi.185.1520974470364; Tue, 13 Mar 2018 13:54:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Tue, 13 Mar 2018 20:54:19 +0000 Message-ID: Subject: Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an To: Dave Page Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="001a1140d94404f5400567517788" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1140d94404f5400567517788 Content-Type: text/plain; charset="UTF-8" Hi Dave, Khushboo Looks like there is a linting issue with this commit: Successfully installed pycodestyle-2.3.1 /tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2 ./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace around operator ./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2) 1 E225 missing whitespace around operator 1 E303 too many blank lines (2) 2 Best Regards, Victoria & Joao On Tue, Mar 13, 2018 at 4:45 PM Dave Page wrote: > Fix unicode handling in the external process tools and show the complete > command in the process viewer. Fixes #2963. Fixes #3157. > > Branch > ------ > master > > Details > ------- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a88e1 > Author: Khushboo Vashi > > Modified Files > -------------- > web/pgadmin/misc/bgprocess/processes.py | 36 > +++++++++++++++++++++-- > web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++-- > web/pgadmin/tools/backup/__init__.py | 5 ++-- > 3 files changed, 38 insertions(+), 9 deletions(-) > > --001a1140d94404f5400567517788 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave, Khushboo

Looks like there is a= linting issue with this commit:

Successful=
ly installed pycodestyle-2.3.1

/tmp/build/4a5630c2/pgadmin-master/web /tmp/build/=
4a5630c2

./pgadmin/misc/bgprocess/processes.py:186: [E225] =
missing whitespace around operator

./pgadmin/tools/backup/__init__.py:113: [E303] too=
 many blank lines (2)

1       E225 missing whitespace around operator

1       E303 too many blank lines (2)

2

Bes= t Regards,
Victoria & Joao

On Tue, Mar 13, 2018 at 4:45 PM Dave Page <dpage@pgadmin.org> wrote:
=
Fix unicode handling in the external process= tools and show the complete command in the process viewer. Fixes #2963. Fi= xes #3157.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3D802269910c37a52aa57479bbcc1d8d078f6a88e1
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>

Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0| 36 +++++++++++++++++++++--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js |=C2=A0 6 ++--
web/pgadmin/tools/backup/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 |=C2=A0 5 ++--
3 files changed, 38 insertions(+), 9 deletions(-)

--001a1140d94404f5400567517788--