Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erWQX-0007gf-0K for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 22:11:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erWQV-0001YC-OE for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 22:11:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erWQ1-0008NK-Bg for pgadmin-hackers@lists.postgresql.org; Thu, 01 Mar 2018 22:11:17 +0000 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erWPr-0005T7-O8 for pgadmin-hackers@postgresql.org; Thu, 01 Mar 2018 22:11:15 +0000 Received: by mail-io0-x231.google.com with SMTP id e30so8800492ioc.3 for ; Thu, 01 Mar 2018 14:11:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=moBc94xuocsJ3nPgsS2qPFdovk3W0WC+m3JVAL9EBTU=; b=v7zBpfiTfgd042KFPFl2Jkbg68UWnjB2sDRTepc7QzRAcclvu1I4whCDPjOGtwz0OY GOkvJF53Ua2s85OdXvLMcrY+XWTETvdCHJbLW2oJDoVrO6WG8q+xdkgPL9+zUYNQLETD 2hO6NalnmEVWuuuN7sz6sm9ID2OqHUmi806KnisHo4rk6eKfVM3W9eZ3sfs0gwRGDY6r EpXgXNT//mQJk/ztCeRRwswWqOyWbbQtX2/iLuNcWlp3Lk+o7o2aLffy9+nKt00t6YLc EYy56JG9WbERaTOk8Vc864OVc7AKIXd05aB5sNfJneBjQf6RNcOuqM1k5hQEmwYPWmp2 5SYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=moBc94xuocsJ3nPgsS2qPFdovk3W0WC+m3JVAL9EBTU=; b=TabnUv9LrFSn0MfajfO5Q6tU0AzSwpT64MNHEwcr59XFHplDIxPbFxCxvbAgTN98rV 3WRMOFpyebdg4w+Mb6qE8UuRhU4M2EM7QJthARenjY4Ne4XoaboDiamEr2DAfhSMTT/s hXS3OZqOLh59UMbBbmXrTgPXxo3uFXTqiXim4qM8KWTOgavDa5RmW/+mdWVTdNnRCV+V L6xozG/L3s7IA9OSU1J0ZO2Ev/cA1HQD+T+7PjiyOWht5CbYMP03kTMIsh0jkWfjTrJ9 5i+G5nIBnndUHPD2NFNETpZHyjwvkHZ8ln6Wa2RfxhHInFFkCGxOZ0xm62P9qwFIAX8K 8O1A== X-Gm-Message-State: AElRT7GgLIvSjvAUYjMaNgE9ZVyeco/rPzlrv03NZ9BEk8ffxJDLCI9l c4fqMoeifgACCwcYxEAx4v7Q8e5TKD8/OztaSqbg1g== X-Google-Smtp-Source: AG47ELtRKHAMLMBbOc3n8YOx/LJXpattSdEZEhM9PZ17yTkRW6JKsneDr+L3SEBGd0cUIQdC+Ggop2ywa41RYrdVmJY= X-Received: by 10.107.31.133 with SMTP id f127mr3782656iof.234.1519942265240; Thu, 01 Mar 2018 14:11:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Thu, 01 Mar 2018 22:10:54 +0000 Message-ID: Subject: Re: Bug #3083 fix To: Neethu Mariya Joy Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="001a1140422acce58e05666122d1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1140422acce58e05666122d1 Content-Type: text/plain; charset="UTF-8" Hello Neethu, We passed the patch through our CI pipeline and all tests pass. The code looks good, but we are trying to decouple files as much as we can so that we do not end up with files with over 1000 lines, that are hard to read and to maintain. Also we are trying to create Unit Tests to have more coverage in our Javascript code. Can you split the new implementation code into it's own file and create some tests to ensure the behavior will not be broken in the future?iYou have some examples on: pgadmin/browser/server_groups/servers/databases/external_tables/* Thanks Joao On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy wrote: > Hi, > I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science > at BITS Pilani. > > I've attempted to fix https://redmine.postgresql.org/issues/3083. Since > the textarea resize feature is the default HTML feature, I have not changed > it. Instead, I've added draggable borders to the wrapper which expands the > textarea inside it. > > I'm attaching my patch as bug3083.diff below as per the contribution > guidelines. > > Hope this helps. Thank you for your consideration! > > Sincerely, > Neethu Mariya Joy > GitHub | Linkedin > > > > --001a1140422acce58e05666122d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Neethu,
We passed the patch through our CI pipel= ine and all tests pass.
The code looks good, but we are trying to= decouple files as much=C2=A0 as we can so that we do not end up with files= with over 1000 lines, that are hard to read and to maintain. Also we are t= rying to create Unit Tests to have more coverage in our Javascript code.

Can you split the new implementation code into it= 9;s own file and create some tests to ensure the behavior will not be broke= n in the future?iYou have some examples on:=C2=A0pgadmin/browser/server_gro= ups/servers/databases/external_tables/*

Thanks
Joao

On T= hu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:
Hi,
I am Neethu Mariya Joy, = an undergraduate pursuing BE in Computer Science at BITS Pilani.
=
I've attempted to fix=C2=A0https://redmine.postgresql.org/= issues/3083. Since the textarea=C2=A0resize feature is the default HTML= feature, I have not changed it. Instead, I've added draggable borders = to the wrapper which expands the textarea inside it.

I'm attaching my patch as bug3083.diff below as per the contribu= tion guidelines.

Hope this helps. Thank you for yo= ur consideration!

Sincerely,
Neethu Mari= ya Joy
GitHub=C2=A0|=C2=A0Linkedin


--001a1140422acce58e05666122d1--