Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0X5L-0004H4-PM for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 18:43:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0X5K-0004dO-2m for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 18:43:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0X5J-0004dD-QI for pgadmin-hackers@lists.postgresql.org; Mon, 26 Mar 2018 18:43:09 +0000 Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0X5F-00066X-Pa for pgadmin-hackers@postgresql.org; Mon, 26 Mar 2018 18:43:07 +0000 Received: by mail-io0-x244.google.com with SMTP id v13so24465667iob.6 for ; Mon, 26 Mar 2018 11:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aCA7ROKiD/W6shxJD+A67X27WjnmV70ogpMo6bXu6qc=; b=VlbI2wZIZoworaI9MC8fPeh0bsYR5kNoMI+GJTPcsX6G8l7hIhylcwWnRXZ3v9Fern b/Fn9vgqb/u8EAYNMABGrBRoV3J1I14R227BlavhorcGYJkajewAGFfT1gwmOHgvwqOL aiT8kx9RosXRckHk70Lp4c3Sk1V9Z51cd2llojvLBelMKBtVuDUPd+B63IxdUhxYIVsS yT29WH13PwwPl4xbgyjAebZTTHBy5+ReUGyF31dxIL9UujRSmMj0gRu2riV68wSzrz3t OizJ+15dHZVNHOfdEmSYXXYYwgwpRKniux4F9CXNkwvUkOT9nEV/s3eG28MZJ6r3xrBe wO1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aCA7ROKiD/W6shxJD+A67X27WjnmV70ogpMo6bXu6qc=; b=ACafciiiFxYKF5DuG0JO/UcMJ+oeD558W4M7terNWGRwSeQzt0BTySnNsniMG1ib6G QfmjtEGpmCQTRTR9ERfPTnnzUuYvwOrtASu+BD9p+GnWrinY/TtxbkLCE33ypwQeFMtH wTH5oOgOMG9W9fhp7whZyA5eFD4z/FUQmk8rIIKm/zadsRRGagS6s+Bz+LsWeSob9oIo nSl19wmtJq+CvUgZ9bX+u8o20JVxvhgtFqKLZTgbvHYFSnSbJY/m0Z8M8CDKaVYyKvNi 35AiDOgfc4m6qNqVMPfxH+wSHBO3LmEw0M8qISoNWy1juMJtRUAFiinf/I+D3SZToCqt vTXw== X-Gm-Message-State: AElRT7ES1Qh8KqCsU5pp8q2IRL3mEKdzkQ7JskPHf6+xTl6El2LPVAjF iE75XllwKR/4hn1u2bx6R0Vm3xUXPmcURrvifuaVBA== X-Google-Smtp-Source: AIpwx48sxBZIw+WQmhN++2dx0mz15SLhNhXMv1nbD69Je8XEB6yMW3AXuW8oBXff4LAYQgXUr02f0w1b+0ASTT7knZA= X-Received: by 10.107.143.211 with SMTP id r202mr9777862iod.185.1522089784401; Mon, 26 Mar 2018 11:43:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Mon, 26 Mar 2018 18:42:53 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations To: Dave Page Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c05a4bcea783c05685524df" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c05a4bcea783c05685524df Content-Type: text/plain; charset="UTF-8" Hi Khushboo, Looks like you have a typo on your CSS where it reads 'zoomeIn' it should be 'zoomIn'. Also setting more parameters into the window, in our experience, is never good, so maybe it is time to create a real settings cache that can retrieve from the backend the settings, like this one. Thanks Victoria & Joao On Mon, Mar 26, 2018 at 8:38 AM Dave Page wrote: > Hi > > On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #1978: Add an option to allow >> user to disable alertifyjs and acitree animations. >> > > I think these really need to be per-user settings, not per-installation.. > Whether or not animations are shown is really a matter of personal taste > and circumstance. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c05a4bcea783c05685524df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

Looks like you have a typo= on your CSS where it reads 'zoomeIn' it should be 'zoomIn'= .
Also setting more parameters into the window, in our experience= , is never good, so maybe it is time to create a real settings cache that c= an retrieve from the backend the settings, like this one.

Thanks
Victoria & Joao

On Mon, Mar 26, 2018 at 8:38 AM Dave Page <= dpage@pgadmin.org> wrote:
Hi

On Mon, Mar 26, 2018= at 7:23 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:
H= i,

Please find the attached patch to fix RM #1978: Add a= n option to allow user to disable alertifyjs and acitree animations.
<= /div>

I think these really ne= ed to be per-user settings, not per-installation.. Whether or not animation= s are shown is really a matter of personal taste and circumstance.

Thanks.=C2=A0
--94eb2c05a4bcea783c05685524df--