MIME-Version: 1.0
References: 
 <CAFOhELexqR-ogQyyR-Ymgok=y2vZBj4o2V0Bo_O_5NAkwBoQQQ@mail.gmail.com>
In-Reply-To: 
 <CAFOhELexqR-ogQyyR-Ymgok=y2vZBj4o2V0Bo_O_5NAkwBoQQQ@mail.gmail.com>
From: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Date: Thu, 01 Mar 2018 14:36:21 +0000
Message-ID: 
 <CAE+jjanPh-eUmjY=AiUKif3VWPwq3NAM7CXan5Xxa3+kZMxKGw@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed
 when user try to insert data on table where primray key is in captial letters
 and table contains OIDS
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a11406f1830af6c05665ac960"
Precedence: bulk

--001a11406f1830af6c05665ac960
Content-Type: text/plain; charset="UTF-8"

Hello Kushboo,

Can we add some Unit test to ensure this does not happen again?

Thanks
Joao

On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM # 3135 - [Web based] Syntax error
> displayed when user try to insert data on table where primray key is in
> captial letters and table contains OIDS
>
> Thanks,
> Khushboo
>

--001a11406f1830af6c05665ac960
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello Kushboo,<div><br></div><div>Can we add some Unit tes=
t to ensure this does not happen again?</div><div><br></div><div>Thanks</di=
v><div>Joao</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr">On T=
hu, Mar 1, 2018 at 2:28 AM Khushboo Vashi &lt;<a href=3D"mailto:khushboo.va=
shi@enterprisedb.com">khushboo.vashi@enterprisedb.com</a>&gt; wrote:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left=
:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>P=
lease find the attached patch to fix RM # 3135 - [Web based] Syntax error d=
isplayed when user try to insert data on table where primray key is in capt=
ial letters and table contains OIDS</div><div><br></div><div>Thanks,</div><=
div>Khushboo</div></div>
</blockquote></div>

--001a11406f1830af6c05665ac960--