MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxowyMCS4DJBWm1sN-iAudt05Bii88mbxu-SPXRAK35S7jA@mail.gmail.com>
References: 
 <CAF+OSJsUY01H6T7EOKO+AzN9Rt-BekzxCWWP47jWGC+mSi2sPA@mail.gmail.com>
 <CA+OCxowyMCS4DJBWm1sN-iAudt05Bii88mbxu-SPXRAK35S7jA@mail.gmail.com>
From: Raffi Holzer <rholzer@pivotal.io>
Date: Tue, 14 Feb 2017 10:02:42 -0500
Message-ID: 
 <CAF+OSJvuDCOKMihuR0-WoJekG+S9P+Dd8tM9Ukqan5dKnXcBcA@mail.gmail.com>
Subject: Re: Autoformatting
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a113f6fde1f3da605487edbdd
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a113f6fde1f3da605487edbdd
Content-Type: text/plain; charset=UTF-8

Hi Dave,
 When we were talking about auto formatting we were actually referring to a
single button press doing all of these things to a large block of text. The
use case here would be if you receive a large illegible query and paste it
into the query editor it would either automatically auto-format or you
would press a button and it would auto-format. We are trying to determine a
few things. One, are there preferred formatting guidelines and two, how
should this autoformatting be implemented? On a button press? Upon pasting
in the text?

On Tue, Feb 14, 2017 at 5:53 AM, Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Mon, Feb 13, 2017 at 9:35 PM, Raffi Holzer <rholzer@pivotal.io> wrote:
> > Hi Hackers,
> >  We are looking into auto formatting SQL text in the SQL editor. However,
> > some users have expressed that this can be done in different ways. Are
> there
> > preferences in this community fo rhow autoformatting should be done?
>
> I think that really depends on the specific feature being discussed.
> For example, auto-indentation is very handy, and whilst it (and most
> formatting features) should be configurable, I suspect many people
> will leave it turned on. On the other hand, something like
> auto-upper-casing of keywords may be either automatic, or shortcut
> initiated, e.g. hit Ctrl+U to upper-case the word under the cursor.
>
> Perhaps you should start by listing the specific features? For
> reference, here's what pgAdmin 3 had:
>
> * The auto-indent feature will automatically indent text to the same
> depth as the previous line when you press return.
> * Block indent text by selecting two or more lines and pressing the Tab
> key.
> * Block outdent text that has been indented using the current tab
> settings using Shift+Tab.
> * Comment out SQL by selecting some text and pressing the Control+K.
> * Uncomment SQL by selecting some text starting with a comment and
> pressing Control+Shift+K.
> * Shift the selected text to upper case by pressing Control+U.
> * Shift the selected text to lower case by pressing Control+Shift+U.
>
> pgAdmin 4 currently has:
>
> * Auto-indent (not currently possible to disable it)
>
> I'd definitely like to see the rest (and anything else that seems
> useful) added, and made configurable where appropriate. I suspect the
> only ones that should be truly automatic are auto-indent and and
> upper-casing of keywords.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Raffi Holzer
Product Manager
Pivotal Labs

--001a113f6fde1f3da605487edbdd
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Dave,<div>=C2=A0When we were talking about auto formatt=
ing we were actually referring to a single button press doing all of these =
things to a large block of text. The use case here would be if you receive =
a large illegible query and paste it into the query editor it would either =
automatically auto-format or you would press a button and it would auto-for=
mat. We are trying to determine a few things. One, are there preferred form=
atting guidelines and two, how should this autoformatting be implemented? O=
n a button press? Upon pasting in the text?</div></div><div class=3D"gmail_=
extra"><br><div class=3D"gmail_quote">On Tue, Feb 14, 2017 at 5:53 AM, Dave=
 Page <span dir=3D"ltr">&lt;<a href=3D"mailto:dpage@pgadmin.org" target=3D"=
_blank">dpage@pgadmin.org</a>&gt;</span> wrote:<br><blockquote class=3D"gma=
il_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-lef=
t:1ex">Hi<br>
<span class=3D""><br>
On Mon, Feb 13, 2017 at 9:35 PM, Raffi Holzer &lt;<a href=3D"mailto:rholzer=
@pivotal.io">rholzer@pivotal.io</a>&gt; wrote:<br>
&gt; Hi Hackers,<br>
&gt;=C2=A0 We are looking into auto formatting SQL text in the SQL editor. =
However,<br>
&gt; some users have expressed that this can be done in different ways. Are=
 there<br>
&gt; preferences in this community fo rhow autoformatting should be done?<b=
r>
<br>
</span>I think that really depends on the specific feature being discussed.=
<br>
For example, auto-indentation is very handy, and whilst it (and most<br>
formatting features) should be configurable, I suspect many people<br>
will leave it turned on. On the other hand, something like<br>
auto-upper-casing of keywords may be either automatic, or shortcut<br>
initiated, e.g. hit Ctrl+U to upper-case the word under the cursor.<br>
<br>
Perhaps you should start by listing the specific features? For<br>
reference, here&#39;s what pgAdmin 3 had:<br>
<br>
* The auto-indent feature will automatically indent text to the same<br>
depth as the previous line when you press return.<br>
* Block indent text by selecting two or more lines and pressing the Tab key=
.<br>
* Block outdent text that has been indented using the current tab<br>
settings using Shift+Tab.<br>
* Comment out SQL by selecting some text and pressing the Control+K.<br>
* Uncomment SQL by selecting some text starting with a comment and<br>
pressing Control+Shift+K.<br>
* Shift the selected text to upper case by pressing Control+U.<br>
* Shift the selected text to lower case by pressing Control+Shift+U.<br>
<br>
pgAdmin 4 currently has:<br>
<br>
* Auto-indent (not currently possible to disable it)<br>
<br>
I&#39;d definitely like to see the rest (and anything else that seems<br>
useful) added, and made configurable where appropriate. I suspect the<br>
only ones that should be truly automatic are auto-indent and and<br>
upper-casing of keywords.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Dave Page<br>
Blog: <a href=3D"http://pgsnake.blogspot.com" rel=3D"noreferrer" target=3D"=
_blank">http://pgsnake.blogspot.com</a><br>
Twitter: @pgsnake<br>
<br>
EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" rel=3D"noreferrer"=
 target=3D"_blank">http://www.enterprisedb.com</a><br>
The Enterprise PostgreSQL Company<br>
</font></span></blockquote></div><br><br clear=3D"all"><div><br></div>-- <b=
r><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div di=
r=3D"ltr">Raffi Holzer<div>Product Manager</div><div>Pivotal Labs</div></di=
v></div>
</div>

--001a113f6fde1f3da605487edbdd--