Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etbgp-0006Gv-Qb for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:13:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etbgo-0002Ze-J1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:13:14 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etbgo-0002ZU-60 for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 16:13:14 +0000 Received: from mail-ot0-x22b.google.com ([2607:f8b0:4003:c0f::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etbgk-0002FF-To for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 16:13:12 +0000 Received: by mail-ot0-x22b.google.com with SMTP id t2so2540040otj.4 for ; Wed, 07 Mar 2018 08:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0vENbAYXXZptKn7EwBmOJEv9p6+OC2ufIMUveri/gm8=; b=QsWph26xwtADQsZVhhmnjLAeO1IwirMR5MgVfnVBeTvpsvcX8h8eRLbyC/+4mgY+3E MKCmJGvitDYHixuqSO2ylvrTRDHHTvE1urT47tpTxl/a+T95O59+SI22JSirR4dRRLc/ Gcf2EcBOWlNtJPZsDEd1P153vOf0lPo+D285MiowbyfnpWoRldJlyCSrAm9VrVu9F2JY kDVtDIhyyuORgR1jyyKiI7/3IKluGmaCqNlwhYIsAfGQ8IRS8z7fS2nVV3/t4kgSUMgy lGNLYKl9tS2Fw6qUwFg0rLPBlOwXbGFT8LXnMbkJKqYHL9wMQhu5d2GlGi5Fbcxfpwh8 /xeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0vENbAYXXZptKn7EwBmOJEv9p6+OC2ufIMUveri/gm8=; b=qj16B//qYrEzucELH37R23KtLvb4aeAO4lgcj4ixk5FpMl0r3uuwiekLJ2OJdDGPMc hirQH7MEGbu1RcBh61rsVD2hTceOyvY4IDeZWRfdm+JJc79ah20AHy0DlLLb1NLmNWCz v0JFbhr+wirvPQw5GcPt4BascqDAN/72rbvGtEyVhU9RbeUKqmOgpI++wm6l+liQEvi4 8E9MKcIhyJ7q4wwzqZb+TAxBRqeHzQ8leutMes2KNVaP80JNkGUxNiACuR++xAfGw4rW QCDZXBWe5Cs8HbCwqwpFFbV51P/CLla2IY2E+AH5rDvVZLVsc1Tn2Aqy6sN9A8T7QHQv MZvA== X-Gm-Message-State: AElRT7H/oH10HadFcSu3jXR5cfN+oo4XgPNutbQHjxwFRQgcZiycjGFF CSICGtmI283rzQWOrG+RNpKjPQW7LQcDWy9yvLIhTw== X-Google-Smtp-Source: AG47ELtfNpOWXZZoSWNUrVcKpaSBhHIvs/2fOvdQmOaWUUABJdN3SVqMKAVftL9jZVpOXN3q6qi05GLVowKqMMvX2Q8= X-Received: by 10.157.37.206 with SMTP id q72mr15107017ota.296.1520439188860; Wed, 07 Mar 2018 08:13:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Wed, 7 Mar 2018 08:13:08 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Khushboo Vashi Date: Wed, 7 Mar 2018 21:43:08 +0530 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113d747cc1825f0566d4d559" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d747cc1825f0566d4d559 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: > Hi > > On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: >> >>> Khushboo, can you look at this ASAP please? It passed tests on my >>> machine, but Jenkins isn't happy. >>> >>> I have tried to reproduce the issue with many combination but couldn't >> reproduce it. >> With the help of logs, I have tried to fix it. Can you please check this >> fix is helpful or not? >> > > On my laptop I now get: > > ====================================================================== > ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool. > TestPollQueryTool) > When query tool polling returns messages with result data-set > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/ > tests/test_poll_query_tool.py", line 104, in runTest > response_data['data']['additional_messages']) > File "/System/Library/Frameworks/Python.framework/Versions/2.7/ > lib/python2.7/unittest/case.py", line 802, in assertIn > if member not in container: > TypeError: argument of type 'NoneType' is not iterable > > ---------------------------------------------------------------------- > > Please provide some more details. Is this failing for particular server version? I am not getting any error with this patch and without this patch on PY2 and PY3 with a single/multiple servers. > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d747cc1825f0566d4d559 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Mar 7, 2018 at 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On We= d, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@en= terprisedb.com> wrote:
Hi Dave,

On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:
Khushboo, can you look at this ASAP please? It passed tests on my = machine, but Jenkins isn't happy.

I have tried to reproduce the issue with many combination but could= n't reproduce it.
With the help of logs, I have tried to fix = it. Can you please check this fix is helpful or not?=C2=A0

On my laptop I now get:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.tools.sqleditor.t= ests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set
----------------------------------------------------------------------
Traceback (most recent call last):
=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/t= ests/test_poll_query_tool.py", line 104, in runTest
=C2= =A0 =C2=A0 response_data['data']['additional_messages'= ])
=C2=A0 File "/System/Library/Frameworks/Python.frame= work/Versions/2.7/lib/python2.7/unittest/case.py", line 802,= in assertIn
=C2=A0 =C2=A0 if member not in container:
= TypeError: argument of type 'NoneType' is not iterable
---------------------------------------------------------= -------------=C2=A0

=
Please provide some more details. Is this fai= ling for particular server version?
I am not getting any error wi= th this patch and without this patch on PY2 and PY3 with a single/multiple = servers.

=C2=A0
-= -
Dave Page
Blo= g: http://pgsnake= .blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113d747cc1825f0566d4d559--