Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glsIj-0003Bs-PN for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 09:24:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glsIi-0003us-M6 for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 09:24:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glsFc-0000D3-Ef for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 09:21:44 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glsFZ-0000Sc-8m for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 09:21:42 +0000 Received: by mail-oi1-x231.google.com with SMTP id w13so16807855oiw.9 for ; Tue, 22 Jan 2019 01:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9qrvK9/moRpwWS/LvrDPLCCJE6+MAUsXVZcR1SPKniM=; b=Zx62ccu9YzOP+Zz6o22DMRDx2goE/HoT6fmzywPBFoleFnV1FqDSQNNXcdBfjmOyZ2 oBWu3CzGCO7UD7ScW/2jmzMvzhWJzjqUGwm72tlf/nhWGom2564lvc2OPAIeyvb6NEah aQCrCh3e84jU0/v50VZovZ16a34X+gZdRHeRvsrisHK0IV4sb4GJMJZ5PMP4P6F0KHih Q2BJE5L/azAKFyJBNJtlzZpd1eOPKcR/NfGeInaDJ5e8+z8xDV3rIMfocJ9lsMxuYbke Q5fb176GdQEXtD5m9WXkeKv3adMEikvPmoK3Q/plDjZn59Rnr1ndjtLvw1zoSb6Y5R9c itug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9qrvK9/moRpwWS/LvrDPLCCJE6+MAUsXVZcR1SPKniM=; b=MWoI56GHPpYpTQo0J8PkhROhn4qRfH0IqK5/KZBpBoDaj3f7DdZL9L+bU2Y9mIkOQr QhwPoZ8T75FSXz8kpfRhJfAZ7qtB2lBsfuU9ot8rz9RC+hZsXlZmFJ/hzarNM60cHch4 eI7BBs1wZDHg+rXBSCxEIJMKxAOfFko/d/XXMD43wh41dDyvkWscScsMP5X1/31rN1Dr q2HS6tv6jXnqzeK7R3NVf5J4pRSVLNzR5/uMdAlU7fCNmhfPy9wLZboueIIHXkzKq0fi STrvvB4A3OVqgXBF37jDGyiFvaN1c0D3V+5gUdOM1XVE0muezhMe5GzU8qvyQe9MP2Hq fZPA== X-Gm-Message-State: AJcUukec8yWTbIn+rbPIhS+fC95wjE/+fnTb4ZefAz30BLI5N/yp4zNP RIuxe20syvwFXlFEu49+HT2PCTdmN+M5gU0piJ0LUQ== X-Google-Smtp-Source: ALg8bN5h3bA/xfVdmtJmDAPkKon5+2hXQlWoM+HITgG1dC2U2yRs3kf5dMp1CoYUcAnq/uje8u/J2o3jY1jGRHcCw28= X-Received: by 2002:aca:ab16:: with SMTP id u22mr8123964oie.249.1548148900185; Tue, 22 Jan 2019 01:21:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 22 Jan 2019 14:51:29 +0530 Message-ID: Subject: Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation To: Akshay Joshi Cc: Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000415e7e05800881f2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000415e7e05800881f2 Content-Type: text/plain; charset="UTF-8" The patch looks good to me. On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it. > > On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached updated patch. >> In this patch I have fixed two issues: >> i. Dialog tab navigation should work even if focus is on footer buttons >> (Save, Cancel, etc..) >> ii. Focus should be set to first editable element of dialog when tab >> cycle goes through all editable footer buttons. >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> This patch fixes Dialog tabset keyboard navigation. >>> This regression was caused due to bootstrap 4 changes. >>> Also I have added jasmine test cases for the same >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --000000000000415e7e05800881f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The patch looks good to me.

On Mon, Jan 21, 2019 at 4:= 39 PM Akshay Joshi <aks= hay.joshi@enterprisedb.com> wrote:
Hi Khushboo=C2=A0

=
Can you please review it.

On Wed, Jan = 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> w= rote:
Hi,

Please find attached updated patch.
In this patch I have fixed two issues:
i. Dialog tab navigatio= n should work even if focus is on footer buttons (Save, Cancel, etc..)
ii. Focus should be set to first editable element of dialog when tab = cycle goes through all editable footer buttons.

--=C2=A0
Harshal = Dhumal
Sr. Software Engineer

EnterpriseDB= India:=C2=A0http://www.enterprisedb= .com
The Enterprise PostgreSQL Comp= any
<= /div>


On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <= harsha= l.dhumal@enterprisedb.com> wrote:
Hi,
This patch fixes=C2=A0Dialog tabset keyboard navigation.
This = regression was caused due to bootstrap 4 changes.
Also I have add= ed jasmine test cases for the same


=
--=C2=A0
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India:=C2=A0http://www= .enterprisedb.com
= The Enterprise Post= greSQL Company


--
Sr. Software Architect


Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246
--000000000000415e7e05800881f2--