Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jBab6-0002BG-CI for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Mar 2020 08:50:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jBab3-0001Mt-8W for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Mar 2020 08:50:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jBab2-0001Mm-Ur for pgadmin-hackers@lists.postgresql.org; Tue, 10 Mar 2020 08:50:41 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jBab0-0005bi-AI for pgadmin-hackers@postgresql.org; Tue, 10 Mar 2020 08:50:40 +0000 Received: by mail-lj1-x22d.google.com with SMTP id q19so13133571ljp.9 for ; Tue, 10 Mar 2020 01:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1X4VBCczbuLXNsv/tNc9lDryQdHe3pVkDx1GXmwcOBM=; b=ovoIoZ6ZDT6+kzM/sPLNvhA7L1HkT7i2G9AS6xUWpj79+pPjeIyLTNd1kZortLhwqF uXFHLb2ZVL51Utz9OWbJM6X5y61n0jX1KM7YiI1ni96bzWPBtN5klT7rYVmrr1FqMpy/ gYmgHZRQrfzSssFkVCabGCrHm9nRsQ5ygLBfwghyGnIEprp4VOGHPX1wt1TqBrk81NWR 7SXn7gluZMsnIozLiTQxGlUIQ4DIi1qpRpHnDiO+xgDEjv2uesP71UQyAe18XUQEhoBk kf84D7zg18bLPO1EqoBY56Sb3tSnaJtyJn5HRrZr11VW7RxnZTh3NddWuiMbWfGQ0SbE YZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1X4VBCczbuLXNsv/tNc9lDryQdHe3pVkDx1GXmwcOBM=; b=nrvdGb1QFgagrdJLgxUWiSXVJWDmqh1nH1nZm5llOO3YOlxPqcXZF1a4J8CHh6l8Mf 7PsrQg54fwaG6PsuR7WisqS5ScF8eTI172DkU5p8PBAhRA4cknfwObPMYVrsfwuMwD98 kwb/iJnG7zWpDNk1a1J/IBcpnkQd/K3PoatHRJqttpQHi/2hRApYQRLJLloowcSuu21x HcEQLokdeAuPLv2IfhNOYCIDBNH7GAM8SvQ3+DrBT7+E67M3ahddfFZ9aeq6A7MhNaAl PXYrie7UGZPemSUk6vMGD2zyDc1XhE/vplaXjh1HU39kEtnS305rc07niP/x5MZtbv5I l4lw== X-Gm-Message-State: ANhLgQ2iFdG97eePRcecS9mk3N4XN7AD29KZ3aU+zB5FeS8WVPrgagRF zrTj87hUGxl3Q+asoabiCmo38UQdJ6xYFRgBSj3ZuMXrpWc6ccux13LzRITzPmd97oVXMajabNW 5ff9m6SYYPebjIsBe99faxuOIaXjVDWMltlEonZxVsoo2eVoaBHGQFFkxPsNpyOF7/GyTIlHv68 VFvzU2WEr9amywTA3GWH+FCcYqaTYsOoc773HvCA8rufE+FSe5XWc= X-Google-Smtp-Source: ADFU+vsHYXZ3XtwLm1HmkSQLjw5W7EWF/dMEBTOGC7LGa5dP6tVeXEWOYIgIuDSpS973+Brcu62YDKcxIqF5A1/iJ50= X-Received: by 2002:a2e:585a:: with SMTP id x26mr12458480ljd.33.1583830237124; Tue, 10 Mar 2020 01:50:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 10 Mar 2020 14:20:29 +0530 Message-ID: Subject: Re: [PgAdmin][RM4237]: User can not change value of Datetime picker control using keyboard (Accessibility). To: Akshay Joshi Cc: Pradip Parkale , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ab3afb05a07c364e" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ab3afb05a07c364e Content-Type: text/plain; charset="UTF-8" Hi Pradip, Looks like you have repeated below code in if and else both the conditions. let $el = this.$el.find('.datetimepicker-input'); let currdate = $el.data('datetimepicker').date().clone(); We can optimize this code by taking these both lines above if condition. Thanks, Khushboo On Tue, Mar 10, 2020 at 1:24 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Mar 10, 2020 at 1:17 PM Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Hi Akshay, >> I have already added the code to change the time. To select the time >> picker, the user needs to press 'Alt+T' (Option+T for mac) and then >> Up/Down arrows to change the minutes and Alt + Up/Down to change the hours. >> >> On Mon, Mar 9, 2020 at 11:09 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Pradip >>> >>> I have tested the patch. I am able to navigate the dates using the >>> keyboard, but not able to select the year/month and time. Can you please >>> work on it and send the patch again. >>> >>> On Sat, Mar 7, 2020 at 7:00 PM Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is a patch to change the Datetime picker value using a >>>> keyboard. >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> QMG, EnterpriseDB Corporation >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > --000000000000ab3afb05a07c364e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Pradip,

Looks like you have repeated= below code in if and else both the conditions.

let=C2=A0$el=C2=A0=3D=C2=A0this.$el.find('.da= tetimepicker-input');
let=C2=A0currdat= e=C2=A0=3D=C2=A0$el.data('datetimepicker').date().clone();

We can optimize this code by taking these both lines above i= f condition.
<= br>
Thanks,
Khushboo<= /div>

On Tue, Mar 10, 2020 at 1:24 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
T= hanks, patch applied.

On Tue, Mar 10, 2020 at 1:17 PM Pradip Parkale <pradip.pa= rkale@enterprisedb.com> wrote:
Hi Akshay,
I have already=C2=A0a= dded the code to change the time. To select the time picker, the user needs= to press 'Alt+T' (Option+T for mac) =C2=A0and then Up/Down arrows = to change the minutes and Alt=C2=A0+ Up/Down to change the hours.

On M= on, Mar 9, 2020 at 11:09 AM Akshay Joshi <akshay.joshi@enterprisedb.com> = wrote:
Hi=C2=A0Pradip

I have tested the patch. I am ab= le to navigate the dates using the keyboard, but not able to select=C2=A0th= e year/month and time. Can you please work on it and send the patch again.<= /div>

On Sat, Mar 7, 2020 at 7:00 PM Pradip Parkale <pradip.parkale@enterprised= b.com> wrote:
Hi Hackers,

Attached=C2=A0is a pat= ch to change the Datetime picker value using a keyboard.


--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=
--000000000000ab3afb05a07c364e--