public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Fixed typos in datamodel.js
Date: Mon, 18 Apr 2016 11:55:35 +0530
Message-ID: <CAFOhELc9pTuT+j3EOS=J5Bo1fLR2XoxMTK-mUjmUSasm=V9wJw@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Due to some typos in datamodel.js, the application does not load properly
in Google Chrome (ver: 39).

Fixed typos in datamodel.js

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_datamodel_js.patch (888B, 3-pgAdmin4_datamodel_js.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/datamodel.js b/web/pgadmin/browser/static/js/datamodel.js
index 71bd959..fa60f7c 100644
--- a/web/pgadmin/browser/static/js/datamodel.js
+++ b/web/pgadmin/browser/static/js/datamodel.js
@@ -221,12 +221,13 @@ function(_, pgAdmin, $, Backbone) {
               delete obj;
             } else if (obj instanceof Backbone.Collection) {
               obj.each(function(m) {
-                if (m instanceof Bakbone.DataModel) {
+                if (m instanceof Backbone.DataModel) {
                   obj.reset();
                   obj.clear(opts);
                 }
               });
-              Backbone.Collection.prototype.reset.apply(obj, {opts});
+              if (!(opts instanceof Array)){ opts = [opts] }
+              Backbone.Collection.prototype.reset.apply(obj, opts);
               delete obj;
             }
           }

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Fixed typos in datamodel.js
  In-Reply-To: <CAFOhELc9pTuT+j3EOS=J5Bo1fLR2XoxMTK-mUjmUSasm=V9wJw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox