Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpUAg-0007jf-VI for pgadmin-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 08:59:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hpUAe-0001Y3-1x for pgadmin-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 08:59:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpUAd-0001Xw-N3 for pgadmin-hackers@lists.postgresql.org; Mon, 22 Jul 2019 08:59:47 +0000 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpUAa-0005hZ-2x for pgadmin-hackers@postgresql.org; Mon, 22 Jul 2019 08:59:46 +0000 Received: by mail-oi1-x234.google.com with SMTP id a127so29013960oii.2 for ; Mon, 22 Jul 2019 01:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=86nbbO9culfC2mBVlLHFtbmAKF5YDcMuIWAtxq0CRFk=; b=SJNaRruWJayghIQBdQShoOEVeUF3n7oHZt0919y5g9ZWpyaMZrNNauLY092yGaZEz5 B4CSgTYQhoSRjuKXC5xqmN4O5gvB65+MU/7WwUbUntCUmpR/MK6fQNy+cBU9bI56U14y TiPUhVZrfvPicCfm91r4EtvRFu33fUb3KTC4E+kV8cBsjIdMpwvVsf+3k+Y2QeTu7Ku7 zebA9XVjBzaWsRiy4bEIlUOOcXYfrCgBPjeIJAeeU/eZTSmN2iZXVKwPDt2f8/vF+u7X DKqryvlYJ238yjpUy0rof6H5xUClr90/Lq7U7X37Fm99lu8/HuK1WaFiPag0zttlWnNU Jj5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=86nbbO9culfC2mBVlLHFtbmAKF5YDcMuIWAtxq0CRFk=; b=lQBnBEJkS+7wkT58bLej0z+P4JpXydcmYnWIQsRNFemAf4BUvqIC5nRH3itcHxuW17 B4tup9RwXDhofWbKq61WXW3Yv0dB/ZqGSiO6QpI1TfqzqfuBUvxCHQ1pRIfwrLWRM7Bb m3K7V07i/l1vk2hwltqwm13Zl0wbOGs+/YfwaXShPFDaZlj4r69oZ8lUr+kRRenmATpm c0GV1SffiXwvXVxYYnWMIG2feYSXWDSlkb1THoftXx2+28dP6Oh7spIiAjNK9Vkzd6vf M4EAsEymD+k+n4M1YurEsDV5m4FQ4hwkboftuvG8y3P2to0pB6aBOfYpnh9TweYzAaw0 yMQw== X-Gm-Message-State: APjAAAX1Qqad9lqMHex0KJChJYB0S8H7TdOQ6aZnVQh9Xw7/mYHbfq3D IgJPNxczvfDl5b150I+BpZRg1cvhyWpfnzIHoWzeLA== X-Google-Smtp-Source: APXvYqx3auv3DA7fuVKtyhypBE+om3OKz+zOiE5j0r91wuq0f7WUlcbKToQshcEJm3JCGbdF8b6fWmaeHxWsGcaIQUM= X-Received: by 2002:aca:abd8:: with SMTP id u207mr32632774oie.136.1563785981646; Mon, 22 Jul 2019 01:59:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Mon, 22 Jul 2019 14:29:32 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #4333 - Add support for function selectivity. To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f0f0ef058e414bc5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f0f0ef058e414bc5 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 22, 2019 at 2:07 PM Dave Page wrote: > Hi > > In the Trigger and Type dialogues when selecting a function we give a > combo box listing all the functions in the database that match the required > signature. Can't we do this here as well? > Support function should have specific arguments and return type (i.,e. internal), and the user needs to write the code for that function in the C. So, what should we consider here? > On Fri, Jul 19, 2019 at 9:54 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for the RM #4333 - [PG v12] Add support >> for function selectivity. >> >> The patch includes: >> - Support Function implementation for PG/EPAS 12 >> - Documentation updates >> - API Test cases >> >> Thanks, >> Khushboo >> >> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000f0f0ef058e414bc5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jul 22, 2019 at 2:07 PM Dave = Page <dpage@pgadm= in.org> wrote:
Hi

In the Trigger and Type dialogues when selecting a function we give= a combo box listing all the functions in the database that match the requi= red signature. Can't we do this here as well?
<= div>Support function should have specific arguments and return type (i.,e. = internal), and the user needs to write the code for that function in the C.=
So, what should we consider here?
On Fri, Jul 19, 2019 at 9:54 AM Khushboo Va= shi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the RM #4333 -=C2=A0[PG v12] Ad= d support for function selectivity.

The patch includes:
= - Support Function implementation for PG/EPAS 12
- Documentation update= s
- API Test cases

Thanks,
Khushboo
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif">



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company
--000000000000f0f0ef058e414bc5--