MIME-Version: 1.0
References: 
 <CABUevEyMFa0ti59E0CkZfcNDdo6tgtX4PZcXqrK54KzKFfVCBA@mail.gmail.com>
In-Reply-To: 
 <CABUevEyMFa0ti59E0CkZfcNDdo6tgtX4PZcXqrK54KzKFfVCBA@mail.gmail.com>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Tue, 12 Jan 2021 10:29:24 +0530
Message-ID: 
 <CAFOhELcBwMpJ1dUM_XMoA3VSiAz8kBi2h1HXP=OycJ1WkxYx1Q@mail.gmail.com>
Subject: Re: Somewhat excessive version checks
To: Magnus Hagander <magnus@hagander.net>
Cc: pgadmin-hackers <pgadmin-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000043b2905b8ace313"
Precedence: bulk

--000000000000043b2905b8ace313
Content-Type: text/plain; charset="UTF-8"

On Tue, Jan 12, 2021 at 3:36 AM Magnus Hagander <magnus@hagander.net> wrote:

> Hi!
>
> If I read the code correctly, pgadmin will (unless turned off) hit the
> website to check the version.json file for updates *every time it
> starts*.
>
> Wouldn't it make sense to rate limit that to checking say once per 24
> hours maximum? Or even 48?
>
> It seems nobody needs the update *that* quickly, and AFAICT it does
> call out to make that check synchronously on startup which means the
> user is waiting.
>
> Agreed, we should have some mechanism in place to limit the server hit,
maybe an asynchronous call from the client while loading.


> And if/when doing that, it would be useful to include an
> If-Modified-Since header on the request, so the server can just
> respond with a tiny 304 reply when there is no update, which is going
> to be the majority of the time. Or possibly even more efficiently,
> create a custom etag and use If-None-Matches. If you make that etag be
> say the version that the client has, it becomes very cheap to check
> and you don't need to track any extra data.
>
> --
>  Magnus Hagander
>  Me: https://www.hagander.net/
>  Work: https://www.redpill-linpro.com/
>
>
>

--000000000000043b2905b8ace313
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jan 12, 2021 at 3:36 AM Magnu=
s Hagander &lt;<a href=3D"mailto:magnus@hagander.net">magnus@hagander.net</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi=
!<br>
<br>
If I read the code correctly, pgadmin will (unless turned off) hit the<br>
website to check the version.json file for updates *every time it<br>
starts*.<br>
<br>
Wouldn&#39;t it make sense to rate limit that to checking say once per 24<b=
r>
hours maximum? Or even 48?<br>
<br></blockquote><div></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x">
It seems nobody needs the update *that* quickly, and AFAICT it does<br>
call out to make that check synchronously on startup which means the<br>
user is waiting.<br>
<br></blockquote><div>Agreed, we should have some mechanism in place to lim=
it the server hit, maybe an asynchronous call from the client while loading=
.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0=
px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
And if/when doing that, it would be useful to include an<br>
If-Modified-Since header on the request, so the server can just<br>
respond with a tiny 304 reply when there is no update, which is going<br>
to be the majority of the time. Or possibly even more efficiently,<br>
create a custom etag and use If-None-Matches. If you make that etag be<br>
say the version that the client has, it becomes very cheap to check<br>
and you don&#39;t need to track any extra data.<br>
<br></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">-- <br>
=C2=A0Magnus Hagander<br>
=C2=A0Me: <a href=3D"https://www.hagander.net/" rel=3D"noreferrer" target=
=3D"_blank">https://www.hagander.net/</a><br>
=C2=A0Work: <a href=3D"https://www.redpill-linpro.com/" rel=3D"noreferrer" =
target=3D"_blank">https://www.redpill-linpro.com/</a><br>
<br>
<br>
</blockquote></div></div>

--000000000000043b2905b8ace313--