Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMlxE-0004Zm-U6 for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 05:11:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMlxD-0007FC-MZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 05:11:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMlxD-0007F4-Dd for pgadmin-hackers@lists.postgresql.org; Fri, 10 Apr 2020 05:11:47 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMlx8-0001Rx-Kw for pgadmin-hackers@postgresql.org; Fri, 10 Apr 2020 05:11:46 +0000 Received: by mail-lj1-x22f.google.com with SMTP id n23so857062ljg.3 for ; Thu, 09 Apr 2020 22:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D6RhtwmWr3fYCMPE9suHvxQXec9uCKfIawbW0KIovAY=; b=BCGEoJ1/bhVjCZ/JcLtWbzJd8K8yQ/e5NS6CyKQsCfCzh3dDCz6HlpWAt5cRGiR5EV kn6q320TJy5rn9ycxZ1Em9+d/mxX05K8eTNh1Z47xQF6NfyiNz8yr+QQ89ZHP3kXJmdv NBzUD2Sot+ObJIEakxOeN1lzMR+/FV6WPaLzZXQCIsbusWHEYmLBLzNwNu/es4SrYvE1 Oh1ZC/0xXeGh1ZuvC3QtSTh7dyC0FtJ/rcQEC6LcrbkI/UewGa0Cl9pez3zAvBGhyegl vyvfAWRl6yfh3nF2j2MQtpHyNkR+PlkgC4eaESaNAAKc/msxwgCbCufirms/DvFoYjFL mDjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D6RhtwmWr3fYCMPE9suHvxQXec9uCKfIawbW0KIovAY=; b=QMoTkpHipcKMmPZtVBACqkR+VyrYKc+sgm2oGTHl3C0FQDnfKKPfWEDKA1Fp7mN35s jKIpX5J9lnpKDUqoEQIiGMllyBpSiDm/jHgG3m5IqArQcscNQG1AgCwDP2nF489CCADN Px9qTZdtwYcJZCpMGPiUg1mLFU0NLz77cLiO8MKPC8GP+TbnjVsnBw3rMUEt9j+1bZrq WtJlWTisjoUAo/EYzbVABFJJVdO9uZ9m+wDAlk9oP6C5tpdXYwdpnp0xGiiUkzdzSt8O nhD5fhgg540OXsdpcWytRFj7Sgm9IAlLJcjplsMTpdaoWzawj7yydjVOBwRpbn4fSX/3 HJog== X-Gm-Message-State: AGi0PuaSHlNBht1vyWFQCpsKDEnWO6IYVMFNaIq6LgVRJQbl0l56DIfs Wwv+rrQE1Yqns5sn/WuiVMMYhqK20n8iO8mBrqZ1gzgmRwFT64h2NBKdeH8lq6ftSMFa5Q083mM IGq6aWUJVa60sIWnVSZhSr9y8pozmRIeYUTrti8NFgzlBDPM6HeHTFh2jyNhE0Uu2wm00f2xw4m TPfqS4URJH37KFwOFaYkWmOgbxr+HvxLjLDPbs8YApgHRGDyatPu8= X-Google-Smtp-Source: APiQypKo3ard5uM5uL6ttuoBgsXKshaKKCLvQptl4WmpkhpWV8yDEyZNrYmfPYg0HuMcHPghdtoAIMgT4AbYF7y3pj0= X-Received: by 2002:a2e:330e:: with SMTP id d14mr1886177ljc.153.1586495500790; Thu, 09 Apr 2020 22:11:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Fri, 10 Apr 2020 10:41:34 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID. To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c33c8e05a2e8c470" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c33c8e05a2e8c470 Content-Type: text/plain; charset="UTF-8" Hi Akshay, On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi wrote: > Hi Khushboo > > Schema Diff test cases are failing with this patch. Please fix and resend > the patch. > > Can you please re-verify as I don't think schema diff test cases are failing due to this patch. Thanks, Khushboo > On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >> properties does not show OID. >> >> As per the current implementation, we completely ignored OID and instead >> considered the name as the unique field, now with this patch OID will be >> used as an unique id and also will display OID in the properties tab. >> >> Thanks, >> Khushboo >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > --000000000000c33c8e05a2e8c470 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

On Wed, Apr 8, 2020 at 12:33 PM Akshay Josh= i <akshay.joshi@enterpr= isedb.com> wrote:
Hi=C2=A0Khushboo

Schema Diff= test cases are failing=C2=A0with this patch. Please fix and resend the pat= ch.

Can you please re-verify as I don'= t think schema diff test cases are failing due to this patch.
Thanks,
Khushboo=C2=A0
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 -=C2=A0[EPAS] Synonym prope= rties does not show OID.

As per the current implementation, we completely= ignored OID and instead considered the name as the unique field, now with = this patch OID will be used as an unique id and also will display OID in th= e properties tab.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=
--000000000000c33c8e05a2e8c470--