Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ7Tc-0003gS-M0 for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 08:38:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQ7Ta-0005pt-Vt for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 08:37:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ7Ta-0005pj-MQ for pgadmin-hackers@lists.postgresql.org; Tue, 05 Jun 2018 08:37:58 +0000 Received: from mail-ot0-x243.google.com ([2607:f8b0:4003:c0f::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQ7TT-0001Ju-M7 for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 08:37:57 +0000 Received: by mail-ot0-x243.google.com with SMTP id 92-v6so1801241otw.9 for ; Tue, 05 Jun 2018 01:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U+zRAhyiRj0cMDEecTDXdiYgl+iQfj2/GjMX3v+LbGU=; b=mETGuJONRrq8vY5SkWLwfIp8SZtRjReVF97ulfYPbKZQLsorgtD2H3Oi2s/Wk//3zw 5DeIRHZbbyofIY/9LOv1uxIrcdr5upSf4FzOSCAFy9fFniQnJi4gJMEkvcE245DlTojF /bBMcjf+60afdRPwC34hXc30WazQ1y1OGKCnxUGrxm3kI7RcvJu4cRNcNd2DM0lPIzHC ldlbHD+/f2A6TtqaCw5AyqFArDWnqMNQunxeAJ6EhZy4TehvdcNlpUwrgwoLol7Qoxop g5qelnpo6HlmdM9LeKAo3NVLOTwPSPSgGgA8C98SQD7xUGMOh7MJ49hMCgW5p1oCsLEO 8ISg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U+zRAhyiRj0cMDEecTDXdiYgl+iQfj2/GjMX3v+LbGU=; b=O+Ewnzo2+vK4GsfHwv/mClvf9/funvNcE5aULyG6s0qH6uKmVSbcrXgR8E1DZO4Zv2 uF9l/9IRk24fO6cNdSgo50t1qU/a5/vtDrT4yfFuha6VbBvDGbMDEMlGkc2qEIbZ3uG2 MJdij0vncghdJZwACDxhw8LepVRA26L6I79sD+2nh7iIqjkfSc1MabhWCjLbzR5clxyE Py1HKWjUkkQx1CXJZvC2vbBntwUmQfWdZrNYMLxPaP9kqBrY+ubyJ0X3v/ZYZVNR5S8P wIHI/MxtjEQjAvII/Elbmfpok6rtysD1Me6RD7j1NKfR388Jb5Wx1rjp1dCeXcgXvRif QUhQ== X-Gm-Message-State: ALKqPwcuskV2jGZHBRn/PW0klWUftYRLVid9USdlXOPGnrwBJKFzJq7K 1UIRk+vmR5dj+9BQf4/hzbzj8Gn5nkrfikBDhsrg1w== X-Google-Smtp-Source: ADUXVKKcoq1ooyhue+tfspCvvwcPGMP0euXowzkitprCIiToCdQsYEyEmw71MxJ8+99BXOJ6lWSa3Lmh/uoBxCJKakU= X-Received: by 2002:a9d:5302:: with SMTP id g2-v6mr13047970oth.277.1528187869017; Tue, 05 Jun 2018 01:37:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:5301:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 01:37:48 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Tue, 5 Jun 2018 14:07:48 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: Test cases for the backup module To: Dave Page Cc: Joao De Almeida Pereira , Victoria Henry , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000154d66056de0f744" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000154d66056de0f744 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: > Hi > > On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Khushboo, >>> >>> Some tests are failing in greenplum: >>> https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines >>> /pgadmin-patch/jobs/run-tests/builds/108 >>> The piece of code responsible for the error is: >>> >>> if server['default_binary_paths'] is not None: >>> test_utils.set_preference(server['default_binary_paths']) >>> >>> config.DEFAULT_BINARY_PATHS =3D { >>> "pg": str(server['default_binary_paths']['pg']), >>> "ppas": str(server['default_binary_paths']['ppas']), >>> "gpdb": "" >>> } >>> >>> >>> Can you send me the test_config.json file? The above code sets the >> paths to the SQLite database and through the logs couldn't figure out th= e >> exact failure. >> > > It seems clear from the code shown that it's not setting the binary paths > for gpdb database servers. Shouldn't it be something like: > > config.DEFAULT_BINARY_PATHS =3D { > "pg": str(server['default_binary_paths']['pg']), > "ppas": str(server['default_binary_paths']['ppas']), > "gpdb": str(server['default_binary_paths']['gpdb']) > } > > Without this code, the test cases should work as I already set paths through below code. test_utils.set_preference(server['default_binary_paths']) > >> test_backup_utils.py file name is misleading, these are not tests, are >>> helpers. >>> =E2=80=8B >>> >>> >>> Thanks >>> Victoria & Joao >>> >>> On Mon, Jun 4, 2018 at 1:36 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Sat, Jun 2, 2018 at 3:01 AM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> This looks good, except that it's leaving the test_restore_database >>>>> behind. Can we clean that up please? >>>>> >>>>> PFA updated patch. >>>> >>>>> Thanks. >>>>> >>>>> On Fri, Jun 1, 2018 at 7:06 AM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Victoria, >>>>>> >>>>>> Thanks for reviewing the patch. >>>>>> The tests were failing due to the latest commit >>>>>> #2b4605a9d390cb44e5dfe9967c3adf2b28d04f1f - Ensure >>>>>> backup/restore/maintenance work via SSH tunnels. Fixes #3355 >>>>>> >>>>>> I have fixed the issues and attached the updated patch. >>>>>> >>>>>> Thanks, >>>>>> Khushboo >>>>>> >>>>>> On Thu, May 31, 2018 at 10:00 PM, Victoria Henry >>>>>> wrote: >>>>>> >>>>>>> Hi there, >>>>>>> >>>>>>> We've been noticing some issues with the tests on both our CI and >>>>>>> local Mac workstations. >>>>>>> >>>>>>> 1. When the following code blocks are invoked - we get plenty of >>>>>>> app.context() issues. It must not be valid when running tests. >>>>>>> >>>>>>> =E2=80=8B >>>>>>> >>>>>>> from pgadmin.utils.driver import get_driver >>>>>>> driver =3D get_driver(PG_DEFAULT_DRIVER) >>>>>>> manager =3D driver.connection_manager(self.sid) >>>>>>> >>>>>>> host =3D manager.local_bind_host if manager.use_ssh_tunnel else s.h= ost >>>>>>> port =3D manager.local_bind_port if manager.use_ssh_tunnel else s.p= ort >>>>>>> >>>>>>> 2. When we finally enable >>>>>>> >>>>>>> "default_binary_paths": { >>>>>>> >>>>>>> in our test_config, we get more failing tests that look like: >>>>>>> >>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>> FAIL: runTest (pgadmin.tools.restore.tests.test_restore_create_job_= unit_test.RestoreCreateJobTest) >>>>>>> When restore object with option - Miscellaneous >>>>>>> -------------------------------------------------------------------= --- >>>>>>> Traceback (most recent call last): >>>>>>> File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/unittest= /mock.py", line 1179, in patched >>>>>>> return func(*args, **keywargs) >>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/restore= /tests/test_restore_create_job_unit_test.py", line 295, in runTest >>>>>>> self.assertEquals(response.status_code, 200) >>>>>>> AssertionError: 410 !=3D 200 >>>>>>> >>>>>>> And >>>>>>> >>>>>>> When restore object with the sections options ... 2018-05-31 12:24:= 42,988: ERROR pgadmin: illegal environment variable name >>>>>>> Traceback (most recent call last): >>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/restore= /__init__.py", line 352, in create_restore_job >>>>>>> manager.export_password_env(p.id) >>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/utils/driver/= psycopg2/server_manager.py", line 365, in export_password_env >>>>>>> os.environ[str(env)] =3D password >>>>>>> File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/os.py", = line 675, in __setitem__ >>>>>>> self.putenv(key, value) >>>>>>> ValueError: illegal environment variable name >>>>>>> FAIL >>>>>>> >>>>>>> =E2=80=8B >>>>>>> >>>>>>> Sincerely, >>>>>>> >>>>>>> Victoria && Anthony >>>>>>> >>>>>>> On Thu, May 31, 2018 at 1:16 AM Khushboo Vashi < >>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Please find the attached updated patch with the fixes. >>>>>>>> The test cases were only failing on MAC not on Linux. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Khushboo >>>>>>>> >>>>>>>> On Wed, May 30, 2018 at 10:13 AM, Khushboo Vashi < >>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, May 30, 2018 at 1:05 AM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi < >>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> please find the attached updated patch for the test cases of >>>>>>>>>>> Backup, Restore and Maintenance modules which includes: >>>>>>>>>>> >>>>>>>>>>> 1. Unit test cases >>>>>>>>>>> 2. End to end regression test cases >>>>>>>>>>> 3. Feature test cases >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks. I've yet to be able to run the feature tests >>>>>>>>>> successfully. Here's what I've found so far: >>>>>>>>>> >>>>>>>>>> 1) DEFAULT_BINARY_PATHS should be default_binary_paths in the >>>>>>>>>> JSON config file. >>>>>>>>>> >>>>>>>>>> Will do. >>>>>>>>> >>>>>>>>>> 2) I've hit screensize related issues: >>>>>>>>>> >>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>> >>>>>>>>>> ERROR: runTest (pgadmin.feature_tests.pg_util >>>>>>>>>> ities_maintenance_test.PGUtilitiesMaintenanceFeatureTest) >>>>>>>>>> >>>>>>>>>> Test for PG maintenance: database >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>> ---------- >>>>>>>>>> >>>>>>>>>> Traceback (most recent call last): >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /pgadmin/feature_tests/pg_utilities_maintenance_test.py", line >>>>>>>>>> 56, in runTest >>>>>>>>>> >>>>>>>>>> self._open_maintenance_dialogue() >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /pgadmin/feature_tests/pg_utilities_maintenance_test.py", line >>>>>>>>>> 75, in _open_maintenance_dialogue >>>>>>>>>> >>>>>>>>>> "*[.=3D'" + self.table_name + "']/../*[@class=3D'aciTreeItem= '" >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webe= lement.py", >>>>>>>>>> line 80, in click >>>>>>>>>> >>>>>>>>>> self._execute(Command.CLICK_ELEMENT) >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webe= lement.py", >>>>>>>>>> line 628, in _execute >>>>>>>>>> >>>>>>>>>> return self._parent.execute(command, params) >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webd= river.py", >>>>>>>>>> line 312, in execute >>>>>>>>>> >>>>>>>>>> self.error_handler.check_response(response) >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/erro= rhandler.py", >>>>>>>>>> line 242, in check_response >>>>>>>>>> >>>>>>>>>> raise exception_class(message, screen, stacktrace) >>>>>>>>>> >>>>>>>>>> WebDriverException: Message: unknown error: Element >>>>>>>>> class=3D"aciTreeItem">... is not clickable at point (223,= 604). Other >>>>>>>>>> element would receive the click:
>>>>>>>>> wcPanelBackground wcScrollableX wcScrollableY" style=3D"left: 0p= x; right: >>>>>>>>>> 0px; bottom: 0px;">...
>>>>>>>>>> >>>>>>>>>> (Session info: chrome=3D66.0.3359.181) >>>>>>>>>> >>>>>>>>>> (Driver info: chromedriver=3D2.38.552518 >>>>>>>>>> (183d19265345f54ce39cbb94cf81ba5f15905011),platform=3DMac OS X >>>>>>>>>> 10.12.6 x86_64) >>>>>>>>>> >>>>>>>>>> 3) One time the test did start, but then I saw this failure: >>>>>>>>>> >>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>> >>>>>>>>>> ERROR: runTest (pgadmin.feature_tests.pg_util >>>>>>>>>> ities_backup_restore_test.PGUtilitiesBackupFeatureTest) >>>>>>>>>> >>>>>>>>>> Test for PG utilities - Backup and Restore >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>> ---------- >>>>>>>>>> >>>>>>>>>> Traceback (most recent call last): >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /pgadmin/feature_tests/pg_utilities_backup_restore_test.py", >>>>>>>>>> line 93, in runTest >>>>>>>>>> >>>>>>>>>> self.page.fill_input_by_field_name("file", >>>>>>>>>> "test_backup_file") >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /regression/feature_utils/pgadmin_page.py", line 211, in >>>>>>>>>> fill_input_by_field_name >>>>>>>>>> >>>>>>>>>> self.wait_for_input_field_content(field_name, field_content) >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /regression/feature_utils/pgadmin_page.py", line 251, in >>>>>>>>>> wait_for_input_field_content >>>>>>>>>> >>>>>>>>>> "field to contain '" + str(content) + "'", >>>>>>>>>> input_field_has_content >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /regression/feature_utils/pgadmin_page.py", line 337, in >>>>>>>>>> _wait_for >>>>>>>>>> >>>>>>>>>> "Timed out waiting for " + waiting_for_message >>>>>>>>>> >>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/support/wai= t.py", >>>>>>>>>> line 80, in until >>>>>>>>>> >>>>>>>>>> raise TimeoutException(message, screen, stacktrace) >>>>>>>>>> >>>>>>>>>> TimeoutException: Message: Timed out waiting for field to contai= n >>>>>>>>>> 'test_backup_file' >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> (with screenshot attached) >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> I have ran the feature tests with multiple servers many times bu= t >>>>>>>>> didn't get a single failure. >>>>>>>>> I have asked Akshay to run on his machine, let see what he gets. >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Khushboo >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Wed, Apr 25, 2018 at 9:40 PM, Joao De Almeida Pereira < >>>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Khushboo, >>>>>>>>>>>> >>>>>>>>>>>> We reviewed the patch and it is very nice to see some more >>>>>>>>>>>> coverage in this area. Good job :D >>>>>>>>>>>> >>>>>>>>>>>> We passed the tests through our CI the feature tests are not >>>>>>>>>>>> passing, but the linter fails: >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:37: [E501]= line too long (91 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:53: [E501]= line too long (104 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:59: [E501]= line too long (85 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:62: [E501]= line too long (96 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:63: [E501]= line too long (91 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:70: [E501]= line too long (118 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:37: [E121]= continuation line under-indented for hanging indent >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:48: [E122]= continuation line missing indentation or outdented >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251]= unexpected spaces around keyword / parameter equals >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251]= unexpected spaces around keyword / parameter equals >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:51: [E501]= line too long (91 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:52: [E501]= line too long (94 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:53: [E501]= line too long (108 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:81: [E501]= line too long (113 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:82: [E501]= line too long (94 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:83: [E501]= line too long (108 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:111: [E501= ] line too long (100 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:113: [E501= ] line too long (94 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:114: [E501= ] line too long (108 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:147: [E501= ] line too long (93 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:40: [E121] = continuation line under-indented for hanging indent >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:51: [E122] = continuation line missing indentation or outdented >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:135: [E501]= line too long (80 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:137: [E501]= line too long (83 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:138: [E122]= continuation line missing indentation or outdented >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:139: [E122]= continuation line missing indentation or outdented >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:140: [E122]= continuation line missing indentation or outdented >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:191: [E501]= line too long (81 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:203: [E501]= line too long (80 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E128]= continuation line under-indented for visual indent >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E501]= line too long (94 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E128]= continuation line under-indented for visual indent >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E501]= line too long (94 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:216: [W391]= blank line at end of file >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:296: [E= 501] line too long (97 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:317: [E= 303] too many blank lines (2) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:336: [E= 501] line too long (84 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:371: [W= 391] blank line at end of file >>>>>>>>>>>> >>>>>>>>>>>> 2 E121 continuation line under-indented for hanging inde= nt >>>>>>>>>>>> >>>>>>>>>>>> 5 E122 continuation line missing indentation or outdente= d >>>>>>>>>>>> >>>>>>>>>>>> 2 E128 continuation line under-indented for visual inden= t >>>>>>>>>>>> >>>>>>>>>>>> 2 E251 unexpected spaces around keyword / parameter equa= ls >>>>>>>>>>>> >>>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>>> >>>>>>>>>>>> 24 E501 line too long (91 > 79 characters) >>>>>>>>>>>> >>>>>>>>>>>> 2 W391 blank line at end of file >>>>>>>>>>>> >>>>>>>>>>>> 38 >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> For the feature tests, we realized we had to update the >>>>>>>>>>>> configuration, and we did that, but we get the following error= attached. We >>>>>>>>>>>> spent some time trying to understand the problem but we were n= ot successful. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Codewise: >>>>>>>>>>>> - We just found some One Letter Variables in the code... >>>>>>>>>>>> - Looks like there is a bug report in this area of the code an= d >>>>>>>>>>>> we do not have coverage for it: https://redmine.postgresql >>>>>>>>>>>> .org/issues/3232 >>>>>>>>>>>> Looks like in some of the unit tests we only have happy path >>>>>>>>>>>> tests, maybe we should see if there are any sad paths that als= o need >>>>>>>>>>>> coverage. >>>>>>>>>>>> >>>>>>>>>>>> The configuration change, maybe need to be updated. When we >>>>>>>>>>>> install multiple versions of postgres the binaries live in >>>>>>>>>>>> `/usr/lib/postgresql/{{db_version}}/bin`, which makes us think >>>>>>>>>>>> that this configuration should live near the server configurat= ion, maybe? >>>>>>>>>>>> Also to maintain coherency on the naming maybe we should make = it all lower >>>>>>>>>>>> case. >>>>>>>>>>>> Just as an aside, you can add the gpdb configuration as well i= n >>>>>>>>>>>> you patch. >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> Victoria & Joao >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Apr 25, 2018 at 5:20 AM Khushboo Vashi < >>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Please find the attached patch which covers test cases for th= e >>>>>>>>>>>>> backup module (RM #3206). >>>>>>>>>>>>> >>>>>>>>>>>>> 1. Unit test cases >>>>>>>>>>>>> 2. End to end regression test cases >>>>>>>>>>>>> 3. Feature test cases >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Khushboo >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000154d66056de0f744 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Jun 5, 2018 at 1:36 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tu= e, Jun 5, 2018 at 4:39 AM, Khushboo Vashi <khushboo.vashi@en= terprisedb.com> wrote:


On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,

Some tests are failing in greenplum:
https://gpdb-dev.bosh.pivotalci.info/tea= ms/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/108<= /div>
The piece of code responsible for the error is:
if server['default_bin=
ary_paths'] is not None:
    test_utils.set_preference(server['default_binary_paths'])

    config.DEF=
AULT_BINARY_PATHS =3D {
        &q=
uot;pg": str(serv=
er['default_binary_paths'=
;]['pg']),
        "ppas"=
;: str(server['default_binary_paths'][<=
span style=3D"color:rgb(106,135,89)">'ppas']),
  =
      "gpdb":=
 ""
    }

Can you send me the test_config.json file?=C2=A0 The above code = sets the paths to the SQLite database and through the logs couldn't fig= ure out the exact failure.=C2=A0
<= br>
It seems clear from the code shown that it's not s= etting the binary paths for gpdb database servers. Shouldn't it be some= thing like:

    config.DEFAULT_BINARY_PATHS =
=3D {
        "pg": str(server['default_binary_paths']['pg']),
        "ppas": str(server['default_binary_paths']['ppas']),
        "gpdb": str(server['default_binary_paths'][&#=
39;gpdb'])
    <=
/span>}
Without this code, t= he test cases should work as I already set=C2=A0 paths through below code.<= pre style=3D"font-style:normal;font-variant-ligatures:normal;font-variant-c= aps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-inde= nt:0px;text-transform:none;word-spacing:0px;text-decoration-style:initial;t= ext-decoration-color:initial;background-color:rgb(43,43,43);color:rgb(169,1= 83,198);font-family:"Source Code Pro";font-size:9pt"> test_uti= ls.set_preference(server['de= fault_binary_paths'])
=
=C2=A0

test_backup_utils.py file name is misleading, these are not tests, are helpers.

=E2=80=8B
=


Thanks
Victoria &a= mp; Joao

=
On Mon, Jun 4, 2018 at 1:36 AM = Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">


On Sat, Jun 2, 2018 at 3:01 AM, Dave Page= <dpage@pgadmin.org> wrote:
Hi

This looks good, except that it= 9;s leaving the test_restore_database behind. Can we clean that up please?<= /div>

PFA updated patch.=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
Thanks.

On Fri, Jun 1, 2018 at = 7:06 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.co= m> wrote:
= Hi Victoria,

Thanks for reviewing the patch.
T= he tests were failing due to the latest commit #2b4605a9d390cb44e5dfe9967c3= adf2b28d04f1f=C2=A0 - Ensure backup/restore/maintenance work via SSH t= unnels. Fixes #3355

I have fixed the issues and at= tached the updated patch.

Thanks,
Khushb= oo=C2=A0
=

On Thu, May 31, 2018 at 10:00 PM, Victori= a Henry <vhenry@pivotal.io> wrote:
Hi there,

We've been not= icing some issues with the tests on both our CI and local Mac workstations.=
  1. When the following code blocks are invoked -= we get plenty of app.context() issues. It must not= be valid when running tests.
=E2=80=8B
= 
from pgadmin.utils.driver import get_driver
driver =3D get_driver(PG_DEFAULT_DR=
IVER)
manager =3D driver.connection_manager(self.sid)

host =3D manager.local_bind_host if manager.use_ssh_tunnel else s.host
port =3D manager.local=
_bind_port if manager.use_ssh_=
tunnel else s.port=C2=A0
=
2. When we finally enable=C2=A0
"default_binary_=
paths": {
in our test_config, we get more failing tests that look like:
= 
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.tools.restore.tests.test_restore_create_job_uni=
t_test.RestoreCreateJobTest)
When restore object with option - Miscellaneous
-----------------------------------------------------------------=
-----
Traceback (most recent call last):
  File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/unitte=
st/mock.py", line 1179, in patched
    return func(*args, **keywargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/resto=
re/tests/test_restore_create_job_unit_test.py", line 295, in=
 runTest
    self.assertEquals(response.status_code, 200)
AssertionError: 410 !=3D 200

And

When restore object =
with the sections options ... 2018-05-31 12:24:42,988: ERROR    pgadmin:   =
 illegal environment variable name
Traceback (most recent call last):
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/resto=
re/__init__.py", line 352, in create_restore_job
    manager.export_password_env(p=
.id)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/utils/drive=
r/psycopg2/server_manager.py", line 365, in export_password_env
    os.environ[str(env)] =3D password
  File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/os.py&=
quot;, line 675, in __setitem__
    self.putenv(key, value)
ValueError: illegal environment variable name
FAIL
=E2=80=8B
=

Sincerely,

Vi= ctoria && Anthony

On Thu, May 31, 2018 at 1:16 AM Khushboo Vashi <khushboo.vashi@enterp= risedb.com> wrote:
Hi,

Please find the attached updated patch = with the fixes.
The test cases were only failing on MAC not on Li= nux.

Thanks,
Khushboo

On Wed, May 30, 2018 at = 10:13 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.c= om> wrote:


On Wed= , May 30, 2018 at 1:05 AM, Dave Page <dpage@pgadmin.org> wro= te:
Hi

On Mon, May 28, 2018 at 8= :09 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:
Hi,

please find the attached updated patch f= or the test cases of Backup, Restore and Maintenance modules which includes= :

1. Unit test cases
2. End to end regr= ession test cases=C2=A0
3. Feature test cases

Thanks. I've yet to be able to = run the feature tests successfully. Here's what I've found so far:<= /div>

1) DEFAULT_BINARY_PATHS should be default_binary_p= aths in the JSON config file.

Will do.=C2=A0
2) I've hit screensize = related issues:

= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

ER= ROR: runTest (pgadmin.feature_tests.pg_utilities_maintenance_test.PGUt= ilitiesMaintenanceFeatureTest)

Te= st for PG maintenance: database

--= -----------------------------------------------------------------= ---

Tr= aceback (most recent call last):

=C2=A0 File "/Users/dpage/git/pga= dmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py&= quot;, line 56, in runTest

=C2=A0 =C2=A0 self._open_maintenance_d= ialogue()

=C2=A0 File "/Users/dpage/git/pga= dmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py&= quot;, line 75, in _open_maintenance_dialogue

=C2=A0 =C2=A0 "*[.=3D'" = + self.table_name + "']/../*[@class=3D'aciTreeItem'"<= /span>

=C2=A0 File "/Users/dpage/.virtua= lenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/rem= ote/webelement.py", line 80, in click

=C2=A0 =C2=A0 self._execute(Command.CL= ICK_ELEMENT)

=C2=A0 File "/Users/dpage/.virtua= lenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/rem= ote/webelement.py", line 628, in _execute

=C2=A0 =C2=A0 return self._parent.exec= ute(command, params)

=C2=A0 File "/Users/dpage/.virtua= lenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/rem= ote/webdriver.py", line 312, in execute

=C2=A0 =C2=A0 self.error_handler.check= _response(response)

=C2=A0 File "/Users/dpage/.virtua= lenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/rem= ote/errorhandler.py", line 242, in check_response

=C2=A0 =C2=A0 raise exception_class(me= ssage, screen, stacktrace)

We= bDriverException: Message: unknown error: Element <span class=3D"ac= iTreeItem">...</span> is not clickable at point (223, 604). O= ther element would receive the click: <div class=3D"wcFrameCenter w= cPanelBackground wcScrollableX wcScrollableY" style=3D"left: 0px;= right: 0px; bottom: 0px;">...</div>

=C2=A0 (Session info: chrome=3D66.0.33= 59.181)

=C2=A0 (Driver info: chromedriver=3D2.= 38.552518 (183d19265345f54ce39cbb94cf81ba5f15905011),platform=3DMac OS= X 10.12.6 x86_64)


3) One time the test did start, but then I saw this failure:=

= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

ER= ROR: runTest (pgadmin.feature_tests.pg_utilities_backup_restore_test.P= GUtilitiesBackupFeatureTest)

Te= st for PG utilities - Backup and Restore

--= -----------------------------------------------------------------= ---

Tr= aceback (most recent call last):

=C2=A0 File "/Users/dpage/git/pga= dmin4/web/pgadmin/feature_tests/pg_utilities_backup_restore_test.= py", line 93, in runTest

=C2=A0 =C2=A0 self.page.fill_input_by_= field_name("file", "test_backup_file")

=C2=A0 File "/Users/dpage/git/pga= dmin4/web/regression/feature_utils/pgadmin_page.py", line 21= 1, in fill_input_by_field_name

=C2=A0 =C2=A0 self.wait_for_input_fiel= d_content(field_name, field_content)

=C2=A0 File "/Users/dpage/git/pga= dmin4/web/regression/feature_utils/pgadmin_page.py", line 25= 1, in wait_for_input_field_content

=C2=A0 =C2=A0 "field to contain &= #39;" + str(content) + "'", input_field_has_content

=C2=A0 File "/Users/dpage/git/pga= dmin4/web/regression/feature_utils/pgadmin_page.py", line 33= 7, in _wait_for

=C2=A0 =C2=A0 "Timed out waiting = for " + waiting_for_message

=C2=A0 File "/Users/dpage/.virtua= lenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/sup= port/wait.py", line 80, in until

=C2=A0 =C2=A0 raise TimeoutException(m= essage, screen, stacktrace)

Ti= meoutException: Message: Timed out waiting for field to contain 'test_b= ackup_file'



(with screenshot attached)

Thanks.<= /div>
<= br>
I have= ran the feature tests with multiple servers many times but didn't get = a single failure.
I have asked Akshay to run on his machine, let = see what he gets.


=C2=A0

Thanks,
Khus= hboo



=

On Wed, Apr= 25, 2018 at 9:40 PM, Joao De Almeida Pereira <jdealmeidapereir= a@pivotal.io> wrote:
Hi Khushboo,

We reviewed the patch and it is = very nice to see some more coverage in this area. Good job :D
We passed the tests through our CI the feature tests are not pa= ssing, but the linter fails:
./pgadmin/feature_tests/pg_utilitie=
s_backup_test.py:37: [E501] line too long (91 > 79 characters)

./pgadmin/feature_te=
sts/pg_utilities_backup_test.py:53: [E501] line too long (104 > 79 =
characters)

./pgadmin/feature_te=
sts/pg_utilities_backup_test.py:59: [E501] line too long (85 > 79 c=
haracters)

./pgadmin/feature_te=
sts/pg_utilities_backup_test.py:62: [E501] line too long (96 > 79 c=
haracters)

./pgadmin/feature_te=
sts/pg_utilities_backup_test.py:63: [E501] line too long (91 > 79 c=
haracters)

./pgadmin/feature_te=
sts/pg_utilities_backup_test.py:70: [E501] line too long (118 > 79 =
characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:37: [E121] continuation line under-ind=
ented for hanging indent

./pgadmin/tools/back=
up/tests/test_backup_message.py:48: [E122] continuation line missing i=
ndentation or outdented

./pgadmin/tools/back=
up/tests/test_backup_message.py:49: [E251] unexpected spaces around ke=
yword / parameter equals

./pgadmin/tools/back=
up/tests/test_backup_message.py:49: [E251] unexpected spaces around ke=
yword / parameter equals

./pgadmin/tools/back=
up/tests/test_backup_message.py:51: [E501] line too long (91 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:52: [E501] line too long (94 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:53: [E501] line too long (108 > 79 =
characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:81: [E501] line too long (113 > 79 =
characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:82: [E501] line too long (94 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:83: [E501] line too long (108 > 79 =
characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:111: [E501] line too long (100 > 79=
 characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:113: [E501] line too long (94 > 79 =
characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:114: [E501] line too long (108 > 79=
 characters)

./pgadmin/tools/back=
up/tests/test_backup_message.py:147: [E501] line too long (93 > 79 =
characters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:40: [E121] continuation line under-inde=
nted for hanging indent

./pgadmin/tools/back=
up/tests/test_batch_process.py:51: [E122] continuation line missing in=
dentation or outdented

./pgadmin/tools/back=
up/tests/test_batch_process.py:135: [E501] line too long (80 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:137: [E501] line too long (83 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:138: [E122] continuation line missing i=
ndentation or outdented

./pgadmin/tools/back=
up/tests/test_batch_process.py:139: [E122] continuation line missing i=
ndentation or outdented

./pgadmin/tools/back=
up/tests/test_batch_process.py:140: [E122] continuation line missing i=
ndentation or outdented

./pgadmin/tools/back=
up/tests/test_batch_process.py:191: [E501] line too long (81 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:203: [E501] line too long (80 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:204: [E128] continuation line under-ind=
ented for visual indent

./pgadmin/tools/back=
up/tests/test_batch_process.py:204: [E501] line too long (94 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:205: [E128] continuation line under-ind=
ented for visual indent

./pgadmin/tools/back=
up/tests/test_batch_process.py:205: [E501] line too long (94 > 79 c=
haracters)

./pgadmin/tools/back=
up/tests/test_batch_process.py:216: [W391] blank line at end of file

./pgadmin/tools/back=
up/tests/test_create_backup_job.py:296: [E501] line too long (97 > =
79 characters)

./pgadmin/tools/back=
up/tests/test_create_backup_job.py:317: [E303] too many blank lines (2=
)

./pgadmin/tools/back=
up/tests/test_create_backup_job.py:336: [E501] line too long (84 > =
79 characters)

./pgadmin/tools/back=
up/tests/test_create_backup_job.py:371: [W391] blank line at end of fi=
le

2       E121 continu=
ation line under-indented for hanging indent

5       E122 continu=
ation line missing indentation or outdented

2       E128 continu=
ation line under-indented for visual indent

2       E251 unexpec=
ted spaces around keyword / parameter equals

1       E303 too man=
y blank lines (2)

24      E501 line to=
o long (91 > 79 characters)

2       W391 blank l=
ine at end of file

38

For the feature tests, we realized we had t= o update the configuration, and we did that, but we get the following error= attached. We spent some time trying to understand the problem but we were = not successful.


Codewise:
- We just found some One Letter Variables in the code...
- Looks= like there is a bug report in this area of the code and we do not have cov= erage for it:=C2=A0https://redmine.postgresql.org/issues/3232
<= div>=C2=A0 Looks like in some of the unit tests we only have happy path tes= ts, maybe we should see if there are any sad paths that also need coverage.=

The configuration change, maybe need to be update= d. When we install multiple versions of postgres the binaries live in `/usr= /lib/postgresql/{{db_version}}/bin`, which makes us think that this co= nfiguration should live near the server configuration, maybe? Also to maint= ain coherency on the naming maybe we should make it all lower case.
Just as an aside, you can add the gpdb configuration as well in you patc= h.

Thanks
Victoria & Joao
=

On Wed, Apr 25, 2018 at 5:20 AM Khushboo Vashi <khushboo.vashi@enterprisedb.c= om> wrote:
Hi,

Please find the attached patch which covers tes= t cases for the backup module (RM #3206).

1. Unit = test cases
2. End to end regression test cases=C2=A0
3.= Feature test cases

Thanks,
Khushboo




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpris= eDB UK: http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company






--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsn= ake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi= tter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company

--000000000000154d66056de0f744--