Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqt8O-0008R5-Jq for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Feb 2019 05:19:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gqt8L-0002z1-ST for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Feb 2019 05:18:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqt8L-0002yu-Ef for pgadmin-hackers@lists.postgresql.org; Tue, 05 Feb 2019 05:18:57 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqt8H-0002RZ-Sg for pgadmin-hackers@postgresql.org; Tue, 05 Feb 2019 05:18:55 +0000 Received: by mail-ot1-x344.google.com with SMTP id u16so3782103otk.8 for ; Mon, 04 Feb 2019 21:18:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JrCqMNfmcoMXEpr8swjm2zeJwSetdoLF/iKk20Vifjg=; b=WlOUiayaMT5HGP3cs+xd4S7lIspDOX8Mq6ShtSDEt2tOykvbUYaDGd7eCeMkEhsQ2n FPW8oMB9PIHtZoVtPIspNYVfbKzGHtvvLoN8BsUzh83H+dz1ewML5Mjqi2+gjSFqEIJo YnmQqWwflJ3pB6hi+JiEsW49wyoVZpPgt3JJYHt9RW2jQFeFVq5yh3AlHqZ0UjiOnDrX 8BjscyPpW5j4fCr9d2C+8n0dkE87Jh8B6YdCTzxW4tGRC+og8J2wSRSgzGDzAemBmOdV BfoS9QnuPVv53/DKAyovc3Co97p+p8AwlL9utS1dqAC99o6y1F50XyZ87dFsCoI/nRtd ak2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JrCqMNfmcoMXEpr8swjm2zeJwSetdoLF/iKk20Vifjg=; b=lY2nU5LGn9Hpr4CAc6mlvRJkX+OKd63atmd1gH2RQygWRbXusrpGlsJ2FZn1frI9EO p2W8vAWdYMZfiO3539c2nr2uoa/okEZQmjuvrUYnzqMrSimoOn0ty2BTmbzXG2Ko0f9R kPOMxzloSIyEeiTl2I1nNLqYRnE6F01BUwlim6zpTbqiuv0k6czL18ojgHsimjUuBoMY 3KNuUbbHvd/EjFlTCsXenP0WQlNlVRxjzNSIsZyKKn0fKnzmr5N8b11X6xjbNLq4bQN2 MC88ILHBnerWSQxId6+qD4gvgsdQGOpwZPVPZJH5m0rUBg71u/nGrxii3+P1S0QWWOnX YwHA== X-Gm-Message-State: AHQUAua+jp0x/LwHgsFmMa9xGJ88fOKzLf+lWd6QpbIn0kpEpyFoSvV1 l6pxJSv0zsn5rnjvdRuGNf0YsGpL6/vmWmI3k0+dRw== X-Google-Smtp-Source: AHgI3IZufbP7+a4J1lpal2DW86/5j25j2mqtC48IxgjQZZ90DSPEJq0T88p6VSB4XtbLS0fLkzkTN18w1lKgVmHomAc= X-Received: by 2002:a54:450f:: with SMTP id l15mr1600509oil.351.1549343932847; Mon, 04 Feb 2019 21:18:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 5 Feb 2019 10:48:41 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases To: Akshay Joshi Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c0b1ff05811ebe00" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c0b1ff05811ebe00 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi wrote: > Hi Aditya > > On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I tried to simulate, but no luck. It works on my system :( >> > > I have tried and Feature test are failing randomly for each run. I have > verified it on OSX and Ubuntu both. > >> >> +1 > On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> I have applied your patch but following test cases are failing >>> consistently: >>> >>> - CopySelectedQueryResultsFeatureTest >>> - QueryToolAutoCompleteFeatureTest >>> >>> I have verified your patch on Mac OSX and Ubuntu. Chrome Version >>> 71.0.3578.98 >>> >>> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Tue, 29 Jan 2019, 19:09 Dave Page >>> >>>>> Akshay, can you look at this please? >>>>> >>>> >>>> Sure. >>>> >>>>> >>>>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal >>>>> wrote: >>>>> > >>>>> > Hi Hackers, >>>>> > >>>>> > Attached is the updated patch. I have changed >>>>> fill_input_by_field_name function to use javascript to set values of text >>>>> boxes and the selector is changed from xpath to CSS with a :not(:disabled) >>>>> clause. With this, test case will fail if tried to set the value of a >>>>> disabled input. >>>>> > >>>>> > Kindly review. >>>>> > >>>>> > >>>>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >> >>>>> >> >>>>> >> >>>>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page >>>>> wrote: >>>>> >>> >>>>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal >>>>> >>> wrote: >>>>> >>> > >>>>> >>> > Hi Dave, >>>>> >>> > >>>>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page >>>>> wrote: >>>>> >>> >> >>>>> >>> >> Hi >>>>> >>> >> >>>>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >>>>> >>> >> wrote: >>>>> >>> >> > >>>>> >>> >> > Hi Hackers, >>>>> >>> >> > >>>>> >>> >> > Attached is the patch to fix failing SQL editor related >>>>> feature tests. >>>>> >>> >> > The failure is occurring mostly because of send_keys function >>>>> of selenium which sometimes does not input the complete text. The change >>>>> will use Codemirror javascript object to set the text. >>>>> >>> >> > >>>>> >>> >> > I have also added new args flag "--modules" which can be used >>>>> after --pkg where you can test a specific module file under the pkg. This >>>>> is not so useful for build but definitely helpful for the developers. >>>>> >>> >> >>>>> >>> >> One of the most common failures I see is failure to fill in the >>>>> >>> >> details on the Add Server dialogue (it might type half of an >>>>> entry, >>>>> >>> >> then just hang). Should we get rid of all uses of send_keys? >>>>> >>> > >>>>> >>> > Setting the text using javascript executor can be done. >>>>> send_keys simulate an actual person, so if you try to set a disabled text >>>>> box using send_keys, it won't. Places where disabled fields doesn't matter, >>>>> send_keys can be removed. >>>>> >>> >>>>> >>> Can't we just do something like: >>>>> >>> >>>>> >>> if input.disabled == false: >>>>> >>> input.value = 'Foo'; >>>>> >>> else: >>>>> >>> raise exception .... >>>>> >> >>>>> >> I'll check if this can be done. Will get back. >>>>> >>> >>>>> >>> >>>>> >>> -- >>>>> >>> Dave Page >>>>> >>> Blog: http://pgsnake.blogspot.com >>>>> >>> Twitter: @pgsnake >>>>> >>> >>>>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> >>> The Enterprise PostgreSQL Company >>>>> >> >>>>> >> >>>>> >> >>>>> >> -- >>>>> >> Thanks and Regards, >>>>> >> Aditya Toshniwal >>>>> >> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>> >> "Don't Complain about Heat, Plant a tree" >>>>> > >>>>> > >>>>> > >>>>> > -- >>>>> > Thanks and Regards, >>>>> > Aditya Toshniwal >>>>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>>> > "Don't Complain about Heat, Plant a tree" >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --000000000000c0b1ff05811ebe00 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Feb 5, 2019 at 10:40 AM Aksha= y Joshi <akshay.joshi@e= nterprisedb.com> wrote:
Hi=C2=A0Aditya

On Mon, Feb = 4, 2019 at 2:18 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com&g= t; wrote:
Hi Akshay,

I tried to simulate, but no luck. It works on my s= ystem :(

=C2=A0 =C2=A0I have tr= ied and Feature test are failing randomly for each run. I have verified it = on OSX and Ubuntu both.=C2=A0=C2=A0

+1=C2=A0
On Wed, Jan 30= , 2019 at 7:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi=C2=A0Aditya

I have ap= plied your patch but following test cases are failing consistently:
  • CopySelectedQueryResultsFeatureTest
  • QueryToolAutoComplet= eFeatureTest
I have verified your patch on Mac OSX and Ubuntu.= Chrome=C2=A0Version 71.0.3578.98
=

= On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <akshay.joshi@enterprisedb.com&= gt; wrote:


On Tu= e, 29 Jan 2019, 19:09 Dave Page <dpage@pgadmin.org wrote:
Akshay, can you look at this please?

=C2=A0 =C2= =A0 Sure.

On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the updated patch. I have changed fill_input_by_field_name= function to use javascript to set values of text boxes and the selector is= changed from xpath to CSS with a :not(:disabled) clause. With this, test c= ase will fail if tried to set the value of a disabled input.
>
> Kindly review.
>
>
> On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
>>
>>
>>
>> On Mon, Jan 28, 2019 at 5:39 PM Dave Page <dpage@pgadmin.org= > wrote:
>>>
>>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
>>> <aditya.toshniwal@enterprisedb.com>= wrote:
>>> >
>>> > Hi Dave,
>>> >
>>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page <dpage@pgadmi= n.org> wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
>>> >> <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
>>> >> >
>>> >> > Hi Hackers,
>>> >> >
>>> >> > Attached is the patch to fix failing SQL editor = related feature tests.
>>> >> > The failure is occurring mostly because of send_= keys function of selenium which sometimes does not input the complete text.= The change will use Codemirror javascript object to set the text.
>>> >> >
>>> >> > I have also added new args flag "--modules&= quot; which can be used after --pkg where you can test a specific module fi= le under the pkg. This is not so useful for build but definitely helpful fo= r the developers.
>>> >>
>>> >> One of the most common failures I see is failure to f= ill in the
>>> >> details on the Add Server dialogue (it might type hal= f of an entry,
>>> >> then just hang). Should we get rid of all uses of sen= d_keys?
>>> >
>>> > Setting the text using javascript executor can be done. s= end_keys simulate an actual person,=C2=A0 so if you try to set a disabled t= ext box using send_keys, it won't. Places where disabled fields doesn&#= 39;t matter, send_keys can be removed.
>>>
>>> Can't we just do something like:
>>>
>>> if input.disabled =3D=3D false:
>>>=C2=A0 =C2=A0input.value =3D 'Foo';
>>> else:
>>>=C2=A0 =C2=A0raise exception ....
>>
>> I'll check if this can be done. Will get back.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
<= div>Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0= EnterpriseDB Software Solutions |=C2=A0= Pune
"Don't Compla= in about Heat, Plant a tree"


--
Sr. Software Architect


Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246
--000000000000c0b1ff05811ebe00--