Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg3Cv-0006oA-T1 for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 May 2021 10:32:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lg3Cs-0001Ly-CL for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 May 2021 10:32:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg3Cs-0001Lq-3t for pgadmin-hackers@lists.postgresql.org; Mon, 10 May 2021 10:32:10 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lg3Ck-0007xz-7G for pgadmin-hackers@postgresql.org; Mon, 10 May 2021 10:32:09 +0000 Received: by mail-lf1-x133.google.com with SMTP id z13so22633814lft.1 for ; Mon, 10 May 2021 03:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gAPK40lz5WhooqXxBrePSGEA1/9vzOiwAnzNsiCegAo=; b=JInuLoLFypWsMnpsozEganufDQ0OI8Ro4JUm3KIqPe6NvTfbpAJINzqZAein/eRXuB vmwezJTfpOXiHxvPTD7VBk+YULOJxEILn9UNTROCo/HPOjqtVHLsDWMoWugeysSloOVD sdLfeUeN++xXQ6si9qYeYo5zDPbawUA7SJ2t1U/HzFON5jiG8zjGc26hXBufC7XYldOV 2qMdBGypwIHhiNU0tou7WYnkamVbGfh5i6yZ7RdBstp1XOtFyIoAbjJLNEXZCjMK39Sb 620hS/Q0e7Km2uQo7vAK6hmF9MGBa4VBPzwJ3rKugnTNgKxmBLGR0XiKTCKFFS6P1tno wTkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gAPK40lz5WhooqXxBrePSGEA1/9vzOiwAnzNsiCegAo=; b=lqurDycQUF1D/5rAObzeYvKg1kgBhpyKucImXYzCSAY2sVUNaSBwm2P1nEm4AxD1ei AYjEVUF/m/JbPp78DJCjVGNXj1Isppj/iGIB3Bc97riRfWSepkeQuDP2utE/4i8tjZ8l TFeVPEWFNf8pMYyxmguteiWCHMk65DOKU61Xm0jyDN0QkLddSj2KrXO91Tj3PUS+Xxd3 7QD0TcPbohj6ccDhyQ+TQf+cV74UCdxWVVwQUJnGwfeJPQv/JYoF9H2vD7ycHje1AyRj n00z4LRTqxXwaoeRdJ3sD4McGq5T1M5tQMZhJyfkUdf1y1voBt8ZWcAPQRtYafxYYmbt Jq5A== X-Gm-Message-State: AOAM5323m3L2K0HeXAHf/GPfSszOzkKtnprB7DIvTcfaIgIG0ZEoVIiR s7mmEeDmfnJFkHnshDQ6gB+3CDQ+SHJs3U01x2cxsXTIDbvaBO75QkNyP0VAJ3x/vJ/3Pv7JSHA szqc9njRd21GiYrQdYOd80+eljMeQrQjrFg1Lcvzv+PVgPQZmi5S/wWLTY3EMobTgNc/AE4J0SM 5hzD0kxNR4b16MjGkk07jHhDWFpAt+xaPaZri9t4tE3SKkF8/vvFKU+EF3WA== X-Google-Smtp-Source: ABdhPJykiQI8Ri/tka4Z2piQUhWWKHpUc5ErUWV3zbWSksGR8a2mBUqF8QuXNXpU0/kVVnWROv/++VpOMV1S4NVXFLo= X-Received: by 2002:a05:6512:3b93:: with SMTP id g19mr16542632lfv.548.1620642720236; Mon, 10 May 2021 03:32:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Mon, 10 May 2021 16:02:05 +0530 Message-ID: Subject: Re: oauth2 patch To: Akshay Joshi Cc: Florian Sabonchi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a5ec9a05c1f74926" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000a5ec9a05c1f74926 Content-Type: text/plain; charset="UTF-8" On Mon, May 10, 2021 at 10:59 AM Akshay Joshi wrote: > Hi Khushboo > > Can you please review the patch? > On it. > > On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi > wrote: > >> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't >> sure how the test should look like, because I couldn't find anything in >> the developer documentation, so I decided not to write one for now. >> >> The configuration has to look like this here is an example for github: >> >> OAUTH2_NAME = 'github' >> OAUTH2_CLIENT_ID = 'secret' >> OAUTH2_CLIENT_SECRET = 'secret' >> OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token' >> OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize' >> OAUTH2_API_BASE_URL = 'https://api.github.com/' >> OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user' >> OAUTH_ENDPOINT_NAME = 'user' >> >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --000000000000a5ec9a05c1f74926 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, May 10, 2021 at 10:59 AM Aksh= ay Joshi <akshay.joshi@= enterprisedb.com> wrote:
Hi Khushboo

Can you ple= ase review the patch?
On it.=C2=A0

=
On Sun, May 9, 2021 at 12:53 AM Flori= an Sabonchi <sab= onchi@posteo.de> wrote:
Hello in this patch I have implemented OAuth2. Unfortunately= I wasn't
sure how the test should look like, because I couldn't find anything in=
the developer documentation, so I decided not to write one for now.

The configuration has to look like this here is an example for github:

OAUTH2_NAME =3D 'github'
OAUTH2_CLIENT_ID =3D 'secret'
OAUTH2_CLIENT_SECRET =3D 'secret'
OAUTH2_TOKEN_URL =3D 'https://github.com/login/oauth/= access_token'
OAUTH2_AUTHORIZATION_URL =3D 'https://github.com/login/o= auth/authorize'
OAUTH2_API_BASE_URL =3D 'https://api.github.com/'
OAUTH2_USERINFO_ENDPOINT =3D 'https://api.github.com/user' OAUTH_ENDPOINT_NAME =3D 'user'




--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--000000000000a5ec9a05c1f74926--