Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyfp7-0001b4-Ej for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 15:38:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyfp6-0002sc-GN for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 15:38:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyfp6-0002sS-3L for pgadmin-hackers@lists.postgresql.org; Wed, 21 Mar 2018 15:38:44 +0000 Received: from mail-ot0-x22b.google.com ([2607:f8b0:4003:c0f::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyfoy-0008Gu-Vt for pgadmin-hackers@postgresql.org; Wed, 21 Mar 2018 15:38:42 +0000 Received: by mail-ot0-x22b.google.com with SMTP id m22-v6so6040576otf.10 for ; Wed, 21 Mar 2018 08:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=097uKAxKWSGjxcClKPgJtFAJZYDBDZWljwkZDhx22dk=; b=hYiEHcD0FUwvYAOwz932VnhUJFL7BAS4vJbF9RA1SiL7AtSXliloDmPh3sgfCXaMQ7 dJMTj877I38bPgF/z04Uc44TyjkS48Ktrn/Hqnv78yVo8AkME5dUK2p5b3mUdHjDQol+ ymChRg49cHVrf/2MWM8MSwAXrkYR7Niz9lEeK8HZBbQ9wqYZemZoRExMQe4+V0ue0q4l qD3nrA7YCZCw5SHH6jZokTuL6WcFFI8yXVY8bRo22lgSZ5ty720HJKVf31PEcRhxbmQU xdu1TzXZLw5qYxTfPc3PKYVkEbZ2z2nrab/cSvuBjdR9Cxh8jq1NpFOKYo6UdrNlgXh6 jGKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=097uKAxKWSGjxcClKPgJtFAJZYDBDZWljwkZDhx22dk=; b=RQHH7hXIdieQRm53eeiQIli3430hfFusVLmq7UaU8Pgj1wI9Hs2aUiyib8gjT87ZZT 9pbxDFnlC9UHyKfCE8p4oFKPNVIfFCjk48r6ON+Q+zl2d0ZhXOHbp1r2yJYjzKRSdntM AxLVW+of7TPYsG2qf+fzF7ryKpYjHHg2MEa81dO+mEFL64tCPlbd/7ziNMnclXyxZPvG KfyiYnBzz610gRYPP1mCWwflGc5Ep2MU/dDgAJFjJsyyVoTglT4Xy4tAaQZWlGK/+yHH pP6o7KgWCS5CLxBh06r9LUfzC9BxNe49AaXijdmehOZtf3hR7vKecK33oS+/N6jQRUJt 8lKw== X-Gm-Message-State: AElRT7EelJZPyjnJ1BEzyHJbN8yLQxQBWREzH5VB3sLx73Olb7YbuhZx mviX5arpmERfqZKCyuKjZwIhrykVzEsp0gPS6StbKQ== X-Google-Smtp-Source: AG47ELv7OBbVqYoMaJd2Znk3mx7d/dHFhswY3nXPnqnCeG5faSvKCQ+IkaK5fqYytjQ6lk5Zl4+HMJRoNbLHHMeVLgI= X-Received: by 2002:a9d:27aa:: with SMTP id c39-v6mr6629373otb.104.1521646715280; Wed, 21 Mar 2018 08:38:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.138.251 with HTTP; Wed, 21 Mar 2018 08:38:34 -0700 (PDT) Received: by 10.74.138.251 with HTTP; Wed, 21 Mar 2018 08:38:34 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Wed, 21 Mar 2018 21:08:34 +0530 Message-ID: Subject: Re: v3.0 release on hold To: Dave Page Cc: pgadmin-hackers , Akshay Joshi , Murtuza Zabuawala , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="000000000000f03c660567edfbdc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f03c660567edfbdc Content-Type: text/plain; charset="UTF-8" On 21 Mar 2018 21:05, "Dave Page" wrote: We've run into a number of unexpected issues with the v3.0 release that I think we need to resolve before moving forwards. For the time being, only patches critical to fix these issues should be committed. I'll try to look at 1, though I do have another deadline I need to meet. Akshay, can you look at 2 please? Fahar is already looking at 3. Khushboo, can you look at 4 please? Sure. Thanks all. 1) There is no longer a system tray in Gnome 3.26 and later, and thus the runtime won't initialise in Fedora 27 and later. We need an alternative for this, either a tray replacement that the RPM can depend on, or better yet, support whatever it is Gnome expect such apps to use these days. 2) Starting a second instance of the app bundle on Mac doesn't always open a new pgAdmin window as it should. It works fine in the debugger, or if you start the app with a command like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, but apparently his is a fresh installation. 4) On my Windows 7 machine, after running a backup I get no status window, and see the following in the logs: Traceback (most recent call last): File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi execute(self.server.app) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in execute application_iter = app(environ, start_response) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__ return self.wsgi_app(environ, start_response) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app response = self.handle_exception(e) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app response = self.full_dispatch_request() File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1614, in full_dispatch_request rv = self.handle_user_exception(e) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in handle_user_exception reraise(exc_type, exc_value, tb) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in full_dispatch_request rv = self.dispatch_request() File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", line 792, in decorated_view return func(*args, **kwargs) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index return make_response(response=BatchProcess.list()) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list details = desc.details(p.command, args) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in details res += html.safe_str(cmd + self.cmd) AttributeError: 'BackupMessage' object has no attribute 'cmd' -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000f03c660567edfbdc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On 21 Mar 2018 21:05, "Dave Page" <dpage@pgadmin.org> wrote:
We've run into a number of = unexpected issues with the v3.0 release that I think we need to resolve bef= ore moving forwards. For the time being, only patches critical to fix these= issues should be committed.

I'll try to look at 1, = though I do have another deadline I need to meet.=C2=A0
Akshay, c= an you look at 2 please?
Fahar is already looking at 3.
Khushboo, can you look at 4 please?
Sure.

Thanks all.

1) There = is no longer a system tray in Gnome 3.26 and later, and thus the runtime wo= n't initialise in Fedora 27 and later. We need an alternative for this,= either a tray replacement that the RPM can depend on, or better yet, suppo= rt whatever it is Gnome expect such apps to use these days.

<= /div>
2) Starting a second instance of the app bundle on Mac doesn'= t always open a new pgAdmin window as it should. It works fine in the debug= ger, or if you start the app with a command like: "/Applications/pgAdm= in\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you do= uble-click the appbundle or use a command like "open /Applications/pgA= dmin\ 4.app"

3) Fahar saw a crash on Windows = 7. I couldn't reproduce this on my copy, but apparently his is a fresh = installation.

4) On my Windows 7 machine, after ru= nning a backup I get no status window, and see the following in the logs:

Traceback (most recent call last):
<= div>=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-pac= kages\werkzeug\serving.py", line 209, in run_wsgi
=C2= =A0 =C2=A0 execute(self.server.app)
=C2=A0 File "C:\Program = Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py&qu= ot;, line 197, in execute
=C2=A0 =C2=A0 application_iter =3D app(= environ, start_response)
=C2=A0 File "C:\Program Files (x86)= \pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in= __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_respo= nse)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\L= ib\site-packages\flask\app.py", line 1985, in wsgi_app
= =C2=A0 =C2=A0 response =3D self.handle_exception(e)
=C2=A0 File &= quot;C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\= app.py", line 1540, in handle_exception
=C2=A0 =C2=A0 rerais= e(exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files (x8= 6)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, = in wsgi_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request= ()
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib= \site-packages\flask\app.py", line 1614, in full_dispatch_request=
=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\<= wbr>flask\app.py", line 1517, in handle_user_exception
=C2= =A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "C:\= Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py&q= uot;, line 1612, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D se= lf.dispatch_request()
=C2=A0 File "C:\Program Files (x86)\pg= Admin 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in di= spatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req.view_args)
=C2=A0 File "C:\Program Files (x= 86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", line 792= , in decorated_view
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\m= isc\bgprocess\__init__.py", line 62, in index
=C2=A0 = =C2=A0 return make_response(response=3DBatchProcess.list())
= =C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list
=C2=A0 =C2=A0 de= tails =3D desc.details(p.command, args)
=C2=A0 File "C:\Prog= ram Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py"= ;, line 190, in details
=C2=A0 =C2=A0 res +=3D html.safe_str(cmd = + self.cmd)
AttributeError: 'BackupMessage' object has no= attribute 'cmd'

<= br>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000f03c660567edfbdc--