Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1X4M-00043g-NM for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Mar 2018 12:54:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1X4L-0007rV-IH for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Mar 2018 12:54:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1X4L-0007rL-9p for pgadmin-hackers@lists.postgresql.org; Thu, 29 Mar 2018 12:54:17 +0000 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1X4H-0004jw-N3 for pgadmin-hackers@postgresql.org; Thu, 29 Mar 2018 12:54:15 +0000 Received: by mail-ot0-x242.google.com with SMTP id v64-v6so6285089otb.13 for ; Thu, 29 Mar 2018 05:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z9WEqewdorznAzfe0Ew/2ubTKGG2YuaELdvl1RrhAjg=; b=kRBFwOee/bVoSEakW6Pzk7Xn6r8Zjsph2ppsuniYCTrxGZW+5ee4waarlEmDqlC3Aa VHGBHXLTlznWIfqRVjs/H5QdhcZ3/WIhZh5W2j1Ajz44ckk4fdxiyJid5dEFdoVCD4cz 9CYHlnYfKkRdBk/eGHLiV+RqiUldyjocLzLmAySkyq+RTYS5rbVSaFA8AH8hLjAk5QJt OUB0pH0co68Hc+uJGk38gZH9DEJzMCoW1YOvgJZby3wDIM2qw/2T0wPhoDpV7cZ1U3DV Ar8ZbCheYQYqPgFbfLQjNv1N90ktPftmFlwZ6YBlL2H0svPwUQeFcZ8/JSDL1bsFpXUM 9Haw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z9WEqewdorznAzfe0Ew/2ubTKGG2YuaELdvl1RrhAjg=; b=imEgxPm+diyBSNWr1RMkGf6/U6MJrs8muAqeNrDzEKFsxHLQzAaBZGvO3aiFuP4ksS ZSrEJzDAawzfVRU4S4uZp4m/xMQS3hiiFzBZkYmaP8AP7oCbfxH7i9V3d98st33PpWQz 9Cj17H8u1KDU31Pef6oirhULkXttcTw6EAm6dM4kZW7lx1VIDDFuRsuTDTYExd71lgZS c6rO3KucmL8KUC2iNqKAd9DQoZ/VL4UbGqlUn6Z1QMQhVG/8G34NwIHUutKdZwtVRsxM 7nzocerUY352WxQ6nueF907aVd8RKJ6lXKdKJGXa3CAmpgjYGnC6BcuWgu85CZ+a8mVy FYAA== X-Gm-Message-State: AElRT7FdSOwqxmyGqv6nhBJ6PUHnljP7/YqgWFqIln27mumj2T1R3xXj fkXOVXtY1gWXTM6Qifj67rEgvA7j2/lukjL3UbgAWw== X-Google-Smtp-Source: AIpwx49t5duM9MxMu611H6wep7UVYRoW6L1y0v9ku57jU5R/9E/O347+k/dvP5mwAgIRaKDR6hZo0vdJS0Q606FiEOE= X-Received: by 2002:a9d:25cf:: with SMTP id q73-v6mr4521162ota.296.1522328052072; Thu, 29 Mar 2018 05:54:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.138.251 with HTTP; Thu, 29 Mar 2018 05:54:11 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Thu, 29 Mar 2018 18:24:11 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations To: Joao De Almeida Pereira Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c6975c05688c9e4d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c6975c05688c9e4d Content-Type: text/plain; charset="UTF-8" Hi Joao, On Tue, Mar 27, 2018 at 12:12 AM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Khushboo, > > Looks like you have a typo on your CSS where it reads 'zoomeIn' it should > be 'zoomIn'. > Thanks, I have sent the updated patch. > Also setting more parameters into the window, in our experience, is never > good, so maybe it is time to create a real settings cache that can retrieve > from the backend the settings, like this one. > > We already have a cache for preferences, so I have used that in the updated patch. > Thanks > Victoria & Joao > > Thanks, Khushboo > On Mon, Mar 26, 2018 at 8:38 AM Dave Page wrote: > >> Hi >> >> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix RM #1978: Add an option to allow >>> user to disable alertifyjs and acitree animations. >>> >> >> I think these really need to be per-user settings, not per-installation.. >> Whether or not animations are shown is really a matter of personal taste >> and circumstance. >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > --000000000000c6975c05688c9e4d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Joao,

On Tue, Mar 27, 2018 at 12:12 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,

Looks li= ke you have a typo on your CSS where it reads 'zoomeIn' it should b= e 'zoomIn'.
Thanks, I have sent the up= dated patch.=C2=A0
Also setting more parameters into the window, in our experience, is never= good, so maybe it is time to create a real settings cache that can retriev= e from the backend the settings, like this one.

<= /blockquote>
We already have a cache for preferences, so I have used th= at in the updated patch.=C2=A0
Thanks
Victoria & Joao

Tha= nks,
Khushboo=C2=A0
On Mon, Mar 26, 2018 at 8:38 AM Dave Page <dpage@pgadmin.org> wrote:
Hi
=
On Mon, Mar 26, 2018 at 7:23 A= M, Khushboo Vashi <khushboo.vashi@enterprisedb.com&= gt; wrote:
Hi,
Please find the attached patch to fix RM #1978: Add an opt= ion to allow user to disable alertifyjs and acitree animations.
=

I think these really need = to be per-user settings, not per-installation.. Whether or not animations a= re shown is really a matter of personal taste and circumstance.
<= br>
Thanks.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000c6975c05688c9e4d--