Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew0ya-0005YV-3L for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 07:37:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ew0yY-00077r-J2 for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 07:37:30 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew0yY-00077Z-3s for pgadmin-hackers@lists.postgresql.org; Wed, 14 Mar 2018 07:37:30 +0000 Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ew0yO-00080w-Bg for pgadmin-hackers@postgresql.org; Wed, 14 Mar 2018 07:37:26 +0000 Received: by mail-oi0-x232.google.com with SMTP id x12so1898822oie.13 for ; Wed, 14 Mar 2018 00:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yFPKVeOk9+jY1LNAlBDdvbjcumtPB8JGgmmPaMkaRQo=; b=CgKouwxuJCQS4dvlcigvHxsKLGIhWGTV474zFcwneM72EmIM+ZgstGXrIDZpbQGFbU rEEzDHDqna+GQCjKPvVJjdQUXXAzKUPW4dIXDGKO18e8G4XEQPhxPl1JDU6ROwfXigST JsrfqI8qgdzT10j4mzLlqoLT15brHvOWnhhMj9A94vOJCsgQY0evxYpc22Xjd8lXTWIY r63gQtkVZvBI/5CSU+t062uG0INarUbdYoexlrFfEvap+3AltWX8kdG3xJ2rIoDJ6l+o ovtzaQvlLssTHSrC3EUYytZPYSgyF5LleoyCWsiTfaZ4dtsrwljKpVundA47Qc6AYZ97 +i9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yFPKVeOk9+jY1LNAlBDdvbjcumtPB8JGgmmPaMkaRQo=; b=bXdBkIKcLfxpV2PJwy2jhXzudIh7dooYoTjTWta0qACPsiOuAhertUOq2mCN5zchuI m/6dAMWt7gUqIuAz5uMfhUbsqjrKJeUF8bOvNm4P7+BKG7NXhiJ+lsmrjYHGgmu0+LOJ QH4+bZi9mCSoGj98OIyWt8QcGMe5vW2pwwZ9X5FTD+byVhMHIqYKV+3PCszS8SmCVTj3 wfheEOi2ZkOImtEqIxS/e5kaGXg7XnLX1NAZTpxeUpsWKoRAQt99J+j2SjusLyVb6EMx 0pF9nc+FAye/9Xrcr7k1vnO/RbWBv8ryCFyhC3banHAnzD/9mMdxKV3KlF0J6hbOV7z+ 0vAw== X-Gm-Message-State: AElRT7Hdpd7zJO31iE3Z9zglGoH78Julg2s3NVQxUYLRa6KaY5wUuMS5 befZc5qe9y52DJdHD4m8MWRnD7R0lHTnIM/8jEWlGg== X-Google-Smtp-Source: AG47ELvU3sURkGtdJB84XeBeByokHno1tc5j4K4F+A2zPyE0yhQY+YnVAWy7ZwcnH2hjSV2Sh9XuTEcCqBjMlDXsFbA= X-Received: by 10.202.82.72 with SMTP id g69mr2241427oib.83.1521013038271; Wed, 14 Mar 2018 00:37:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Wed, 14 Mar 2018 00:37:17 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Wed, 14 Mar 2018 13:07:17 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113d8598d86b1805675a7190" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d8598d86b1805675a7190 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without > your patch applied. > > Yes, good point. Will update and send the patch. > > On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Khushboo, >> >> We can simplify this, we don't need to create any extra column, >> >> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 >> where we are setting ENV variable we can create common utility function >> (let say in ../tools/utils/__init__.py) which will set all required the >> environment variables and then we will pass that function in p.start(..) >> method. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix RM #3122 : Backup not working on >>> certificate (SSL) protected servers. >>> >>> The attached patch fixes the issue in the following modules: >>> >>> 1. Backup >>> 2. Restore >>> 3. Import/Export >>> 4. Maintenance >>> >>> Thanks, >>> Khushboo >>> >>> >>> >> > --001a113d8598d86b1805675a7190 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
=C2=A0.= ./pgadmin4/web/pgadmin/tools/import_export/__init__.py +310=C2=A0without your patch applied.

Yes, good point. Will update and send the patch.=C2=A0=

On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com><= /span> wrote:
Hi Khushboo,
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">
=
We can si= mplify this, we don't need to create any extra column,

Check: ../pgadmin4/web/pgadmin/tools/i= mport_export/__init__.py +322 where we are setting ENV variable we c= an create common utility function (let say in ../tools/utils/__init__.py) w= hich will set all required the environment variables and then we will pass = that function in p.start(..) method.


<= div>
--
Regards,
Murtuza Zabuawala
EnterpriseD= B:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreS= QL Company


On Wed, Mar 14, 2018 at 11:03 AM, Khushboo V= ashi <khushboo.vashi@enterprisedb.com> wr= ote:
Hi,

<= div>Please find the attached patch to fix RM #3122 :=C2=A0Backup not workin= g on certificate (SSL) protected servers.

The atta= ched patch fixes the issue in the following modules:

1. Backup
2. Restore
3. Import/Export
4. M= aintenance

Thanks,
Khushboo




--001a113d8598d86b1805675a7190--