Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smT2S-005yM7-BA for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Sep 2024 07:05:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1smT2P-008oP4-68 for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Sep 2024 07:05:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smT2O-008oNP-PS for pgadmin-hackers@lists.postgresql.org; Fri, 06 Sep 2024 07:05:45 +0000 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1smT2L-000Oxb-7W for pgadmin-hackers@postgresql.org; Fri, 06 Sep 2024 07:05:42 +0000 Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-e1d0e74f484so2093134276.2 for ; Fri, 06 Sep 2024 00:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1725606340; x=1726211140; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hc3gnPZaRKKIggjCIr5fREqsYCUr39tfuma3zj3q4IU=; b=JdBfzZOOcYQ2HEg+gPtJpHvfC8vhmD7o++/Uo0+jtQrV2R90+brkZBCSLVx5hI3oIE 5IH2J+5ZNVE0eSigzW3FBBT3KVtOhZBrRecxe7rjdcJIcgA1nz/Y7mhAAXXuvC7VG7nO Y8k2TFg0WXEsvbwcyclouDaJ5Btog8dU1ZFCIc4o7DOaZFFGyLoxkxGgNV0xBmQ+1gMn viHvDhtAG4QtZyN0iq+7ih3fmrpBeQJZduL5uU3wvb7BHhy/LIW94NMqmh4P5EZUIHgC bARO4h1ucBzbHCYQUI0H+3dVAW7/8I1l3aykYy3SKBC+LLrwumF3lV8f17bU0AOGfiBg XjvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725606340; x=1726211140; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hc3gnPZaRKKIggjCIr5fREqsYCUr39tfuma3zj3q4IU=; b=EtD4fdgjlDDAsWDZb98ikKlBzoceylmrvm5XU8yVY9Je4j7IlcC/7/tx6SnNstyTbr 4HeFsuLTS4jwzUh5bFj4/DL0IA2c56aN0GCAKSuf27qUiTiDEJFlrzPCKKuFrlEpuvO+ HhWCLVfIn+WatZTNyP/GIt6qQvgxq8axZkrYFEi9K5O0qj3vZElGp/ceD9AvV7II+/Mb bFa2o6jNXlOvgZr1mhemS0saGxnSj6TUDJh92hseE8u1FcDzD2YxS5tJPF+0bvbC+K1w BCbTPWtesSBdZ576vsRrpSDS3/OSA+RdACJHixqoyysdEmxVOqSEvnPjfOjEd72ryQnS 8fAg== X-Forwarded-Encrypted: i=1; AJvYcCWx7cdoIdoUSPxJbGQScKk/tzxJmilAmwzynUz4WPSC0PTTV+kbpaBGIXFbx7QnBPpCWPQzBb18b2dWM9qB6+o=@postgresql.org X-Gm-Message-State: AOJu0YzGD6/k7NkULdlkQOUnE8aT3Ob8K/4mOKLnlDSlQJxWexroIfHO OmlFGCdWqCd7U2HpRYU2GJq1ikzQJTwyCmzhD8qfALHlds/RxkPH7PN+K+GznDtjZBu625++pzj EXrc9xA+g817m5fONPB+qQNMVHc1JhSZQvtOu X-Google-Smtp-Source: AGHT+IGBVnFnKPnuDq+LA4jtNspwKWEV1cqAFpK8IEE/EevkqEEEjOjLBNwVBja3Nmn7lSH7RgU8B0SIh1GeAd3KjKc= X-Received: by 2002:a05:6902:e01:b0:e11:7474:f296 with SMTP id 3f1490d57ef6-e1d34885acamr1662664276.19.1725606339877; Fri, 06 Sep 2024 00:05:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Fri, 6 Sep 2024 12:35:28 +0530 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Dave Page Cc: Rohit Bhati , pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000e947a106216e0860" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e947a106216e0860 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page wrote: > Hi > > On Thu, 5 Sept 2024 at 14:38, Rohit Bhati > wrote: > >> Hi, >> >> I have made changes for issue #7863 >> based on theme >> requirements. >> >> I have attached screenshots showing how the updates look across all >> themes for your reference. >> >> If the current color does not fit well with the theme or if you have any >> suggestions for improvements, please let me know. >> > > Is the colour contrast high enough on the row numbers for selected rows i= n > the high contrast theme? The black on grey seems like it might not be to > me, but I haven't tested. > > I wonder also if we should make the row numbers bold all the time. > Thoughts? > We can check how it looks. Also the cell border doesn't look good to me. > > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > EDB: https://www.enterprisedb.com > > PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ > > --000000000000e947a106216e0860 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 5, 2024 at 7:11=E2=80=AFP= M Dave Page <dpage@pgadmin.org&= gt; wrote:
Hi

On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit.bhati@enterpr= isedb.com> wrote:
Hi,

I have made changes for issue #7863=C2=A0based on theme requirements.

I have attached screen= shots showing how the updates look across all themes for your reference.
If the current color does not fit well with the theme or if you have a= ny suggestions for improvements, please let me know.

Is the colour contrast high enough on the row num= bers for selected rows in the high contrast theme? The black on grey seems = like it might not be to me, but I haven't tested.
=C2=A0
I wonder also if we should make the row numbers bold all the time. Th= oughts?
We can check how it looks. Also = the cell border doesn't look good to me.


--
Dave Page
= PostgreSQL: https:= //www.postgresql.org

<= /div>
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/

<= /div>
--000000000000e947a106216e0860--