public inbox for [email protected]
help / color / mirror / Atom feedFrom: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Fixed tree keyboard navigation visibility issue
Date: Mon, 15 Nov 2021 18:19:59 +0530
Message-ID: <CAFOhELcdbejk+AG2HvX76PdTy=F7+jZBCETx_TScpigCWsvxLQ@mail.gmail.com> (raw)
Hi,
Please find the attached patch to fix the tree keyboard navigation
visibility issue.
Thanks,
Khushboo
Attachments:
[application/octet-stream] tree_keyboard_navigation_visibility_fix.patch (2.9K, 3-tree_keyboard_navigation_visibility_fix.patch)
download | inline diff:
diff --git a/web/package.json b/web/package.json
index f6f56cfd8..273b08eea 100644
--- a/web/package.json
+++ b/web/package.json
@@ -136,7 +136,7 @@
"path-fx": "^2.0.0",
"pathfinding": "^0.4.18",
"paths-js": "^0.4.9",
- "pgadmin4-tree": "git+https://github.com/EnterpriseDB/pgadmin4-treeview/#cfb580e396714dbdd941c64e0f90598ee478ea21",
+ "pgadmin4-tree": "git+https://github.com/EnterpriseDB/pgadmin4-treeview/#90e62d4371d3d25a957b3ffc7c6cb81a928da06f",
"postcss": "^8.2.15",
"raf": "^3.4.1",
"react": "^17.0.1",
diff --git a/web/pgadmin/static/js/tree/tree.js b/web/pgadmin/static/js/tree/tree.js
index 5f0700275..42c8b1298 100644
--- a/web/pgadmin/static/js/tree/tree.js
+++ b/web/pgadmin/static/js/tree/tree.js
@@ -140,12 +140,12 @@ export class Tree {
await this.tree.toggleDirectory(item);
}
- async select(item, ensureVisible=false) {
- await this.tree.setActiveFile(item, ensureVisible);
+ async select(item, ensureVisible=false, align='auto') {
+ await this.tree.setActiveFile(item, ensureVisible, align);
}
- async selectNode(item, ensureVisible=false) {
- this.tree.setActiveFile(item, ensureVisible);
+ async selectNode(item, ensureVisible=false, align='auto') {
+ this.tree.setActiveFile(item, ensureVisible, align);
}
async unload(item) {
diff --git a/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js b/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
index f8249a892..0b4380a8b 100644
--- a/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
+++ b/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
@@ -289,7 +289,7 @@ export default class SearchObjectsDialogWrapper extends DialogWrapper {
tree.findNodeWithToggle(rowData.id_path)
.then((treeItem)=>{
setTimeout(() => {
- tree.select(treeItem, true);
+ tree.select(treeItem, true, 'center');
}, 100);
this.showMessage(null);
})
diff --git a/web/yarn.lock b/web/yarn.lock
index 758b6d8b1..bc0ddbc0c 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -7189,9 +7189,9 @@ performance-now@^2.1.0:
resolved "https://registry.yarnpkg.com/performance-now/-/performance-now-2.1.0.tgz#6309f4e0e5fa913ec1c69307ae364b4b377c9e7b"
integrity sha1-Ywn04OX6kT7BxpMHrjZLSzd8nns=
-"pgadmin4-tree@git+https://github.com/EnterpriseDB/pgadmin4-treeview/#cfb580e396714dbdd941c64e0f90598ee478ea21":
+"pgadmin4-tree@git+https://github.com/EnterpriseDB/pgadmin4-treeview/#90e62d4371d3d25a957b3ffc7c6cb81a928da06f":
version "1.0.0"
- resolved "git+https://github.com/EnterpriseDB/pgadmin4-treeview/#cfb580e396714dbdd941c64e0f90598ee478ea21"
+ resolved "git+https://github.com/EnterpriseDB/pgadmin4-treeview/#90e62d4371d3d25a957b3ffc7c6cb81a928da06f"
dependencies:
"@types/classnames" "^2.2.6"
"@types/react" "^16.7.18"
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin4][Patch]: Fixed tree keyboard navigation visibility issue
In-Reply-To: <CAFOhELcdbejk+AG2HvX76PdTy=F7+jZBCETx_TScpigCWsvxLQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox