public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: SQL Tab Validation
Date: Tue, 3 May 2016 15:46:44 +0530
Message-ID: <CAFOhELcepLTgz7ueukoRiQ_gFk0xCOMVQopOMz4nwtbkQwScJw@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Do not send the request to the server if a model contains any error on
selection of the SQL Tab, while creating/updating any Node.

Please find the attached patch for the same.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_sqltab_validation.patch (814B, 3-pgAdmin4_sqltab_validation.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index ab2f2fb..dbdd6cc 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1394,8 +1394,9 @@
       // Fetch the information only if the SQL tab is visible at the moment.
       if (this.dialog && obj.shown == this.tabIndex) {
 
-        // We will send request to sever only if something is changed in model
-        if(this.model.sessChanged()) {
+        // We will send a request to the sever only if something has changed
+        // in a model and also it does not contain any error.
+        if(this.model.sessChanged() && _.size(this.model.errorModel.attributes) == 0) {
 
           var self = this,
             node = self.field.get('schema_node'),

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: SQL Tab Validation
  In-Reply-To: <CAFOhELcepLTgz7ueukoRiQ_gFk0xCOMVQopOMz4nwtbkQwScJw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox