Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leAYj-0002rq-4f for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 May 2021 05:58:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1leAYf-0007l0-Op for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 May 2021 05:58:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leAYf-0007jk-CJ for pgadmin-hackers@lists.postgresql.org; Wed, 05 May 2021 05:58:53 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1leAYX-0002zK-GI for pgadmin-hackers@postgresql.org; Wed, 05 May 2021 05:58:52 +0000 Received: by mail-lf1-x132.google.com with SMTP id x20so906086lfu.6 for ; Tue, 04 May 2021 22:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=FQmiuuX10lwYoSlWSbJJoJsiuFgdO/YPOr4xEhZuQiE=; b=rLo1whp13EDPxjtv2o9HKEb0MNTMHSO3q9XQipdHFqqBjdKVflad2/ESaIkuwaXxWI 9TdcGVu6kpRwHBfy+46l3BMA5alEzNhWJU1RPKM0YX1dQnQuVEEMuW6wqYR6M/8L3x9U 6C0E1zj2CgbWC+kvwiGRFxwldDa53XXsaUySI1jOvdSi8HRDB264KgMol+6syBP3wh0V MKjFT/Vs9YbLKfJ+CEx1qDli6r47cpEq44UUDtip29JhmJc8GatrapaJuT3nCxZPnQs1 GKWM5v1/URtLiN0MRI4xwICOVXmDSaK00Vmcjfxyr3GWwC7yHRDEMPcv4EM0AYy6/3mM vZMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FQmiuuX10lwYoSlWSbJJoJsiuFgdO/YPOr4xEhZuQiE=; b=Y3cHtWZRO+AF191BtCEv5v2IdVmkJsGZ9ECoZsv0MKYwZB9MPiSME9FTBsG3sRErKk uOhgQc9Z1yRV0BdBGGdAWEPRPunkNGGU+RYT729uXRybOuj+cjIRe5dzlMmMmrv5mwpx eRzh7zVAH39wdRDwadxKJ04SvgrzZatHpZW7dIu2vDfqr4TQovL9+GSNsYGNUX8BkgD9 ieuFOksgseZt/Qv6OVev8yaMJ+CrCNpNSh9LbhyCB2YP47xjeWbLQtLmCK2mCUtmo81I LYvmuuhJ6ES6b/jD2ul+IC05FTHr8jRHhvKlxdHyYNs4Yelm9McNqsVlOdr2Vme6EjRA bkJg== X-Gm-Message-State: AOAM531eH0MqvW1mGfGBavd4JWnEyqT1BpL1xmFdJamnwliVvg/xYlGx u22nA2YsUJzG6WMll7yCdWxiwmfcL4AAVbRRzdJlwFvtFKXB5J2Uhrw6FXt9pIm3ySqeIOAui9j 0Kz4AfYnRNHSgif3Aub6hgKExbh0062vEyERTj/6HYcSBxRX+U6xmK0KEYot19djdOVUvtijsx8 SfCXIP6KQHxLLV3IsWa7f+S8ACmrLWhPokQdFEQMVe26cKKBC24Yg2JtG7c2eRhFLV5Q== X-Google-Smtp-Source: ABdhPJykdtmjwdPnJLI+D+w6imBDL3SUEzlgCZngPbzcaWNuniFQ9IiO6OjqOh3qHFrOQDGHCRMjhVLjvhUQeppga+I= X-Received: by 2002:ac2:54ab:: with SMTP id w11mr19929975lfk.220.1620194324101; Tue, 04 May 2021 22:58:44 -0700 (PDT) MIME-Version: 1.0 From: Khushboo Vashi Date: Wed, 5 May 2021 11:28:48 +0530 Message-ID: Subject: [pgAdmin4][Patch] - RM #5776 - Needlessly prompted for a password with SSPI logins To: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000027f50d05c18ee362" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000027f50d05c18ee362 Content-Type: multipart/alternative; boundary="00000000000027f50b05c18ee360" --00000000000027f50b05c18ee360 Content-Type: text/plain; charset="UTF-8" Hi, Please find the attached patch for RM #5776 - Needlessly prompted for a password with SSPI logins. To fix this issue, I have enabled the "Kerberos authentication" flag in the server dialog for Desktop mode also. So, if this flag is set to True, pgAdmin will not prompt for a password on connection/reconnection. This patch also includes the Jasmine test failures caused by my previous Kerberos patch. Thanks, Khushboo --00000000000027f50b05c18ee360 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

P= lease find the attached patch for RM #5776 -=C2=A0=C2=A0Needlessly prompted= for a password with SSPI logins.

To fix this issue,=C2=A0 I have enabled the "= Kerberos authentication" flag in the server dialog for Desktop mode al= so. So, if this flag is set to True, pgAdmin will not prompt for a password= on connection/reconnection.

This patch also inclu= des the Jasmine test failures caused by my previous Kerberos patch.

Thanks,
Khushboo
--00000000000027f50b05c18ee360-- --00000000000027f50d05c18ee362 Content-Type: application/octet-stream; name="RM_5776.patch" Content-Disposition: attachment; filename="RM_5776.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kob1ulyi0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL3N0 YXRpYy9qcy9zZXJ2ZXIuanMgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2Vy dmVycy9zdGF0aWMvanMvc2VydmVyLmpzCmluZGV4IGZkNTI1ZDc2My4uYjIxY2JhNDMxIDEwMDY0 NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9zdGF0aWMv anMvc2VydmVyLmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL3N0YXRpYy9qcy9zZXJ2ZXIuanMKQEAgLTE0LDEyICsxNCwxMSBAQCBkZWZpbmUoJ3BnYWRt aW4ubm9kZS5zZXJ2ZXInLCBbCiAgICdwZ2FkbWluLmFsZXJ0aWZ5anMnLCAncGdhZG1pbi5iYWNr Zm9ybScsCiAgICdzb3VyY2VzL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL21vZGVsX3Zh bGlkYXRpb24nLAogICAncGdhZG1pbi5hdXRoZW50aWNhdGUua2VyYmVyb3MnLAotICAncGdhZG1p bi5icm93c2VyLmNvbnN0YW50cycsCiAgICdwZ2FkbWluLmJyb3dzZXIuc2VydmVyLnByaXZpbGVn ZScsCiBdLCBmdW5jdGlvbigKICAgZ2V0dGV4dCwgdXJsX2ZvciwgJCwgXywgQmFja2JvbmUsIHBn QWRtaW4sIHBnQnJvd3NlciwKICAgc3VwcG9ydGVkX3NlcnZlcnMsIGN1cnJlbnRfdXNlciwgQWxl cnRpZnksIEJhY2tmb3JtLAotICBtb2RlbFZhbGlkYXRpb24sIEtlcmJlcm9zLCBwZ0NvbnN0LAor ICBtb2RlbFZhbGlkYXRpb24sIEtlcmJlcm9zLAogKSB7CiAKICAgaWYgKCFwZ0Jyb3dzZXIuTm9k ZXNbJ3NlcnZlciddKSB7CkBAIC05MTAsMTEgKzkwOSw3IEBAIGRlZmluZSgncGdhZG1pbi5ub2Rl LnNlcnZlcicsIFsKICAgICAgICAgICBpZDogJ2tlcmJlcm9zX2Nvbm4nLCBsYWJlbDogZ2V0dGV4 dCgnS2VyYmVyb3MgYXV0aGVudGljYXRpb24/JyksIHR5cGU6ICdzd2l0Y2gnLAogICAgICAgICAg IGdyb3VwOiBnZXR0ZXh0KCdDb25uZWN0aW9uJyksICdvcHRpb25zJzogewogICAgICAgICAgICAg J29uVGV4dCc6ICBnZXR0ZXh0KCdUcnVlJyksICdvZmZUZXh0JzogIGdldHRleHQoJ0ZhbHNlJyks ICdzaXplJzogJ21pbmknLAotICAgICAgICAgIH0sIGRpc2FibGVkOiBmdW5jdGlvbigpIHsKLSAg ICAgICAgICAgIGlmIChjdXJyZW50X3VzZXJbJ2N1cnJlbnRfYXV0aF9zb3VyY2UnXSAhPSBwZ0Nv bnN0WydLRVJCRVJPUyddKQotICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgICAg IHJldHVybiBmYWxzZTsKLSAgICAgICAgICB9LAorICAgICAgICAgIH0KICAgICAgICAgfSx7CiAg ICAgICAgICAgaWQ6ICdwYXNzd29yZCcsIGxhYmVsOiBnZXR0ZXh0KCdQYXNzd29yZCcpLCB0eXBl OiAncGFzc3dvcmQnLCBtYXhsZW5ndGg6IG51bGwsCiAgICAgICAgICAgZ3JvdXA6IGdldHRleHQo J0Nvbm5lY3Rpb24nKSwgY29udHJvbDogJ2lucHV0JywgbW9kZTogWydjcmVhdGUnXSwKZGlmZiAt LWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9zdGF0aWMvanMvYmFja3VwX2RpYWxvZ193 cmFwcGVyLmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMvYmFja3VwL3N0YXRpYy9qcy9iYWNrdXBfZGlh bG9nX3dyYXBwZXIuanMKaW5kZXggN2UwZGRkNjNmLi4xYTU5ZDQyMGEgMTAwNjQ0Ci0tLSBhL3dl Yi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9zdGF0aWMvanMvYmFja3VwX2RpYWxvZ193cmFwcGVyLmpz CisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9zdGF0aWMvanMvYmFja3VwX2RpYWxvZ193 cmFwcGVyLmpzCkBAIC0xNjksNyArMTY5LDcgQEAgZXhwb3J0IGNsYXNzIEJhY2t1cERpYWxvZ1dy YXBwZXIgZXh0ZW5kcyBEaWFsb2dXcmFwcGVyIHsKICAgICAgIHRoaXMuc2V0RXh0cmFQYXJhbWV0 ZXJzKHNlbGVjdGVkVHJlZU5vZGUsIHRyZWVJbmZvKTsKICAgICAgIGxldCBiYWNrdXBEYXRlID0g dGhpcy52aWV3Lm1vZGVsLnRvSlNPTigpOwogCi0gICAgICBpZih1c2VySW5mb1snYXV0aF9zb3Vy Y2VzJ10gPT0gJ0tFUkJFUk9TJyAmJiAoYmFja3VwRGF0ZS50eXBlID09ICdnbG9iYWxzJyB8fCBi YWNrdXBEYXRlLnR5cGUgPT0gJ3NlcnZlcicpKSB7CisgICAgICBpZih1c2VySW5mb1snY3VycmVu dF9hdXRoX3NvdXJjZSddID09ICdLRVJCRVJPUycgJiYgKGJhY2t1cERhdGUudHlwZSA9PSAnZ2xv YmFscycgfHwgYmFja3VwRGF0ZS50eXBlID09ICdzZXJ2ZXInKSkgewogICAgICAgICBsZXQgbmV3 UHJvbWlzZSA9IGZldGNoX3RpY2tldF9saWZldGltZSgpOwogICAgICAgICBuZXdQcm9taXNlLnRo ZW4oCiAgICAgICAgICAgZnVuY3Rpb24obGlmZXRpbWUpIHsKZGlmZiAtLWdpdCBhL3dlYi9yZWdy ZXNzaW9uL2phdmFzY3JpcHQvYmFja3VwL2JhY2t1cF9kaWFsb2dfd3JhcHBlcl9zcGVjLmpzIGIv d2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9iYWNrdXAvYmFja3VwX2RpYWxvZ193cmFwcGVyX3Nw ZWMuanMKaW5kZXggMjRlZGFkYjgyLi4xZmNiNDRjMDQgMTAwNjQ0Ci0tLSBhL3dlYi9yZWdyZXNz aW9uL2phdmFzY3JpcHQvYmFja3VwL2JhY2t1cF9kaWFsb2dfd3JhcHBlcl9zcGVjLmpzCisrKyBi L3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvYmFja3VwL2JhY2t1cF9kaWFsb2dfd3JhcHBlcl9z cGVjLmpzCkBAIC00Niw2ICs0Niw3IEBAIGRlc2NyaWJlKCdCYWNrdXBEaWFsb2dXcmFwcGVyJywg KCkgPT4gewogICAgICAgfSwKICAgICAgIGtleWJvYXJkTmF2aWdhdGlvbjogamFzbWluZS5jcmVh dGVTcHlPYmooJ2tleWJvYXJkTmF2aWdhdGlvbicsIFsnZ2V0RGlhbG9nVGFiTmF2aWdhdG9yJ10p LAogICAgIH07CisKICAgICBub0RhdGFOb2RlID0gcGdCcm93c2VyLnRyZWVNZW51LmFkZE5ld05v ZGUoJ2xldmVsMS4xJywgdW5kZWZpbmVkLCBbe2lkOiAnbGV2ZWwxJ31dKTsKICAgICBzZXJ2ZXJU cmVlTm9kZSA9IHBnQnJvd3Nlci50cmVlTWVudS5hZGROZXdOb2RlKCdsZXZlbDIuMScsIHsKICAg ICAgIF90eXBlOiAnc2VydmVyJywKZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNzaW9uL2phdmFzY3Jp cHQvYmFja3VwL2dsb2JhbF9zZXJ2ZXJfYmFja3VwX2RpYWxvZ19zcGVjLmpzIGIvd2ViL3JlZ3Jl c3Npb24vamF2YXNjcmlwdC9iYWNrdXAvZ2xvYmFsX3NlcnZlcl9iYWNrdXBfZGlhbG9nX3NwZWMu anMKaW5kZXggZDE1YTg5NTU2Li43N2M2MzVkZmYgMTAwNjQ0Ci0tLSBhL3dlYi9yZWdyZXNzaW9u L2phdmFzY3JpcHQvYmFja3VwL2dsb2JhbF9zZXJ2ZXJfYmFja3VwX2RpYWxvZ19zcGVjLmpzCisr KyBiL3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvYmFja3VwL2dsb2JhbF9zZXJ2ZXJfYmFja3Vw X2RpYWxvZ19zcGVjLmpzCkBAIC0yMCw3ICsyMCw2IEBAIGRlc2NyaWJlKCdHbG9iYWxTZXJ2ZXJC YWNrdXBEaWFsb2cnLCAoKSA9PiB7CiAgIGxldCBhbGVydGlmeVNweTsKICAgbGV0IGJhY2t1cE1v ZGVsU3B5OwogCi0KICAgbGV0IHJvb3ROb2RlOwogICBsZXQgc2VydmVyVHJlZU5vZGU7CiAgIGxl dCBwcGFzU2VydmVyVHJlZU5vZGU7CkBAIC03NCw3ICs3Myw2IEBAIGRlc2NyaWJlKCdHbG9iYWxT ZXJ2ZXJCYWNrdXBEaWFsb2cnLCAoKSA9PiB7CiAgICAgICAgIGFsZXJ0aWZ5U3B5LAogICAgICAg ICBiYWNrdXBNb2RlbFNweQogICAgICAgKTsKLQogICAgICAgcGdCcm93c2VyLmdldF9wcmVmZXJl bmNlID0gamFzbWluZS5jcmVhdGVTcHkoJ2dldF9wcmVmZXJlbmNlcycpOwogICAgIH0pOwogCmRp ZmYgLS1naXQgYS93ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2Zha2VfY29uc3RhbnRzLmpzIGIv d2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9mYWtlX2NvbnN0YW50cy5qcwpuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAuLjRiYzdhMTY1MQotLS0gL2Rldi9udWxsCisrKyBiL3dl Yi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvZmFrZV9jb25zdGFudHMuanMKQEAgLTAsMCArMSwxNyBA QAorLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8KKy8vCisvLyBwZ0FkbWluIDQgLSBQb3N0Z3JlU1FMIFRvb2xz CisvLworLy8gQ29weXJpZ2h0IChDKSAyMDEzIC0gMjAyMSwgVGhlIHBnQWRtaW4gRGV2ZWxvcG1l bnQgVGVhbQorLy8gVGhpcyBzb2Z0d2FyZSBpcyByZWxlYXNlZCB1bmRlciB0aGUgUG9zdGdyZVNR TCBMaWNlbmNlCisvLworLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KKworZGVmaW5lKGZ1bmN0aW9uICgpIHsK KyAgcmV0dXJuIHsKKyAgICAnSU5URVJOQUwnOiAnaW50ZXJuYWwnLAorICAgICdMREFQJzogJ2xk YXAnLAorICAgICdLRVJCRVJPUyc6ICdrZXJiZXJvcycKKyAgfTsKK30pOworCmRpZmYgLS1naXQg YS93ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2Zha2VfY3VycmVudF91c2VyLmpzIGIvd2ViL3Jl Z3Jlc3Npb24vamF2YXNjcmlwdC9mYWtlX2N1cnJlbnRfdXNlci5qcwpuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAuLjZhZDBiNDViOAotLS0gL2Rldi9udWxsCisrKyBiL3dlYi9y ZWdyZXNzaW9uL2phdmFzY3JpcHQvZmFrZV9jdXJyZW50X3VzZXIuanMKQEAgLTAsMCArMSwxNSBA QAorLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8KKy8vCisvLyBwZ0FkbWluIDQgLSBQb3N0Z3JlU1FMIFRvb2xz CisvLworLy8gQ29weXJpZ2h0IChDKSAyMDEzIC0gMjAyMSwgVGhlIHBnQWRtaW4gRGV2ZWxvcG1l bnQgVGVhbQorLy8gVGhpcyBzb2Z0d2FyZSBpcyByZWxlYXNlZCB1bmRlciB0aGUgUG9zdGdyZVNR TCBMaWNlbmNlCisvLworLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KKworZGVmaW5lKGZ1bmN0aW9uICgpIHsK KyAgcmV0dXJuIHsKKyAgICAnY3VycmVudF9hdXRoX3NvdXJjZSc6ICdpbnRlcm5hbCcKKyAgfTsK K30pOworCmRpZmYgLS1naXQgYS93ZWIvd2VicGFjay50ZXN0LmNvbmZpZy5qcyBiL3dlYi93ZWJw YWNrLnRlc3QuY29uZmlnLmpzCmluZGV4IGU3Mjc5OGU5YS4uZTBiNmZkNjlmIDEwMDY0NAotLS0g YS93ZWIvd2VicGFjay50ZXN0LmNvbmZpZy5qcworKysgYi93ZWIvd2VicGFjay50ZXN0LmNvbmZp Zy5qcwpAQCAtMTc5LDYgKzE3OSw4IEBAIG1vZHVsZS5leHBvcnRzID0gewogICAgICAgJ3BnYWRt aW4udG9vbHMuZXJkJzogcGF0aC5qb2luKF9fZGlybmFtZSwgJy4vcGdhZG1pbi90b29scy9lcmQv c3RhdGljL2pzJyksCiAgICAgICAnYnVuZGxlZF9jb2RlbWlycm9yJzogcGF0aC5qb2luKF9fZGly bmFtZSwgJy4vcGdhZG1pbi9zdGF0aWMvYnVuZGxlL2NvZGVtaXJyb3InKSwKICAgICAgICd0b29s cyc6IHBhdGguam9pbihfX2Rpcm5hbWUsICcuL3BnYWRtaW4vdG9vbHMvJyksCisgICAgICAncGdh ZG1pbi51c2VyX21hbmFnZW1lbnQuY3VycmVudF91c2VyJzogcmVncmVzc2lvbkRpciArICcvamF2 YXNjcmlwdC9mYWtlX2N1cnJlbnRfdXNlcicsCisgICAgICAncGdhZG1pbi5icm93c2VyLmNvbnN0 YW50cyc6IHJlZ3Jlc3Npb25EaXIgKyAnL2phdmFzY3JpcHQvZmFrZV9jb25zdGFudHMnLAogICAg IH0sCiAgIH0sCiB9Owo= --00000000000027f50d05c18ee362--