MIME-Version: 1.0
References: 
 <CAOBg0APb6Rdy1i3n_SmB4feywcPw_fh7EWi9TdZTsDroG6gaMA@mail.gmail.com>
 <CAOBg0ANfoqdkRh1L8Q8NeDmm_ktTNP6+=Bxx2dXg=eh_=idLdA@mail.gmail.com>
In-Reply-To: 
 <CAOBg0ANfoqdkRh1L8Q8NeDmm_ktTNP6+=Bxx2dXg=eh_=idLdA@mail.gmail.com>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Thu, 31 Dec 2020 15:23:18 +0530
Message-ID: 
 <CAFOhELcgb8_-QqwJe1a=zgE+z5dRvHF-CoSU7O5gMmC1KkQAwA@mail.gmail.com>
Subject: Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to
 Flask-Babel >= 2.0
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000062f4505b7bf9806"
Precedence: bulk

--000000000000062f4505b7bf9806
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 30, 2020 at 12:29 PM Nikhil Mohite <
nikhil.mohite@enterprisedb.com> wrote:

> Hi Team,
>
> I found one issue related to Flask-Babel migration.
>
> Flask-Babel and Flask-BabelEx are causing the issue if we install them in
> the same environment.
> Flask-BabelEx gets installed as a dependency of Flask-Security-Too librar=
y
> and currently, Flask-Security-Too doesn=E2=80=99t support Flask-Babel, bu=
t the
> latest version (4.0 Not yet released) of Flask-Security-Too will shift to
> Flask-Babel.
> ref: https://github.com/Flask-Middleware/flask-security/issues/353
>
> So I think we should hold Flask-Babel migration for now. but we can updat=
e
> the FLask-BabelEx to the latest version as there is one issue related to =
it
> this https://redmine.postgresql.org/issues/5997
> <https://redmine.postgresql.org/issues/5997> we can fix it first by
> adding the Flask-BabelEx minimum version in our requirements.
>
>
> +1

>
> Regards,
> Nikhil Mohite.
>
> On Tue, Dec 29, 2020 at 4:36 PM Nikhil Mohite <
> nikhil.mohite@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> Please find the attached patch for RM-6088
>> <https://redmine.postgresql.org/issues/6088>: Migrate pgadmin4 from
>> Flask-BabelEx to Flask-Babel >=3D 2.0.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/>
>> *Mob.No: +91-7798364578.*
>>
>

--000000000000062f4505b7bf9806
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Dec 30, 2020 at 12:29 PM Nikh=
il Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.mohi=
te@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div dir=3D"ltr">Hi Team,<br><br><div>I found one issue =
related to Flask-Babel migration.</div><div><br></div><div>Flask-Babel and =
Flask-BabelEx are causing=C2=A0the issue if we install them in the same env=
ironment.</div><div>Flask-BabelEx gets installed as a dependency of Flask-S=
ecurity-Too library and currently, Flask-Security-Too doesn=E2=80=99t suppo=
rt Flask-Babel, but the latest version (4.0 Not yet released) of Flask-Secu=
rity-Too will shift to Flask-Babel.</div><div>ref:=C2=A0<a href=3D"https://=
github.com/Flask-Middleware/flask-security/issues/353" target=3D"_blank">ht=
tps://github.com/Flask-Middleware/flask-security/issues/353</a></div><div><=
br></div><div>So I think we should hold Flask-Babel migration for now. but =
we can update the=C2=A0FLask-BabelEx to the latest version as there is one =
issue related to it this=C2=A0<a href=3D"https://redmine.postgresql.org/iss=
ues/5997" target=3D"_blank">https://redmine.postgresql.org/issues/5997=C2=
=A0</a>=C2=A0we can fix it first by adding the Flask-BabelEx minimum versio=
n in our requirements.</div><div><br></div><div><br></div></div></blockquot=
e><div>+1=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div=
 dir=3D"ltr"><div></div><div><br></div><div>Regards,</div><div>Nikhil Mohit=
e.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmai=
l_attr">On Tue, Dec 29, 2020 at 4:36 PM Nikhil Mohite &lt;<a href=3D"mailto=
:nikhil.mohite@enterprisedb.com" target=3D"_blank">nikhil.mohite@enterprise=
db.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex"><div dir=3D"ltr">Hi Team,<div><br></div><div>Please find the attached=
 patch for <a href=3D"https://redmine.postgresql.org/issues/6088" target=3D=
"_blank">RM-6088</a>:=C2=A0Migrate pgadmin4 from Flask-BabelEx to Flask-Bab=
el &gt;=3D 2.0.</div><div><br><div><br></div>-- <br><div dir=3D"ltr"><div d=
ir=3D"ltr"><b><font face=3D"verdana, sans-serif">Thanks &amp; Regards,</fon=
t></b><div><b><font face=3D"verdana, sans-serif">Nikhil Mohite</font></b></=
div><div><b><font face=3D"verdana, sans-serif">Software Engineer.</font></b=
></div><div><a href=3D"https://www.enterprisedb.com/" target=3D"_blank"><b>=
<font face=3D"verdana, sans-serif">EDB Postgres</font></b></a></div><div><b=
><font face=3D"verdana, sans-serif">Mob.No: +91-7798364578.</font></b></div=
></div></div></div></div>
</blockquote></div>
</blockquote></div></div>

--000000000000062f4505b7bf9806--