Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fThMD-0000Ea-FN for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 05:33:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fThMB-000132-KB for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 05:33:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fThMB-00012r-Aq for pgadmin-hackers@lists.postgresql.org; Fri, 15 Jun 2018 05:33:07 +0000 Received: from mail-ot0-x232.google.com ([2607:f8b0:4003:c0f::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fThM4-0006wZ-5R for pgadmin-hackers@postgresql.org; Fri, 15 Jun 2018 05:33:05 +0000 Received: by mail-ot0-x232.google.com with SMTP id h6-v6so9766784otj.0 for ; Thu, 14 Jun 2018 22:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RS+lluBQB7G9wZgy9Vov0vR3nHFqeS5p//iugHDm8is=; b=OIOC5TZEbaTwHz8zdD3+esL39qceqpVAb0XFqFwoWHZ9iylRa6bdY6f+u1nKlMxPs9 jZGR2ZLNnMZbmkw2Ymg5qe780aYBCLp5U873KbCRB3/rOpFoR/AQDV6ZvmVbqisBy1Tr cgmWjQNkmrSbslSCS2BUmZdFBKqfW+p2EtmUMC+oqM3/SJ+0++eqX2uVoZow3gvyN9FT HGLT3hhOFx6/1BNm7U+9mxY7nvZljIxkl9A3wZTlxHtE3HsyUviij1s8WM5cGBGpZpTC xznrgwz3AVa/GGvV4BtSjSC2npz+78VUuTDgXN1FQT4WUp1daSBgcxW+L4PU9s8/qXUy I2lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RS+lluBQB7G9wZgy9Vov0vR3nHFqeS5p//iugHDm8is=; b=P5JxzfUHKKkUqgDB0fPGAg//6XznuiLoLeCgwNrR8fZcaP0zoM0/awNiIFnM9st4nz eA7IXPY197Yk7D4sx/D3fq2j4qwZD9Ao2rxROOWpHiIVJgd4mf+6JbwtV4U/Ta3RNENy sfdxtgtTK5OTRq7Ki7+o+tBbW6F7EmiHZfM2w9CNAoVKZt42xLOL1PXK33h0LN6D9bSS BBsujYU+lay42bIYpe659pmZ9qNKPr6b2jM5+Ww1XVbQ7Lpg1DK631Svicis4UKlRYs0 uiyK3cwUfZPrY0TFNg0y5OUpUe9LBUSgpjLHLg3auYAzTfZBNEOgzHkhiajdAlPbwuwv XGMg== X-Gm-Message-State: APt69E1wcLJlazqafgJE+Rcr3zUUDfzn2SBAksQZoUrPdxaEPQJaZF/Y eJRDYAMV5cXV7dLqiv96F5RncVgfUd/fY35ntR+CPQ== X-Google-Smtp-Source: ADUXVKKPXdjNPQo5j37y9yvSUMokGRazxB/OMxYsLTiCzSv1/JxfOY92Q4X+lO/7YbShNfkrKmjuNjODiEhMexQL5H8= X-Received: by 2002:a9d:3383:: with SMTP id u3-v6mr124429otc.215.1529040779282; Thu, 14 Jun 2018 22:32:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:4081:0:0:0:0:0 with HTTP; Thu, 14 Jun 2018 22:32:58 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Fri, 15 Jun 2018 11:02:58 +0530 Message-ID: Subject: Re: pgadmin_page functions updated To: Shubham Agarwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007f213b056ea78c46" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007f213b056ea78c46 Content-Type: text/plain; charset="UTF-8" Hi Shubham, On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal < shubham.agarwal@enterprisedb.com> wrote: > Hi Team, > > I have modified following two functions in pgadmin_page.py :- > > 1. click_tab() -> Added wait till element is clickable, test cases are > failing since the function attempts to click the tab which is not yet in > the state to be clicked. > > 2. add_server() -> Replaced the sleep statement with wait till element to > be clickable. > > Please find the attached patch. > > We should start using CSS selectors instead of xpath, otherwise the patch works fine and also changes look good to me. > -- > Thanks & Regards, > Shubham Agarwal > EnterpriseDB Corporation > > The Postgres Database Company > --0000000000007f213b056ea78c46 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Shubham,

On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Team,

I have m= odified following two functions in pgadmin_page.py :-

<= div>1. click_tab() -> Added wait till element is clickable, test cases a= re failing since the function attempts to click the tab which is not yet in= the state to be clicked.

2. add_server() -> Re= placed the sleep statement with wait till element to be clickable.=C2=A0

Please find the attached patch.

We should start using CSS selectors instead of = xpath, otherwise the patch works fine and also changes look good to me.
--
<= div dir=3D"ltr">Thanks= & Regards,
Shubham Agarwal
EnterpriseDB Co= rporation

The Postgres = Database Company

--0000000000007f213b056ea78c46--