Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ets9U-0003NJ-GH for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 09:47:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ets9T-0005Yn-A0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 09:47:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ets9T-0005Yd-3Q for pgadmin-hackers@lists.postgresql.org; Thu, 08 Mar 2018 09:47:55 +0000 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ets9N-0001yN-6Z for pgadmin-hackers@postgresql.org; Thu, 08 Mar 2018 09:47:54 +0000 Received: by mail-oi0-x235.google.com with SMTP id f186so3915726oig.4 for ; Thu, 08 Mar 2018 01:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=der3Hj8m63lOE8a8fO/Mw4tgGZcZMupmePZtlfiYONA=; b=jrRiIxfiHHBlKTu8MugoVVM0ar5ssw7W6nBg7BGHXLN2b4H2C1qe82UQbb864FnCYM boSByn9wTPkKOTPwKGQfBoazv3+Mb/117y8uud39O7oqIppd0JDJbaQZCjwbA5Wi0jZC cBUW7HLhxb5D0Eoh3JFdVgFxW6PSRIuKf/RKmwzKKGnmniXREvj5oBhfjNRMBO6KUj7o E/R9aAfoB3AKy2aehksbizJq1uN6ZI0soDmas3kNYWVpo0nX/f6NPlsaGgBBQ/F6nWDN Pg+nBMnSaB9cHhFG50jZV979ZNqJARfIiksmV8cY8JiExZnK0YUYOpw15DQmfdQMA9T1 z8IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=der3Hj8m63lOE8a8fO/Mw4tgGZcZMupmePZtlfiYONA=; b=J9Arp9fQ0YbfitP/keUb+mt2xp1kwnH4k58LjxMYYKOnibjAmAmjEw/mT27deEXrbQ n9GSsUJ48xaK4pR6IRZoqr+7QA8qES8I/jVYablxP5vEXDGXyEHINT3vrWHkSURw9O9r rewOZndi+d8+ra+LBmXC2XZEVzMnlxwX+jhJ7O5vKvHGBZNPRdjNE2EyloKiQD/lmHnj LEAhHx7bHSj+3BMSXJfxMVlB9RyDH0S7dWRfOoEPaFGMAkFeyMNcH/Ip3RdX+NHa/cu6 J+bd3FeDT+oclnvAsy+A2yf1TnG/uipMAkIzOp83T4dJMy79sZrNqbpP4f4X9LmgQMVH mq5w== X-Gm-Message-State: APf1xPBk3X8NPtkvJ+YVkumDSripZMRfCg4aFKJ9gzaCeX54Ahv3n1Yr c9mCgCgISW3N0QpLGrLFbDGze1y8+KvWvPqqPPORNA== X-Google-Smtp-Source: AG47ELvnwtuLEMq2qa3F9QBTovLNggM057ysMH4iI/30WYJu5WUvic+G69DBf7wRIBAzv+zFDeHTyqgYFE1fmFtcDe4= X-Received: by 10.202.89.66 with SMTP id n63mr14961662oib.10.1520502466742; Thu, 08 Mar 2018 01:47:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Thu, 8 Mar 2018 01:47:46 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Khushboo Vashi Date: Thu, 8 Mar 2018 15:17:46 +0530 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113d597c6925330566e39129" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d597c6925330566e39129 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: > Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't though > (which is odd, as it passed on my local 2.7). > > I am looking into this. Btw, which command do you use to run tests? > On Thu, Mar 8, 2018 at 9:13 AM, Dave Page wrote: > >> Thanks, applied. >> >> On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Please find the patch to fix this. >>>> I have fixed this issue in the StartRunningQueryTest class, this test >>>> class changes the behaviour of the methods through MagicMock and due to >>>> this this test case is failing. >>>> >>>> Revised patch with some modification. >>> >>>> Thanks, >>>> Khushboo >>>> >>>> >>>> On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Wed, Mar 7, 2018 at 10:33 PM, Dave Page wrote: >>>>> >>>>>> It still seems to be failing :-( >>>>>> >>>>>> :( >>>>> >>>>>> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/las >>>>>> tFailedBuild/consoleFull >>>>>> >>>>>> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: >>>>>> >>>>>>> Thanks, applied. Lets see what happens. >>>>>>> >>>>>>> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < >>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Please find the attached updated patch. >>>>>>>> This should work. >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < >>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi >>>>>>>>>>> >>>>>>>>>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Dave, >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Khushboo, can you look at this ASAP please? It passed tests on >>>>>>>>>>>>> my machine, but Jenkins isn't happy. >>>>>>>>>>>>> >>>>>>>>>>>>> I have tried to reproduce the issue with many combination but >>>>>>>>>>>> couldn't reproduce it. >>>>>>>>>>>> With the help of logs, I have tried to fix it. Can you please >>>>>>>>>>>> check this fix is helpful or not? >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On my laptop I now get: >>>>>>>>>>> >>>>>>>>>>> ============================================================ >>>>>>>>>>> ========== >>>>>>>>>>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>>>>>>>>>> .test_poll_query_tool.TestPollQueryTool) >>>>>>>>>>> When query tool polling returns messages with result data-set >>>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>>> ---------- >>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", line >>>>>>>>>>> 104, in runTest >>>>>>>>>>> response_data['data']['additional_messages']) >>>>>>>>>>> File "/System/Library/Frameworks/Py >>>>>>>>>>> thon.framework/Versions/2.7/lib/python2.7/unittest/case.py", >>>>>>>>>>> line 802, in assertIn >>>>>>>>>>> if member not in container: >>>>>>>>>>> TypeError: argument of type 'NoneType' is not iterable >>>>>>>>>>> >>>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>>> ---------- >>>>>>>>>>> >>>>>>>>>>> Please provide some more details. Is this failing for particular >>>>>>>>>> server version? >>>>>>>>>> I am not getting any error with this patch and without this patch >>>>>>>>>> on PY2 and PY3 with a single/multiple servers. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. >>>>>>>>> Here are the package versions in the venv: >>>>>>>>> >>>>>>>>> alabaster==0.7.10 >>>>>>>>> alembic==0.9.6 >>>>>>>>> args==0.1.0 >>>>>>>>> Babel==2.3.4 >>>>>>>>> backports.csv==1.0.4 >>>>>>>>> beautifulsoup4==4.4.1 >>>>>>>>> blinker==1.3 >>>>>>>>> chromedriver-installer==0.0.6 >>>>>>>>> click==6.6 >>>>>>>>> clint==0.5.1 >>>>>>>>> dateutils==0.6.6 >>>>>>>>> docutils==0.13.1 >>>>>>>>> extras==1.0.0 >>>>>>>>> fixtures==3.0.0 >>>>>>>>> Flask==0.11.1 >>>>>>>>> Flask-Babel==0.11.1 >>>>>>>>> Flask-Gravatar==0.4.2 >>>>>>>>> Flask-HTMLmin==1.2 >>>>>>>>> Flask-Login==0.3.2 >>>>>>>>> Flask-Mail==0.9.1 >>>>>>>>> Flask-Migrate==2.0.3 >>>>>>>>> Flask-Paranoid==0.1.0 >>>>>>>>> Flask-Principal==0.4.0 >>>>>>>>> Flask-Script==2.0.6 >>>>>>>>> Flask-Security==1.7.5 >>>>>>>>> Flask-SQLAlchemy==2.1 >>>>>>>>> Flask-WTF==0.12 >>>>>>>>> funcsigs==1.0.2 >>>>>>>>> html5lib==1.0b3 >>>>>>>>> htmlmin==0.1.11 >>>>>>>>> imagesize==0.7.1 >>>>>>>>> importlib==1.0.3 >>>>>>>>> itsdangerous==0.24 >>>>>>>>> Jinja2==2.7.3 >>>>>>>>> linecache2==1.0.0 >>>>>>>>> Mako==1.0.7 >>>>>>>>> MarkupSafe==0.23 >>>>>>>>> minify==0.1.4 >>>>>>>>> mock==2.0.0 >>>>>>>>> passlib==1.6.2 >>>>>>>>> pbr==3.1.1 >>>>>>>>> pkginfo==1.4.1 >>>>>>>>> psycopg2==2.7.3.2 >>>>>>>>> pycodestyle==2.3.1 >>>>>>>>> pycrypto==2.6.1 >>>>>>>>> Pygments==2.2.0 >>>>>>>>> pyperclip==1.5.32 >>>>>>>>> pyrsistent==0.14.0 >>>>>>>>> python-dateutil==2.5.0 >>>>>>>>> python-editor==1.0.3 >>>>>>>>> python-mimeparse==1.6.0 >>>>>>>>> pytz==2014.10 >>>>>>>>> requests==2.13.0 >>>>>>>>> requests-toolbelt==0.7.1 >>>>>>>>> selenium==3.3.3 >>>>>>>>> simplejson==3.6.5 >>>>>>>>> six==1.11.0 >>>>>>>>> snowballstemmer==1.2.1 >>>>>>>>> speaklater==1.3 >>>>>>>>> Sphinx==1.5.3 >>>>>>>>> SQLAlchemy==1.0.14 >>>>>>>>> sqlparse==0.1.19 >>>>>>>>> testscenarios==0.5.0 >>>>>>>>> testtools==2.0.0 >>>>>>>>> traceback2==1.4.0 >>>>>>>>> unittest2==1.1.0 >>>>>>>>> Werkzeug==0.9.6 >>>>>>>>> WTForms==2.0.2 >>>>>>>>> yuicompressor==2.4.8 >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d597c6925330566e39129 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 8, 2018 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
Well, it lo= oks like Python 3 might be happy now. 2.6 and 2.7 aren't though (which = is odd, as it passed on my local 2.7).

I am looking into this. Btw, which command do you use to run tests?=C2=A0<= /div>
On Thu, Mar 8, 2018 = at 9:13 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Thu, Mar 8, 2018 a= t 4:26 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On We= d, Mar 7, 2018 at 11:13 PM, Khushboo Vashi <khushboo.vashi@e= nterprisedb.com> wrote:
Hi Dave,

Please find the patch to fix= this.
I have fixed this issue in the StartRunningQueryTest class= , this test class changes the behaviour of the methods through MagicMock an= d due to this this test case is failing.

Revised patch with some modification.=C2=A0
Thanks,
Khushboo


On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
=


On Wed, Mar 7, 2018 at 10:33 PM, D= ave Page <dpage@pgadmin.org> wrote:
It still seems to be failing :-(

=
:(=C2=A0

On Wed, Mar 7, 2018 at 4:50 PM, Dave Page <dpage@pgadmin.org>= ; wrote:
Thanks, = applied. Lets see what happens.

On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Please find the attached updated patch= .
This should work.

=
On Wed, Mar 7, 2018 at 9:46 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">

On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi &= lt;khu= shboo.vashi@enterprisedb.com> wrote:


On Wed, Mar 7, 2018 at 9:23 PM, Dave Page <dpag= e@pgadmin.org> wrote:
Hi

On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave= ,

On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpa= ge@pgadmin.org> wrote:
Khushboo, can you look at this ASAP please?= It passed tests on my machine, but Jenkins isn't happy.

=
I have tried to reproduce the issue with man= y combination but couldn't reproduce it.
With the help of log= s, I have tried to fix it. Can you please check this fix is helpful or not?= =C2=A0

On my= laptop I now get:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin= .tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set=
----------------------------------------------------= ------------------
Traceback (most recent call last):
<= div>=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqle= ditor/tests/test_poll_query_tool.py", line 104, in runTest
<= div>=C2=A0 =C2=A0 response_data['data']['additional_messag= es'])
=C2=A0 File "/System/Library/Frameworks/Pytho= n.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 80= 2, in assertIn
=C2=A0 =C2=A0 if member not in container:
TypeError: argument of type 'NoneType' is not iterable
=
-------------------------------------------------------= ---------------=C2=A0

Please provide some more details. Is this faili= ng for particular server version?
I am not getting any error with= this patch and without this patch on PY2 and PY3 with a single/multiple se= rvers.

Pytho= n 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are the pack= age versions in the venv:

alabaster=3D=3D0.7.= 10
alembic=3D=3D0.9.6
args=3D=3D0.1.0
Babel= =3D=3D2.3.4
backports.csv=3D=3D1.0.4
beautifulsoup4=3D= =3D4.4.1
blinker=3D=3D1.3
chromedriver-installer=3D=3D0= .0.6
click=3D=3D6.6
clint=3D=3D0.5.1
dateutil= s=3D=3D0.6.6
docutils=3D=3D0.13.1
extras=3D=3D1.0.0
fixtures=3D=3D3.0.0
Flask=3D=3D0.11.1
Flask-Babe= l=3D=3D0.11.1
Flask-Gravatar=3D=3D0.4.2
Flask-HTMLmin= =3D=3D1.2
Flask-Login=3D=3D0.3.2
Flask-Mail=3D=3D0.9.1<= /div>
Flask-Migrate=3D=3D2.0.3
Flask-Paranoid=3D=3D0.1.0
Flask-Principal=3D=3D0.4.0
Flask-Script=3D=3D2.0.6
Flask-Security=3D=3D1.7.5
Flask-SQLAlchemy=3D=3D2.1
F= lask-WTF=3D=3D0.12
funcsigs=3D=3D1.0.2
html5lib=3D=3D1.= 0b3
htmlmin=3D=3D0.1.11
imagesize=3D=3D0.7.1
= importlib=3D=3D1.0.3
itsdangerous=3D=3D0.24
Jinja2=3D= =3D2.7.3
linecache2=3D=3D1.0.0
Mako=3D=3D1.0.7
MarkupSafe=3D=3D0.23
minify=3D=3D0.1.4
mock=3D=3D2.0.= 0
passlib=3D=3D1.6.2
pbr=3D=3D3.1.1
pkginfo= =3D=3D1.4.1
psycopg2=3D=3D2.7.3.2
pycodestyle=3D=3D2.3.= 1
pycrypto=3D=3D2.6.1
Pygments=3D=3D2.2.0
pyp= erclip=3D=3D1.5.32
pyrsistent=3D=3D0.14.0
python-dateut= il=3D=3D2.5.0
python-editor=3D=3D1.0.3
python-mimeparse= =3D=3D1.6.0
pytz=3D=3D2014.10
requests=3D=3D2.13.0
requests-toolbelt=3D=3D0.7.1
selenium=3D=3D3.3.3
= simplejson=3D=3D3.6.5
six=3D=3D1.11.0
snowballstemmer= =3D=3D1.2.1
speaklater=3D=3D1.3
Sphinx=3D=3D1.5.3
=
SQLAlchemy=3D=3D1.0.14
sqlparse=3D=3D0.1.19
testsc= enarios=3D=3D0.5.0
testtools=3D=3D2.0.0
traceback2=3D= =3D1.4.0
unittest2=3D=3D1.1.0
Werkzeug=3D=3D0.9.6
=
WTForms=3D=3D2.0.2
yuicompressor=3D=3D2.4.8
=
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany




--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterp= rise PostgreSQL Company






--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

= EnterpriseDB UK: = http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113d597c6925330566e39129--