MIME-Version: 1.0
References: 
 <CA+OCxozRoYYgSp+BRrovk31uzn4sB0JCL6ztcgaOjpx6qnfbqA@mail.gmail.com>
In-Reply-To: 
 <CA+OCxozRoYYgSp+BRrovk31uzn4sB0JCL6ztcgaOjpx6qnfbqA@mail.gmail.com>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Wed, 30 Jun 2021 17:06:17 +0530
Message-ID: 
 <CAFOhELd7fo_bxqrOfdhgPV4Pb5b_O+bYyTR9ooj40RaNpMeXMQ@mail.gmail.com>
Subject: Re: RM 6427 - Newlines in text columns of resultset show an allegedly
 "empty" field
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Content-Type: multipart/alternative; boundary="000000000000170d0205c5fa2259"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFOhELd7fo_bxqrOfdhgPV4Pb5b_O%2BbYyTR9ooj40RaNpMeXMQ%40mail.gmail.com>
Precedence: bulk

--000000000000170d0205c5fa2259
Content-Type: text/plain; charset="UTF-8"

Hi Dave,

On Wed, Jun 30, 2021 at 3:35 PM Dave Page <dpage@pgadmin.org> wrote:

> Here's a simple patch for $SUBJECT. It will remove any leading spaces from
> the grid cell display and replace them with '[...] '. In edit mode, the
> data is unchanged.
>
> The patch looks good to me.
Do we need to specify somewhere what is [...] ?

The only downside I can see to this is that the tooltip will show the
> modified data when it probably should actually show the un-modified data.
> Unfortunately that's handled by a SlickGrid plugin, which would have to be
> vendorised and modified (perhaps non-trivially). I don't think that's a big
> issue though.
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

--000000000000170d0205c5fa2259
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Dave,</div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Wed, Jun 30, 2021 at 3:35 PM Dave Page &lt=
;<a href=3D"mailto:dpage@pgadmin.org">dpage@pgadmin.org</a>&gt; wrote:<br><=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Her=
e&#39;s a simple patch for $SUBJECT. It will remove any leading spaces from=
 the grid cell display and replace them with &#39;[...] &#39;. In edit mode=
, the data is unchanged.<div><br></div></div></blockquote><div>The patch lo=
oks good to me.=C2=A0</div><div>Do we need to specify somewhere what is [..=
.] ?</div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
<div dir=3D"ltr"><div></div><div>The only downside I can see to this is tha=
t the tooltip will show the modified data when it probably should actually =
show the un-modified data. Unfortunately that&#39;s handled by a SlickGrid =
plugin, which would have to be vendorised and modified (perhaps non-trivial=
ly). I don&#39;t think that&#39;s a big issue though.<br clear=3D"all"><div=
><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr">Dave Page<br>Blog: <a h=
ref=3D"https://pgsnake.blogspot.com" target=3D"_blank">https://pgsnake.blog=
spot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"https://www.enterp=
risedb.com" target=3D"_blank">https://www.enterprisedb.com</a><br><br></div=
></div></div></div>
</blockquote></div></div>

--000000000000170d0205c5fa2259--