Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etQiz-00070v-9N for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 04:30:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etQix-0003pP-H0 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 04:30:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etQix-0003pD-7q for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 04:30:43 +0000 Received: from mail-ot0-x22b.google.com ([2607:f8b0:4003:c0f::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etQit-0004Pu-9z for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 04:30:42 +0000 Received: by mail-ot0-x22b.google.com with SMTP id y11so913106otg.0 for ; Tue, 06 Mar 2018 20:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o0zXuASfnIL1OuQEIZ4gOW+Kv0WNEBL6JP9QR8PVyI4=; b=Bxsp2BaYF6z0+Tc9XjSuChA9d30ODesw50Lr73KCEGi1jV3OJCHCM8kp2AO1XEGsUA rLA72EG41GK2iZGjnRDOGACs0kYtw4dHcl18pGksX72rP/0Y80pTbpAR8iZGLbertRh8 UvGH/Jy7dO55yE1C/aMOYxQ/bQFyEphhvJ3aQEODQD1nw5rNd1cMwxgXK6+en0f7xBlB cO/bdcdSZYT7rCUv9n4XviS0s6fsspBox0+PKRo5mZlwCsWVMNKBXiEBJbeRpO1EbiTp YIpyYCb1yeido7IWF98asowXkuWta4vICWF8TS8ei9GRfglA+XMrNkvham4m1GZwrX8i T6uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o0zXuASfnIL1OuQEIZ4gOW+Kv0WNEBL6JP9QR8PVyI4=; b=dTdx6XjQymedrnQ5I0UIdpzNS37RQsycfM4YT52mwH21+91Gb2hxRo14DGs+QVFafn EwBvMMlqGAifcrROaEba94Rroj6b7IgB3iIpPeMKfFT/MbkUUZFjYYBbXIlIRXcHGCzg uAqabdDOEwS9CZLD16hpK6OzLazQz6T8jhccWS6vQrxgdTc8c8aoqkG8wolV5HOxKsO0 EeDtTLwydmJYoIK/cUnZ5PsY+tbYPAk8XWuJLkBV9ZBMwKyJUHwkwV2l6gqgbM/2qZUm pmghBc6OMpqXIBPzvALRMsYAaD2OoMwl+K+uIIwCViejfUKyrNjbfsbLdp+l8k5khqeU JYBQ== X-Gm-Message-State: APf1xPBB1iJ57wA8g44S3WaoM9OhmYR7qhRjkpwMTP4+tXMDzQtz3yy6 Sh6Vh1VhGmsdb/XoNYxYkoCG8mFXCGDiOPo0FuxiGA== X-Google-Smtp-Source: AG47ELsJCV2gUW5xcqat1UhUpqfQrpis54Dv3ofm0UDNdx6BoqzgFHPEx92nSDTf1HlC/ZU4xBOn7ZNiatYkYkSRrLM= X-Received: by 10.157.48.73 with SMTP id w9mr15416504otd.391.1520397036510; Tue, 06 Mar 2018 20:30:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Tue, 6 Mar 2018 20:30:36 -0800 (PST) In-Reply-To: References: From: Khushboo Vashi Date: Wed, 7 Mar 2018 10:00:36 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS To: Joao De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113db6fa477a1d0566cb05a0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113db6fa477a1d0566cb05a0 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Khushboo, > > All tests pass on CI, and the code looks good. The only issue that I found > was the line: > os.path.dirname(os.path.realpath(__file__)) + "/../templates" > > that will not work on windows. > So I updated your patch with the change and it should be ready to merge. > > Thanks Joao. Thanks > Joao > > On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Joao, >> >> Thanks for reviewing. >> >> On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Kushboo, >>> >>> Can we add some Unit test to ensure this does not happen again? >>> >>> Please find the attached patch with the unit tests. >> >>> Thanks >>> Joao >>> >>> Thanks, >> Khushboo >> >>> On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix RM # 3135 - [Web based] Syntax >>>> error displayed when user try to insert data on table where primray key is >>>> in captial letters and table contains OIDS >>>> >>>> Thanks, >>>> Khushboo >>>> >>> --001a113db6fa477a1d0566cb05a0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira <jd= ealmeidapereira@pivotal.io> wrote:
Hello Khushboo,

All tests pass = on CI, and the code looks good. The only issue that I found was the line:
=C2=A0os.path.dirname(os.path.realpath(__file__)) + "/..= /templates"

that will not work on windows= .=C2=A0
So I updated your patch with the change and it should be = ready to merge.

Thanks Joao.

Than= ks
Joao

On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi <khushboo.vashi@enterprised= b.com> wrote:
Hi Joao,

Thanks for reviewing.

<= div class=3D"gmail_extra">
On Thu, = Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira <jdealmeidapere= ira@pivotal.io> wrote:
Hello Kushboo,

Can we add some Unit test to= ensure this does not happen again?

=
Please find the attached patch with the unit tests.=C2= =A0
Th= anks
Joao

Thank= s,
Khushboo=C2=A0
On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <khushboo= .vashi@enterprisedb.com> wrote:
Hi,

Please find the attached p= atch to fix RM # 3135 - [Web based] Syntax error displayed when user try to= insert data on table where primray key is in captial letters and table con= tains OIDS

Thanks,
Khushboo
<= /div>
--001a113db6fa477a1d0566cb05a0--