Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPt9t-0005FW-0O for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Jun 2017 16:16:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPt9s-0008Ty-3M for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Jun 2017 16:16:08 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dPt9r-0008To-Ax for pgadmin-hackers@lists.postgresql.org; Tue, 27 Jun 2017 16:16:07 +0000 Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dPt9m-0005YE-NJ for pgadmin-hackers@postgresql.org; Tue, 27 Jun 2017 16:16:05 +0000 Received: by mail-oi0-x22a.google.com with SMTP id p187so21216782oif.3 for ; Tue, 27 Jun 2017 09:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=crv56OOHVfehA4FAwxdP9XhUrr825BdpPo8l3kvf8bk=; b=dKe2kiQTjUILFMGNEn61GJGAZk+Aj4P8ZjBn5RYTE1LHXDwCCzNSFcgQaUHtEot8nA T6zi6YpyP4XKtwwDlm915WWZ2kkN1Q5PJt7AQSh+5rjeo6Xrci15SnVKo3I1WC27W+AH IMlTnJS/RrIhwT2bP/x0HmnPheabYUbhtvcorBVq4nIBjai6ukuET1eRr8uHaOUW+3+6 7uzL8JiS1Maja34fRbBm4SrzweZSxM9g5b2LQjsEznVcheSM+W85YVv2qPW5S1nqZ0uz LkDPNsvnE7+vBqVsrnaqZF68TvD2pC40xNdLh3Df5bRZOuR9RaarfDuH8bFFJUtfN+Ma sdGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=crv56OOHVfehA4FAwxdP9XhUrr825BdpPo8l3kvf8bk=; b=fvnkVjJrKNmrsNjWwVMABNy/aV/Qtweb2X6KavQNUr7KWC7UCVBuHDLwJdYCChlbUZ QZu5TqOjx+e3oSk9wHiCeLSMXdTnwurj9821NQe6NQ23fM/OYa8cA5RHyyFJupx6GzFX RHAmI2a2/ljE7DQbgBecYUkF0I9L104DG4NQ2n12A4N107VLatkyttdHL2BxJgp1QuL9 3Cn96W/XinL8vpQCfHMjrYEUG7kQ0i1AUa92lsjQcUyU6b08etPj6kCNbsw0G/j8igWW QtYehy+Ok310Ksofiw/l5JTaraD9O8qJr6pvDM+9nDRyzFQ4iYMDDNbAQmWOcMwbbpIb KNsw== X-Gm-Message-State: AKS2vOxOExUM6L2odRVeS+4hosRx/7eIYMQ57QHsaoKw9H4jyz2QROEb +YLx4YvBgITvX+uuqd8KHD0WoDiz7BXs X-Received: by 10.202.185.10 with SMTP id j10mr3332815oif.126.1498580161574; Tue, 27 Jun 2017 09:16:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.40.70 with HTTP; Tue, 27 Jun 2017 09:16:00 -0700 (PDT) Received: by 10.74.40.70 with HTTP; Tue, 27 Jun 2017 09:16:00 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Tue, 27 Jun 2017 21:46:00 +0530 Message-ID: Subject: Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4] To: Dave Page Cc: Ashesh Vashi , Harshal Dhumal , Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113ce08232cb1b0552f36209" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Unsubscribe: , List-Archive: Precedence: bulk --001a113ce08232cb1b0552f36209 Content-Type: text/plain; charset="UTF-8" On 27 Jun 2017 18:33, "Dave Page" wrote: Thanks - patch committed! Awsome job :-) Gr8. Finally no more rebase request for Harshal. :) On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jun 26, 2017 at 5:24 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> yes i'm working on that only :) >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Mon, Jun 26, 2017 at 5:22 PM, Dave Page wrote: >> >>> I'm sorry, it needs rebasing again. If you can do it quickly, I'll >>> make sure it's the next patch I work on in that area. >>> >>> Thanks. >>> >>> On Mon, Jun 26, 2017 at 5:16 AM, Harshal Dhumal >>> wrote: >>> > Hi Dave, >>> > >>> > Please find updated rebased patch for RM2137 >>> > >>> > On Fri, Jun 23, 2017 at 9:00 PM, Dave Page wrote: >>> >> >>> >> Hi Harshal, >>> >> >>> >> When can we expect an updated version of this patch? I think it's >>> >> important to get this into the next release. >>> >> >>> >> Thanks! >>> >> >>> >> On Fri, Jun 16, 2017 at 10:55 AM, Dave Page >>> wrote: >>> >> > Hi, >>> >> > >>> >> > That's better - the failures are far less random now :-). I got the >>> >> > following two though, on both PG and EPAS 9.5: >>> >> > >>> >> > ============================================================ >>> ========== >>> >> > ERROR: runTest >>> >> > (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) >>> >> > Query tool feature test >>> >> > ------------------------------------------------------------ >>> ---------- >>> >> > Traceback (most recent call last): >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_t >>> ool_tests.py", >>> >> > line 95, in runTest >>> >> > self._query_tool_explain_analyze_buffers() >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_t >>> ool_tests.py", >>> >> > line 443, in _query_tool_explain_analyze_buffers >>> >> > canvas.find_element_by_xpath("//*[contains(string(), 'Shared >>> Read >>> >> > Blocks')]") >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webelement.py", >>> >> > line 260, in find_element_by_xpath >>> >> > return self.find_element(by=By.XPATH, value=xpath) >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webelement.py", >>> >> > line 508, in find_element >>> >> > {"using": by, "value": value})['value'] >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webelement.py", >>> >> > line 491, in _execute >>> >> > return self._parent.execute(command, params) >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webdriver.py", >>> >> > line 238, in execute >>> >> > self.error_handler.check_response(response) >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/errorhandler.py", >>> >> > line 193, in check_response >>> >> > raise exception_class(message, screen, stacktrace) >>> >> > NoSuchElementException: Message: no such element: Unable to locate >>> >> > element: {"method":"xpath","selector":"//*[contains(string(), >>> 'Shared >>> >> > Read Blocks')]"} >>> >> > (Session info: chrome=58.0.3029.110) >>> >> > (Driver info: chromedriver=2.29.461585 >>> >> > (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X >>> 10.12.3 >>> >> > x86_64) >>> >> > >>> >> > >>> >> > ============================================================ >>> ========== >>> >> > ERROR: runTest >>> >> > (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest) >>> >> > Validate Insert, Update operations in View data with given test data >>> >> > ------------------------------------------------------------ >>> ---------- >>> >> > Traceback (most recent call last): >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_da >>> ta_dml_queries.py", >>> >> > line 104, in runTest >>> >> > self._add_row() >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_da >>> ta_dml_queries.py", >>> >> > line 255, in _add_row >>> >> > self._update_cell(cell_xpath, config_data[str(idx)]) >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_da >>> ta_dml_queries.py", >>> >> > line 164, in _update_cell >>> >> > cell_el = self.page.find_by_xpath(xpath) >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgad >>> min_page.py", >>> >> > line 122, in find_by_xpath >>> >> > return self.wait_for_element(lambda driver: >>> >> > driver.find_element_by_xpath(xpath)) >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgad >>> min_page.py", >>> >> > line 205, in wait_for_element >>> >> > return self._wait_for("element to exist", element_if_it_exists) >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgad >>> min_page.py", >>> >> > line 255, in _wait_for >>> >> > "Timed out waiting for " + waiting_for_message) >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/support/wait.py", >>> >> > line 71, in until >>> >> > value = method(self._driver) >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgad >>> min_page.py", >>> >> > line 200, in element_if_it_exists >>> >> > if element.is_displayed() and element.is_enabled(): >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webelement.py", >>> >> > line 358, in is_displayed >>> >> > return self._execute(Command.IS_ELEMENT_DISPLAYED)['value'] >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webelement.py", >>> >> > line 491, in _execute >>> >> > return self._parent.execute(command, params) >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/webdriver.py", >>> >> > line 238, in execute >>> >> > self.error_handler.check_response(response) >>> >> > File >>> >> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/selenium/webdriver/remote/errorhandler.py", >>> >> > line 193, in check_response >>> >> > raise exception_class(message, screen, stacktrace) >>> >> > StaleElementReferenceException: Message: stale element reference: >>> >> > element is not attached to the page document >>> >> > (Session info: chrome=58.0.3029.110) >>> >> > (Driver info: chromedriver=2.29.461585 >>> >> > (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X >>> 10.12.3 >>> >> > x86_64) >>> >> > >>> > >>> > >>> > I checked my feature test cases for any database server version/type >>> (PG, >>> > EPAS) specific failures and I found that test cases are working fine >>> on all >>> > of them. However I have slightly modified test case to overcome above >>> > mentioned failures. >>> > >>> >> >>> >> > >>> >> > On 9.4 everything passes. On 9.6, I get one failure: >>> >> > >>> >> > ============================================================ >>> ========== >>> >> > FAIL: runTest >>> >> > (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest) >>> >> > Validate Insert, Update operations in View data with given test data >>> >> > ------------------------------------------------------------ >>> ---------- >>> >> > Traceback (most recent call last): >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_da >>> ta_dml_queries.py", >>> >> > line 105, in runTest >>> >> > self._verify_row_data(True) >>> >> > File >>> >> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_da >>> ta_dml_queries.py", >>> >> > line 282, in _verify_row_data >>> >> > self.assertEquals(cells[idx], config_data[str(idx)][1]) >>> >> > AssertionError: u'[default]' != u'1' >>> >> > - [default] >>> >> > + 1 >>> >> > >>> > >>> > I guess Khushboo has fixed this recently. >>> > >>> > >>> >> >>> >> > Screenshots attached. >>> >> > >>> >> > On Fri, Jun 16, 2017 at 7:54 AM, Harshal Dhumal >>> >> > wrote: >>> >> >> Hi Dave, >>> >> >> >>> >> >> Please find attached patch where I have added timeout of 2 seconds >>> >> >> before >>> >> >> selecting object menu in connect to server function. >>> >> >> >>> >> >> Note: Apply this patch on top of previous patch for on demand >>> loading >>> >> >> feature. >>> >> >> >>> >> >> >>> >> >> -- >>> >> >> Harshal Dhumal >>> >> >> Sr. Software Engineer >>> >> >> >>> >> >> EnterpriseDB India: http://www.enterprisedb.com >>> >> >> The Enterprise PostgreSQL Company >>> >> >> >>> >> >> On Fri, Jun 16, 2017 at 2:25 AM, Dave Page >>> wrote: >>> >> >>> >>> >> >>> Sounds good, thanks. >>> >> >>> >>> >> >>> On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal >>> >> >>> wrote: >>> >> >>> > Hi >>> >> >>> > >>> >> >>> > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page >>> >> >>> > wrote: >>> >> >>> >> >>> >> >>> >> Hi >>> >> >>> >> >>> >> >>> >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal >>> >> >>> >> wrote: >>> >> >>> >> > Hi Dave, >>> >> >>> >> > >>> >> >>> >> > Please find attached updated patch. >>> >> >>> >> > >>> >> >>> >> > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page < >>> dpage@pgadmin.org> >>> >> >>> >> > wrote: >>> >> >>> >> >> >>> >> >>> >> >> Hi >>> >> >>> >> >> >>> >> >>> >> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal >>> >> >>> >> >> wrote: >>> >> >>> >> >>> >>> >> >>> >> >>> Hi Dave, >>> >> >>> >> >>> >>> >> >>> >> >>> Please find rebased patch for RM2137. >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> Looking very good. The only issues I see are: >>> >> >>> >> >> >>> >> >>> >> >> - The row headers should auto-size such that they can >>> display >>> >> >>> >> >> the >>> >> >>> >> >> row >>> >> >>> >> >> numbers if the last row was displayed. E.g. if there are >>> 12345 >>> >> >>> >> >> rows >>> >> >>> >> >> in >>> >> >>> >> >> total, then the row header should be sized to display 5 >>> digits. >>> >> >>> >> >> >>> >> >>> >> > Fixed. >>> >> >>> >> > >>> >> >>> >> > >>> >> >>> >> >> >>> >> >>> >> >> - The tests are comprehensive, which is awesome. However, >>> every >>> >> >>> >> >> time >>> >> >>> >> >> I >>> >> >>> >> >> ran >>> >> >>> >> >> them, at least one of the feature tests failed. >>> Unfortunately, >>> >> >>> >> >> it >>> >> >>> >> >> was a >>> >> >>> >> >> different one each time. In the last two runs, I got: >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> ============================== >>> ======================================== >>> >> >>> >> >> ERROR: runTest >>> >> >>> >> >> (pgadmin.feature_tests.query_t >>> ool_tests.QueryToolFeatureTest) >>> >> >>> >> >> Query tool feature test >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> ------------------------------ >>> ---------------------------------------- >>> >> >>> >> >> Traceback (most recent call last): >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/git/pgadmin4/web >>> /regression/feature_utils/base_feature_test.py", >>> >> >>> >> >> line 40, in setUp >>> >> >>> >> >> self.before() >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/git/pgadmin4/web >>> /pgadmin/feature_tests/query_tool_tests.py", >>> >> >>> >> >> line 40, in before >>> >> >>> >> >> self._connects_to_server() >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/git/pgadmin4/web >>> /pgadmin/feature_tests/query_tool_tests.py", >>> >> >>> >> >> line 144, in _connects_to_server >>> >> >>> >> >> self.page.driver.find_element_by_link_text("Create"))\ >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> webdriver.py", >>> >> >>> >> >> line 319, in find_element_by_link_text >>> >> >>> >> >> return self.find_element(by=By.LINK_TEXT, >>> value=link_text) >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> webdriver.py", >>> >> >>> >> >> line 756, in find_element >>> >> >>> >> >> 'value': value})['value'] >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> webdriver.py", >>> >> >>> >> >> line 238, in execute >>> >> >>> >> >> self.error_handler.check_response(response) >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> errorhandler.py", >>> >> >>> >> >> line 193, in check_response >>> >> >>> >> >> raise exception_class(message, screen, stacktrace) >>> >> >>> >> >> NoSuchElementException: Message: no such element: Unable to >>> >> >>> >> >> locate >>> >> >>> >> >> element: {"method":"link text","selector":"Create"} >>> >> >>> >> >> (Session info: chrome=58.0.3029.110) >>> >> >>> >> >> (Driver info: chromedriver=2.29.461585 >>> >> >>> >> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS >>> X >>> >> >>> >> >> 10.12.3 >>> >> >>> >> >> x86_64) >>> >> >>> >> >> >>> >> >>> >> > I checked code from _connects_to_server function which is >>> common >>> >> >>> >> > in >>> >> >>> >> > all >>> >> >>> >> > features test cases. I didn't find anything wrong with this. >>> If >>> >> >>> >> > there >>> >> >>> >> > is >>> >> >>> >> > a >>> >> >>> >> > bug in this function then all feature test must fail. >>> >> >>> >> > Let me know if you are getting failure consistently in >>> >> >>> >> > _connects_to_server >>> >> >>> >> > function. >>> >> >>> >> >>> >> >>> >> I wondered if that one is a race condition. Do we need a short >>> >> >>> >> delay >>> >> >>> >> before clicking the Object menu? I have seen this occasionally >>> >> >>> >> before. >>> >> >>> > >>> >> >>> > >>> >> >>> > OK. In that case let's try putting 1-2 second delay and observer >>> >> >>> > behaviour. >>> >> >>> > I'll send separate patch for this tomorrow as this is not >>> related to >>> >> >>> > on >>> >> >>> > demand query result feature or its test cases. >>> >> >>> > >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> ============================== >>> ======================================== >>> >> >>> >> >> ERROR: runTest >>> >> >>> >> >> (pgadmin.feature_tests.query_t >>> ool_tests.QueryToolFeatureTest) >>> >> >>> >> >> Query tool feature test >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> ------------------------------ >>> ---------------------------------------- >>> >> >>> >> >> Traceback (most recent call last): >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/git/pgadmin4/web >>> /pgadmin/feature_tests/query_tool_tests.py", >>> >> >>> >> >> line 119, in runTest >>> >> >>> >> >> self._query_tool_auto_rollback_enabled() >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/git/pgadmin4/web >>> /pgadmin/feature_tests/query_tool_tests.py", >>> >> >>> >> >> line 697, in _query_tool_auto_rollback_enabled >>> >> >>> >> >> '//div[contains(@class, "sql-editor-message") and >>> >> >>> >> >> contains(string(), >>> >> >>> >> >> "COMMIT")]' >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> webdriver.py", >>> >> >>> >> >> line 295, in find_element_by_xpath >>> >> >>> >> >> return self.find_element(by=By.XPATH, value=xpath) >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> webdriver.py", >>> >> >>> >> >> line 756, in find_element >>> >> >>> >> >> 'value': value})['value'] >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> webdriver.py", >>> >> >>> >> >> line 238, in execute >>> >> >>> >> >> self.error_handler.check_response(response) >>> >> >>> >> >> File >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> >>> >> >>> >> >> "/Users/dpage/.virtualenvs/pga >>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/ >>> errorhandler.py", >>> >> >>> >> >> line 193, in check_response >>> >> >>> >> >> raise exception_class(message, screen, stacktrace) >>> >> >>> >> >> NoSuchElementException: Message: no such element: Unable to >>> >> >>> >> >> locate >>> >> >>> >> >> element: {"method":"xpath","selector":" >>> //div[contains(@class, >>> >> >>> >> >> "sql-editor-message") and contains(string(), "COMMIT")]"} >>> >> >>> >> >> (Session info: chrome=58.0.3029.110) >>> >> >>> >> >> (Driver info: chromedriver=2.29.461585 >>> >> >>> >> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS >>> X >>> >> >>> >> >> 10.12.3 >>> >> >>> >> >> x86_64) >>> >> >>> >> >> >>> >> >>> >> > I have updated Auto rollback enabled test in this patch. >>> >> >>> >> > >>> >> >>> >> >> >>> >> >>> >> >> Relevant screenshots attached. >>> >> >>> >> >> >>> >> >>> >> >> - Can you tidy up the regression output a little please? >>> Instead >>> >> >>> >> >> of: >>> >> >>> >> >> >>> >> >>> >> >> ------- >>> >> >>> >> >> runTest >>> >> >>> >> >> (pgadmin.feature_tests.query_t >>> ool_tests.QueryToolFeatureTest) >>> >> >>> >> >> Query tool feature test ... On demand result set on >>> scrolling... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> On demand result set on grid select all... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> On demand result set on column select all... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Explain query... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Explain query with verbose... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Explain query with costs... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Explain analyze query... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Explain analyze query with buffers... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Explain analyze query with timing... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Auto commit disabled... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Auto commit enabled... >>> >> >>> >> >> OK. >>> >> >>> >> >> >>> >> >>> >> >> Auto rollback enabled... >>> >> >>> >> >> ERROR >>> >> >>> >> >> ------- >>> >> >>> >> >> >>> >> >>> >> >> Something like: >>> >> >>> >> >> >>> >> >>> >> >> ------- >>> >> >>> >> >> runTest >>> >> >>> >> >> (pgadmin.feature_tests.query_t >>> ool_tests.QueryToolFeatureTest) >>> >> >>> >> >> Query tool feature test ... >>> >> >>> >> >> On demand result set on scrolling... OK. >>> >> >>> >> >> On demand result set on grid select all... OK. >>> >> >>> >> >> On demand result set on column select all... OK. >>> >> >>> >> >> Explain query... OK. >>> >> >>> >> >> Explain query with verbose... OK. >>> >> >>> >> >> Explain query with costs... OK. >>> >> >>> >> >> Explain analyze query... OK. >>> >> >>> >> >> Explain analyze query with buffers... OK. >>> >> >>> >> >> Explain analyze query with timing... OK. >>> >> >>> >> >> Auto commit disabled... OK. >>> >> >>> >> >> Auto commit enabled... OK. >>> >> >>> >> >> Auto rollback enabled... ERROR >>> >> >>> >> >> -------- >>> >> >>> >> >> >>> >> >>> >> > Fixed. >>> >> >>> >> > >>> >> >>> >> > >>> >> >>> >> >> >>> >> >>> >> >> Thanks! >>> >> >>> >> >> >>> >> >>> >> >> -- >>> >> >>> >> >> Dave Page >>> >> >>> >> >> Blog: http://pgsnake.blogspot.com >>> >> >>> >> >> Twitter: @pgsnake >>> >> >>> >> >> >>> >> >>> >> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> >>> >> >> The Enterprise PostgreSQL Company >>> >> >>> >> > >>> >> >>> >> > >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> -- >>> >> >>> >> Dave Page >>> >> >>> >> Blog: http://pgsnake.blogspot.com >>> >> >>> >> Twitter: @pgsnake >>> >> >>> >> >>> >> >>> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> >>> >> The Enterprise PostgreSQL Company >>> >> >>> > >>> >> >>> > >>> >> >>> >>> >> >>> >>> >> >>> >>> >> >>> -- >>> >> >>> Dave Page >>> >> >>> Blog: http://pgsnake.blogspot.com >>> >> >>> Twitter: @pgsnake >>> >> >>> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> >> >>> The Enterprise PostgreSQL Company >>> >> >> >>> >> >> >>> >> > >>> >> > >>> >> > >>> >> > -- >>> >> > Dave Page >>> >> > Blog: http://pgsnake.blogspot.com >>> >> > Twitter: @pgsnake >>> >> > >>> >> > EnterpriseDB UK: http://www.enterprisedb.com >>> >> > The Enterprise PostgreSQL Company >>> >> >>> >> >>> >> >>> >> -- >>> >> Dave Page >>> >> Blog: http://pgsnake.blogspot.com >>> >> Twitter: @pgsnake >>> >> >>> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> The Enterprise PostgreSQL Company >>> > >>> > >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113ce08232cb1b0552f36209 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On 27 Jun 2017 18:33, "Dave Page" <dpage@pgadmin.org> wrote:
Thanks - patch committed!
<= br>
Awsome job :-)
Gr8. Finally no more rebase request for Harshal. :)
On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
=
Hi,

Plea= se find rebased patch.

--=C2=A0
= Harshal Dhumal
Sr. Software Engineer

=
Ente= rpriseDB India:=C2=A0http://www.ent= erprisedb.com
The Enterprise Pos= tgreSQL Company
<= /div>

On Mon, Jun 26, 2017 at 5:24 PM, Harshal Dhumal &l= t;hars= hal.dhumal@enterprisedb.com> wrote:
yes i'm working on that only :)

=

--=C2=A0
H= arshal Dhumal
Sr. Software Engineer

<= /b>
Enter= priseDB India:=C2=A0http://www.ent= erprisedb.com
The Enterprise Pos= tgreSQL Company
<= /div>

On Mon, Jun 26, 2017 at 5:22 PM, Dave Page <d= page@pgadmin.org> wrote:
I&= #39;m sorry, it needs rebasing again. If you can do it quickly, I'll make sure it's the next patch I work on in that area.

Thanks.

On Mon, Jun 26, 2017 at 5:16 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated rebased patch for RM2137
>
> On Fri, Jun 23, 2017 at 9:00 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi Harshal,
>>
>> When can we expect an updated version of this patch? I think it= 9;s
>> important to get this into the next release.
>>
>> Thanks!
>>
>> On Fri, Jun 16, 2017 at 10:55 AM, Dave Page <dpage@pgadmin.org> wrote:
>> > Hi,
>> >
>> > That's better - the failures are far less random now :-).= I got the
>> > following two though, on both PG and EPAS 9.5:
>> >
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
>> > ERROR: runTest
>> > (pgadmin.feature_tests.query_tool_tests.QueryToolFeature= Test)
>> > Query tool feature test
>> > --------------------------------------------------------= --------------
>> > Traceback (most recent call last):
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/query_tool_tests.py",
>> > line 95, in runTest
>> >=C2=A0 =C2=A0 =C2=A0self._query_tool_explain_analyze_buff= ers()
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/query_tool_tests.py",
>> > line 443, in _query_tool_explain_analyze_buffers
>> >=C2=A0 =C2=A0 =C2=A0canvas.find_element_by_xpath("//= *[contains(string(), 'Shared Read
>> > Blocks')]")
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webelement.py",
>> > line 260, in find_element_by_xpath
>> >=C2=A0 =C2=A0 =C2=A0return self.find_element(by=3DBy.XPATH, va= lue=3Dxpath)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webelement.py",
>> > line 508, in find_element
>> >=C2=A0 =C2=A0 =C2=A0{"using": by, "value":= value})['value']
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webelement.py",
>> > line 491, in _execute
>> >=C2=A0 =C2=A0 =C2=A0return self._parent.execute(command, param= s)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webdriver.py",
>> > line 238, in execute
>> >=C2=A0 =C2=A0 =C2=A0self.error_handler.check_response(res= ponse)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/errorhandler.py",
>> > line 193, in check_response
>> >=C2=A0 =C2=A0 =C2=A0raise exception_class(message, screen, sta= cktrace)
>> > NoSuchElementException: Message: no such element: Unable to l= ocate
>> > element: {"method":"xpath","selector= ":"//*[contains(string(), 'Shared
>> > Read Blocks')]"}
>> >=C2=A0 =C2=A0(Session info: chrome=3D58.0.3029.110)
>> >=C2=A0 =C2=A0(Driver info: chromedriver=3D2.29.461585
>> > (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=3DMa= c OS X 10.12.3
>> > x86_64)
>> >
>> >
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
>> > ERROR: runTest
>> > (pgadmin.feature_tests.view_data_dml_queries.CheckForVie= wDataTest)
>> > Validate Insert, Update operations in View data with given te= st data
>> > --------------------------------------------------------= --------------
>> > Traceback (most recent call last):
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/view_data_dml_queries.py",
>> > line 104, in runTest
>> >=C2=A0 =C2=A0 =C2=A0self._add_row()
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/view_data_dml_queries.py",
>> > line 255, in _add_row
>> >=C2=A0 =C2=A0 =C2=A0self._update_cell(cell_xpath, config_data[= str(idx)])
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/view_data_dml_queries.py",
>> > line 164, in _update_cell
>> >=C2=A0 =C2=A0 =C2=A0cell_el =3D self.page.find_by_xpath(xpath)=
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/regression/feature_u= tils/pgadmin_page.py",
>> > line 122, in find_by_xpath
>> >=C2=A0 =C2=A0 =C2=A0return self.wait_for_element(lambda driver= :
>> > driver.find_element_by_xpath(xpath))
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/regression/feature_u= tils/pgadmin_page.py",
>> > line 205, in wait_for_element
>> >=C2=A0 =C2=A0 =C2=A0return self._wait_for("element to exi= st", element_if_it_exists)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/regression/feature_u= tils/pgadmin_page.py",
>> > line 255, in _wait_for
>> >=C2=A0 =C2=A0 =C2=A0"Timed out waiting for " + waiti= ng_for_message)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/support/wait.py",
>> > line 71, in until
>> >=C2=A0 =C2=A0 =C2=A0value =3D method(self._driver)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/regression/feature_u= tils/pgadmin_page.py",
>> > line 200, in element_if_it_exists
>> >=C2=A0 =C2=A0 =C2=A0if element.is_displayed() and element.is_e= nabled():
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webelement.py",
>> > line 358, in is_displayed
>> >=C2=A0 =C2=A0 =C2=A0return self._execute(Command.IS_ELEME= NT_DISPLAYED)['value']
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webelement.py",
>> > line 491, in _execute
>> >=C2=A0 =C2=A0 =C2=A0return self._parent.execute(command, param= s)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/webdriver.py",
>> > line 238, in execute
>> >=C2=A0 =C2=A0 =C2=A0self.error_handler.check_response(res= ponse)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/s= ite-packages/selenium/webdriver/remote/errorhandler.py",
>> > line 193, in check_response
>> >=C2=A0 =C2=A0 =C2=A0raise exception_class(message, screen, sta= cktrace)
>> > StaleElementReferenceException: Message: stale element r= eference:
>> > element is not attached to the page document
>> >=C2=A0 =C2=A0(Session info: chrome=3D58.0.3029.110)
>> >=C2=A0 =C2=A0(Driver info: chromedriver=3D2.29.461585
>> > (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=3DMa= c OS X 10.12.3
>> > x86_64)
>> >
>
>
> I checked my feature test cases for any database server version/type (= PG,
> EPAS) specific failures and I found that test cases are working fine o= n all
> of them. However I have slightly modified test case to overcome above<= br> > mentioned failures.
>
>>
>> >
>> > On 9.4 everything passes. On 9.6, I get one failure:
>> >
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
>> > FAIL: runTest
>> > (pgadmin.feature_tests.view_data_dml_queries.CheckForVie= wDataTest)
>> > Validate Insert, Update operations in View data with given te= st data
>> > --------------------------------------------------------= --------------
>> > Traceback (most recent call last):
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/view_data_dml_queries.py",
>> > line 105, in runTest
>> >=C2=A0 =C2=A0 =C2=A0self._verify_row_data(True)
>> >=C2=A0 =C2=A0File
>> > "/Users/dpage/git/pgadmin4/web/pgadmin/feature_test= s/view_data_dml_queries.py",
>> > line 282, in _verify_row_data
>> >=C2=A0 =C2=A0 =C2=A0self.assertEquals(cells[idx], config_data[= str(idx)][1])
>> > AssertionError: u'[default]' !=3D u'1'
>> > - [default]
>> > + 1
>> >
>
> I guess Khushboo has fixed this recently.
>
>
>>
>> > Screenshots attached.
>> >
>> > On Fri, Jun 16, 2017 at 7:54 AM, Harshal Dhumal
>> > <harshal.dhumal@enterprisedb.com> wrote:
>> >> Hi Dave,
>> >>
>> >> Please find attached patch where I have added timeout of = 2 seconds
>> >> before
>> >> selecting object menu in connect to server function.
>> >>
>> >> Note: Apply this patch on top of previous patch for on de= mand loading
>> >> feature.
>> >>
>> >>
>> >> --
>> >> Harshal Dhumal
>> >> Sr. Software Engineer
>> >>
>> >> EnterpriseDB India: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> On Fri, Jun 16, 2017 at 2:25 AM, Dave Page <dpage@pgadmin.org> wrot= e:
>> >>>
>> >>> Sounds good, thanks.
>> >>>
>> >>> On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal
>> >>> <harshal.dhumal@enterprisedb.com> wrote:
>> >>> > Hi
>> >>> >
>> >>> > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page <<= a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.org= >
>> >>> > wrote:
>> >>> >>
>> >>> >> Hi
>> >>> >>
>> >>> >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhu= mal
>> >>> >> <harshal.dhumal@enterprisedb.com> w= rote:
>> >>> >> > Hi Dave,
>> >>> >> >
>> >>> >> > Please find attached updated patch.
>> >>> >> >
>> >>> >> > On Thu, Jun 15, 2017 at 3:58 PM, Dave P= age <dpage@pgadmi= n.org>
>> >>> >> > wrote:
>> >>> >> >>
>> >>> >> >> Hi
>> >>> >> >>
>> >>> >> >> On Wed, Jun 14, 2017 at 11:36 PM, H= arshal Dhumal
>> >>> >> >> <harshal.dhumal@enterprisedb.com<= /a>> wrote:
>> >>> >> >>>
>> >>> >> >>> Hi Dave,
>> >>> >> >>>
>> >>> >> >>> Please find rebased patch for R= M2137.
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> Looking very good. The only issues = I see are:
>> >>> >> >>
>> >>> >> >> - The row headers should auto-size = such that they can display
>> >>> >> >> the
>> >>> >> >> row
>> >>> >> >> numbers if the last row was display= ed. E.g. if there are 12345
>> >>> >> >> rows
>> >>> >> >> in
>> >>> >> >> total, then the row header should b= e sized to display 5 digits.
>> >>> >> >>
>> >>> >> > Fixed.
>> >>> >> >
>> >>> >> >
>> >>> >> >>
>> >>> >> >> - The tests are comprehensive, whic= h is awesome. However, every
>> >>> >> >> time
>> >>> >> >> I
>> >>> >> >> ran
>> >>> >> >> them, at least one of the feature t= ests failed. Unfortunately,
>> >>> >> >> it
>> >>> >> >> was a
>> >>> >> >> different one each time. In the las= t two runs, I got:
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> >>> >> >> ERROR: runTest
>> >>> >> >> (pgadmin.feature_tests.query_t= ool_tests.QueryToolFeatureTest)
>> >>> >> >> Query tool feature test
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> ------------------------------= ----------------------------------------
>> >>> >> >> Traceback (most recent call last):<= br> >> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/git/pgadmin4/web= /regression/feature_utils/base_feature_test.py",
>> >>> >> >> line 40, in setUp
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0self.before() >> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/git/pgadmin4/web= /pgadmin/feature_tests/query_tool_tests.py",
>> >>> >> >> line 40, in before
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0self._connects_t= o_server()
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/git/pgadmin4/web= /pgadmin/feature_tests/query_tool_tests.py",
>> >>> >> >> line 144, in _connects_to_server >> >>> >> >>=C2=A0 =C2=A0 =C2=A0self.page.driver= .find_element_by_link_text("Create"))\
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= webdriver.py",
>> >>> >> >> line 319, in find_element_by_link_t= ext
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0return self.find= _element(by=3DBy.LINK_TEXT, value=3Dlink_text)
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= webdriver.py",
>> >>> >> >> line 756, in find_element
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0'value':= value})['value']
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= webdriver.py",
>> >>> >> >> line 238, in execute
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0self.error_handl= er.check_response(response)
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= errorhandler.py",
>> >>> >> >> line 193, in check_response
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0raise exception_= class(message, screen, stacktrace)
>> >>> >> >> NoSuchElementException: Message: no= such element: Unable to
>> >>> >> >> locate
>> >>> >> >> element: {"method":"= link text","selector":"Create"}
>> >>> >> >>=C2=A0 =C2=A0(Session info: chrome= =3D58.0.3029.110)
>> >>> >> >>=C2=A0 =C2=A0(Driver info: chromedri= ver=3D2.29.461585
>> >>> >> >> (0be2cd95f834e9ee7c46bcc7cf405= b483f5ae83b),platform=3DMac OS X
>> >>> >> >> 10.12.3
>> >>> >> >> x86_64)
>> >>> >> >>
>> >>> >> > I checked code from _connects_to_server= function which is common
>> >>> >> > in
>> >>> >> > all
>> >>> >> > features test cases. I didn't find = anything wrong with this. If
>> >>> >> > there
>> >>> >> > is
>> >>> >> > a
>> >>> >> > bug in this function then all feature t= est must fail.
>> >>> >> > Let me know if you are getting failure = consistently in
>> >>> >> > _connects_to_server
>> >>> >> > function.
>> >>> >>
>> >>> >> I wondered if that one is a race condition. = Do we need a short
>> >>> >> delay
>> >>> >> before clicking the Object menu? I have seen= this occasionally
>> >>> >> before.
>> >>> >
>> >>> >
>> >>> > OK. In that case let's try putting 1-2 secon= d delay and observer
>> >>> > behaviour.
>> >>> > I'll send separate patch for this tomorrow a= s this is not related to
>> >>> > on
>> >>> > demand query result feature or its test cases. >> >>> >
>> >>> >>
>> >>> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> >>> >> >> ERROR: runTest
>> >>> >> >> (pgadmin.feature_tests.query_t= ool_tests.QueryToolFeatureTest)
>> >>> >> >> Query tool feature test
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> ------------------------------= ----------------------------------------
>> >>> >> >> Traceback (most recent call last):<= br> >> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/git/pgadmin4/web= /pgadmin/feature_tests/query_tool_tests.py",
>> >>> >> >> line 119, in runTest
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0self._query_tool= _auto_rollback_enabled()
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/git/pgadmin4/web= /pgadmin/feature_tests/query_tool_tests.py",
>> >>> >> >> line 697, in _query_tool_auto_rollb= ack_enabled
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0'//div[conta= ins(@class, "sql-editor-message") and
>> >>> >> >> contains(string(),
>> >>> >> >> "COMMIT")]'
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= webdriver.py",
>> >>> >> >> line 295, in find_element_by_xpath<= br> >> >>> >> >>=C2=A0 =C2=A0 =C2=A0return self.find= _element(by=3DBy.XPATH, value=3Dxpath)
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= webdriver.py",
>> >>> >> >> line 756, in find_element
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0'value':= value})['value']
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= webdriver.py",
>> >>> >> >> line 238, in execute
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0self.error_handl= er.check_response(response)
>> >>> >> >>=C2=A0 =C2=A0File
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> "/Users/dpage/.virtualenvs/pga= dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/= errorhandler.py",
>> >>> >> >> line 193, in check_response
>> >>> >> >>=C2=A0 =C2=A0 =C2=A0raise exception_= class(message, screen, stacktrace)
>> >>> >> >> NoSuchElementException: Message: no= such element: Unable to
>> >>> >> >> locate
>> >>> >> >> element: {"method":"= xpath","selector":"//div[contains(@class,
>> >>> >> >> "sql-editor-message") and= contains(string(), "COMMIT")]"}
>> >>> >> >>=C2=A0 =C2=A0(Session info: chrome= =3D58.0.3029.110)
>> >>> >> >>=C2=A0 =C2=A0(Driver info: chromedri= ver=3D2.29.461585
>> >>> >> >> (0be2cd95f834e9ee7c46bcc7cf405= b483f5ae83b),platform=3DMac OS X
>> >>> >> >> 10.12.3
>> >>> >> >> x86_64)
>> >>> >> >>
>> >>> >> > I have updated Auto rollback enabled te= st in this patch.
>> >>> >> >
>> >>> >> >>
>> >>> >> >> Relevant screenshots attached.
>> >>> >> >>
>> >>> >> >> - Can you tidy up the regression ou= tput a little please? Instead
>> >>> >> >> of:
>> >>> >> >>
>> >>> >> >> -------
>> >>> >> >> runTest
>> >>> >> >> (pgadmin.feature_tests.query_t= ool_tests.QueryToolFeatureTest)
>> >>> >> >> Query tool feature test ... On dema= nd result set on scrolling...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> On demand result set on grid select= all...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> On demand result set on column sele= ct all...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Explain query...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Explain query with verbose...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Explain query with costs...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Explain analyze query...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Explain analyze query with buffers.= ..
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Explain analyze query with timing..= .
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Auto commit disabled...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Auto commit enabled...
>> >>> >> >> OK.
>> >>> >> >>
>> >>> >> >> Auto rollback enabled...
>> >>> >> >> ERROR
>> >>> >> >> -------
>> >>> >> >>
>> >>> >> >> Something like:
>> >>> >> >>
>> >>> >> >> -------
>> >>> >> >> runTest
>> >>> >> >> (pgadmin.feature_tests.query_t= ool_tests.QueryToolFeatureTest)
>> >>> >> >> Query tool feature test ...
>> >>> >> >> On demand result set on scrolling..= . OK.
>> >>> >> >> On demand result set on grid select= all... OK.
>> >>> >> >> On demand result set on column sele= ct all... OK.
>> >>> >> >> Explain query... OK.
>> >>> >> >> Explain query with verbose... OK. >> >>> >> >> Explain query with costs... OK.
>> >>> >> >> Explain analyze query... OK.
>> >>> >> >> Explain analyze query with buffers.= .. OK.
>> >>> >> >> Explain analyze query with timing..= . OK.
>> >>> >> >> Auto commit disabled... OK.
>> >>> >> >> Auto commit enabled... OK.
>> >>> >> >> Auto rollback enabled... ERROR
>> >>> >> >> --------
>> >>> >> >>
>> >>> >> > Fixed.
>> >>> >> >
>> >>> >> >
>> >>> >> >>
>> >>> >> >> Thanks!
>> >>> >> >>
>> >>> >> >> --
>> >>> >> >> Dave Page
>> >>> >> >> Blog: http://pgsnake.blogspot.com=
>> >>> >> >> Twitter: @pgsnake
>> >>> >> >>
>> >>> >> >> EnterpriseDB UK: http://www.enter= prisedb.com
>> >>> >> >> The Enterprise PostgreSQL Company >> >>> >> >
>> >>> >> >
>> >>> >>
>> >>> >>
>> >>> >>
>> >>> >> --
>> >>> >> Dave Page
>> >>> >> Blog: http://pgsnake.blogspot.com
>> >>> >> Twitter: @pgsnake
>> >>> >>
>> >>> >> EnterpriseDB UK: http://www.enterprisedb.c= om
>> >>> >> The Enterprise PostgreSQL Company
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company

--001a113ce08232cb1b0552f36209--