Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJDwU-00071P-UM for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Mar 2021 11:20:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDwT-0003sc-6C for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Mar 2021 11:20:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJDwS-0003sV-T8 for pgadmin-hackers@lists.postgresql.org; Mon, 08 Mar 2021 11:20:53 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJDwP-0004kV-Vd for pgadmin-hackers@postgresql.org; Mon, 08 Mar 2021 11:20:51 +0000 Received: by mail-lf1-x12b.google.com with SMTP id k9so20363100lfo.12 for ; Mon, 08 Mar 2021 03:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OI4VCnm9xIqSe8Q5Z0jLvVrPTY3rfu0l9nzhjjoXBdE=; b=kfXZvzgeXCre7QRCdfnmCbsx7sYKj8HrgbfO1Rz3NkVhzJqg+CWESEWIOmJgts6wjU 4Vk0WlJszJt5n8+mmwyWV+FmpJvjkgQkB3aBD/jGuGDBccPZ6GVrP53wZGhb/dmqr5lt V8blBl4aL3spt7GF5QUbExOFclqxtHb0e9/XSFS1dGXf7ZrTnbGa7TA2TmfXPAEzMjFP qW8YrVlz+D6jdBcNX4/JZWJsfrIxMvcbLpE+70bpuGxNNGv0WPFyjz0WKKOcFwQZOKMY mMQPbwqlfefz+movR6PVXGGyjh/ThNTtGco4A5ITJwFeEWbVowY9cRRrxPzWv/URwSQW JY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OI4VCnm9xIqSe8Q5Z0jLvVrPTY3rfu0l9nzhjjoXBdE=; b=uMJq/67uBzdVaUsgjeQKnpVLfXhd/YnmaS2KVSihjcTyWXmBnyqAxFM0E3+54Q3Djs 7d0jV0W+bcxmR5MGUQy12CdFyZx/ioZ8iMjmT8KF8u20lQYPYsCxpxo/rijy8qPZyVE3 9QQ+CaQvg/vjc6CBERC37b+ooarVfi81r50u8t1i1O3U6+vqpV0YtMT1A/siLi+YJFi5 2uR/0g1a58YolG/3Jb96vVgF1/VliY6rGySfdIsgN0ttEJvk3il51DoJHagcDRaG+n4P rXAo/+RDC7CIrJQu5OGvVRvQOWB/4gnNSIImosN+5JFNmFUdzpbrvSygykUXchSjKe6E VnYQ== X-Gm-Message-State: AOAM532LG1oQw9K8pj76jyef2wxVsnM2grf05QqME1zYv3vNphh2EETk 6O/+bGt+0V1GjcPz9RFCx/FTPHqCONSi7Uv7tZtv5g6TWIwc4rVOhK4yDSzdQQKIkPgvuwDbSbB qGHiuIRIVek6+dpFIF8WNuXro+8tbnfUVRK+SzCow2ZaTi75WGvihUrvOJXTC0hBNBNYZlswcdW 11MpdRyo5TedcpOrSC6rqpbHutQzZxZHlV8uaL9Vs7zAG0uQYQA+LdjgBw4Q== X-Google-Smtp-Source: ABdhPJzI8p5cWIrfmPtK82ltUIOwaaXFXpXLwD9hbSI0HQ3jKWuaI3NPU2HJyqz5WUsVZE+wHhlkOJfuus4jihKCpfk= X-Received: by 2002:a05:6512:6d6:: with SMTP id u22mr15072474lff.454.1615202448081; Mon, 08 Mar 2021 03:20:48 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Mon, 8 Mar 2021 16:50:49 +0530 Message-ID: Subject: Re: Making Kerberos optional in the Python wheel To: Dave Page Cc: pgadmin-hackers , Shaheed Haque Content-Type: multipart/alternative; boundary="00000000000028995305bd04a076" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000028995305bd04a076 Content-Type: text/plain; charset="UTF-8" Hi Dave, The patch looks good to me. Thanks, Khushboo On Mon, Mar 8, 2021 at 4:42 PM Dave Page wrote: > Has anyone been able to review this? > > On Thu, Mar 4, 2021 at 10:02 AM Dave Page wrote: > >> There have been a couple of complaints that the latest Python wheel >> distribution doesn't install cleanly. This happens when there is no >> pre-built gssapi wheel on PyPi that matches the users combination of Python >> version and platform, *and* the MIT Kerberos development headers etc. are >> not present on the system, so the source wheel cannot be compiled. >> >> This seems like it's a bit onerous on users, especially if they're on >> Windows where they'll also need a suitable compiler to be installed. The >> attached patch aims to address that by making the Kerberos support optional >> (thankfully, Khushboo made the code handle lack of gssapi libraries). >> >> To install without gssapi, users would simply do: >> >> pip install pgadmin4 >> >> or >> >> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl >> >> To install with gssapi: >> >> pip install pgadmin4['kerberos'] >> >> or >> >> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos'] >> >> The patch also cleans up some old cruft that was required for now >> unsupported Python versions. >> >> Thoughts? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > --00000000000028995305bd04a076 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

The patch looks good to me.=C2= =A0

Thanks,
Khushboo

On Mon, Mar 8,= 2021 at 4:42 PM Dave Page <dpage@p= gadmin.org> wrote:
Has anyone been able to review this?

<= div class=3D"gmail_quote">
On Thu, Mar= 4, 2021 at 10:02 AM Dave Page <dpage@pgadmin.org> wrote:
There have been a couple = of complaints that the latest Python wheel distribution doesn't install= cleanly. This happens when there is no pre-built gssapi wheel=C2=A0on PyPi= that matches the users combination of Python version and platform, *and* t= he MIT Kerberos development headers etc. are not present on the system, so = the source wheel cannot be compiled.

This seems like it&= #39;s a bit onerous=C2=A0on users, especially if they're on Windows whe= re they'll also need a suitable compiler to be installed. The attached = patch aims to address that by making the Kerberos support optional (thankfu= lly, Khushboo made the code handle lack of gssapi libraries).
To install without gssapi, users would simply do:
pip install pgadmin4

or=C2=A0

pip install=C2=A0pip install /path/to/pgadmin4-5.0-py3-non= e-any.whl

To install with gssapi:

pip install pgadmin4['kerberos']

=
or=C2=A0

pip install=C2=A0pip install /path/t= o/pgadmin4-5.0-py3-none-any.whl['kerberos']

The patch also cleans up some old cruft that was required for now unsuppo= rted Python versions.

Thoughts?
=


--
--00000000000028995305bd04a076--