Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYOgt-001a9K-Cw for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Aug 2023 10:32:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qYOgr-00HV88-Sv for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Aug 2023 10:32:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYOgr-00HV7y-Fz for pgadmin-hackers@lists.postgresql.org; Tue, 22 Aug 2023 10:32:49 +0000 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qYOgi-000K00-Os for pgadmin-hackers@postgresql.org; Tue, 22 Aug 2023 10:32:47 +0000 Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-d776e1f181bso1126119276.3 for ; Tue, 22 Aug 2023 03:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1692700360; x=1693305160; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3HGsz7uG/JVyXTXukaHNYT8nbpckckJh7uUaFxZYWAQ=; b=jU4qz5RPjiC+qagkovlzHwIHxzPCxkyzPC9JGFc5XCAgxbaC5dARytEsyEhq3yAYug 8+WcVX6z8u4IZkOymG3JU/kpNqz4PREOc4smgg1FeAIavJgpkZhzqWH35sD8ho7I/agU FoOp87r7QhnZTkjAe8Y/MGb7c9tC09qXo8NgxzW1LvxFs/MW/gCwXqH8FehsMHHPAKfW EKFkXr2Xq+Fx7prSrjOthDUovW6EvDEzFsPmTvt1RSTrGyOXQlgsOHv5go5rMnFdBCHB 8QP35FSJmQzCQZKAEEhq9vnku/s4NZ45y8r1mAPWaKiLovyEcGWYwbQPjBuLy/9xoveh 2IFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692700360; x=1693305160; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3HGsz7uG/JVyXTXukaHNYT8nbpckckJh7uUaFxZYWAQ=; b=SR5qB7UJRa9ADLdRl0m5dBaadijps+iNkmcqtI9L+b0KoCfQw1S5zjnCYp+OU4ExYH 6QqqjRwWu2XAThVE7c+paViZ2ySEr6sHjytmbL0jmzXDO+dyR1FgNQMESHPl/SBdrTbk I1RuepWALrD/J2vUGBVlI6TRRM91/BW3+h4wiLxyCOJjM88QyrWz76Ze7C0ylqWRMNQH q0UqFN/C45sC1buS/u6svlCOre8DcPJIPbhL+1TWVoj7XfDQuTl96hUpJqs1GITNiKFy cr/HAjo1CnGPUPdXcrLm6LAb83yNZsZ4f9Y5u7Eu5hpq1hSntMv4ZRUwiUuOaxbtoWJO /zlw== X-Gm-Message-State: AOJu0YzB4RxXP4xo0v/yf0I6S8WBpbdwQI4DsCmLXl45Qndsct1a3zhT zeQBo+mTc99LuP52x8zRzStU4rNR47aDnQdIdk7oLA== X-Google-Smtp-Source: AGHT+IHQFh974Ncv8dOmmuDgImXgyAduiW1jB7IS0+7eOQA7+MaPknNbYpisAwJTBJagFb3ZGN+mobym0KHE1XXxI/g= X-Received: by 2002:a25:d4c1:0:b0:d15:9cdc:5d0c with SMTP id m184-20020a25d4c1000000b00d159cdc5d0cmr9418173ybf.42.1692700359723; Tue, 22 Aug 2023 03:32:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 22 Aug 2023 16:02:28 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Sahil Harpal Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000a720b90603808314" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000a720b90603808314 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sahil, On Tue, Aug 22, 2023 at 1:19=E2=80=AFPM Sahil Harpal wrote: > Hello Khushboo, > > Thank you for sharing this with me. As you can see, towards the end, when > you encountered the tooltip issue, the size of the graph container was > changing. I even found this bug in the actual pgAdmin4 application > installed on my system. Please see the attached video. > > Here's what I believe is happening: When the container's size changes, it > seems that tooltips continue to accumulate without being properly removed= . > The method we use to display tooltips involves inserting a new element > into the DOM with the class name "uplot-tooltip". So, if we remove all th= e > existing tooltip elements before inserting a new one, it could potentiall= y > resolve the issue. Would like to know your thoughts on this. > > It would be good if you fix this issue as you already investigated and found the root cause. But if you have other things to complete as the deadline is approaching you can create this issue at pgAdmin repo as it is an existing one. Thanks, Khushboo > Thank you, > Sahil > > On Mon, 21 Aug 2023 at 11:11, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> See the attachment. >> >> On Mon, Aug 21, 2023 at 10:51=E2=80=AFAM Sahil Harpal >> wrote: >> >>> pgAdmin4-cursor-rec.mp4 >>> >>> Hi Khushboo, >>> On Mon, 21 Aug 2023 at 09:55, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> On Fri, Aug 18, 2023 at 10:08=E2=80=AFAM Sahil Harpal < >>>> sahilharpal1234@gmail.com> wrote: >>>> >>>>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> - The Tooltip for graph points remains on the page. Please refer >>>>>> to the below screenshot. >>>>>> >>>>>> Is this happening simply by moving the cursor within the graph area >>>>> or when resizing the screen? >>>>> >>>> This is happening by simply moving the cursor across the graphs on eac= h >>>> tab. Maybe you can try to reduce the graph refresh rate to 1 second an= d try. >>>> >>> >>> I'm unable to reproduce the issue even after modifying the refresh rate >>> to 1 second. I have attached a screen recording to illustrate how it is >>> functioning on my end. >>> Do you have any thoughts on why the cursor issue might be happening? >>> >> --000000000000a720b90603808314 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Sahil,

On Tue, Aug 22, 2023 at 1:19=E2=80=AFPM Sahi= l Harpal <sahilharpal1234@g= mail.com> wrote:
Hello Khushboo,

Thank= you for sharing this with me. As you can see, towards the end, when you en= countered the tooltip issue, the size of the graph container was changing. = I even found this bug in the actual pgAdmin4 application installed on my sy= stem. Please see the attached video.

Here's what I believe is ha= ppening: When the container's size changes, it seems that tooltips cont= inue to accumulate without being properly removed.
The method we use to = display tooltips involves inserting a new element into the DOM with the cla= ss name "uplot-tooltip". So, if we remove all the existing toolti= p elements before inserting a new one, it could potentially resolve the iss= ue. Would like to know your thoughts on this.

It would be good if you fix this issue as you already investi= gated and found the root cause. But if you have other things to complete as= the deadline is approaching you can create this issue at pgAdmin repo as i= t is an existing one.

Thanks,
Khushboo
Thank you,
Sahil

3D""
On Mon, 21 Aug= 2023 at 11:11, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:=
See the attachment.

On Mon, Aug 21, 2023 at 10:51=E2=80=AFAM Sahil Harpal = <sahilhar= pal1234@gmail.com> wrote:
=C2=A0pgAdmin4-cursor-rec.mp4
Hi Khushboo,
On Mon, 21 Aug 2023 at 09:55, Khushboo Vash= i <= khushboo.vashi@enterprisedb.com> wrote:
3D""

On Fri, Aug 18, 2023 at 10:08=E2=80=AFAM Sahil Harpal <sahilharpal1234@g= mail.com> wrote:
3D""
On Thu= , 17 Aug 2023 at 17:57, Khushboo Vashi <khushboo.vashi@enterprisedb.com>= ; wrote:
  • The Tooltip for graph points remains on the page. Please= refer to the below screenshot.=C2=A0
Is this happening simply by moving the cursor within the graph area or w= hen resizing the screen?
This is happening by si= mply moving the cursor across the graphs on each tab. Maybe you can try to = reduce the graph refresh rate to 1 second and try.

I'm unable to reproduce the issue even after = modifying the refresh rate to 1 second. I have attached a screen recording = to illustrate how it is functioning on my end.
Do = you have any thoughts on why the cursor issue might be happening?
--000000000000a720b90603808314--