MIME-Version: 1.0
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Wed, 2 Mar 2022 17:34:37 +0530
Message-ID: 
 <CAFOhELdLHg8ybMq_bjg-meFWi_behBc3+DsLnFp+-_7M0_rKVw@mail.gmail.com>
Subject: [pgAdmin4][Patch] - Cloud Wizard fixes
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000009de48705d93b163f"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFOhELdLHg8ybMq_bjg-meFWi_behBc3%2BDsLnFp%2B-_7M0_rKVw%40mail.gmail.com>
Precedence: bulk

--0000000000009de48705d93b163f
Content-Type: multipart/alternative; boundary="0000000000009de48605d93b163d"

--0000000000009de48605d93b163d
Content-Type: text/plain; charset="UTF-8"

Hi,

Please find the attached patch to fix the below issues/suggestions:

- Mask the credentials input fields
- Loading symbol doesn't work while reloading the options in the select
control
- Decrease the wizard opening timeout
- Host IP fetch issue due to urllib library upgrade

Thanks,
Khushboo

--0000000000009de48605d93b163d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>Please find the attached patch to f=
ix the below issues/suggestions:</div><div><br></div><div>- Mask the creden=
tials input fields</div><div>- Loading symbol doesn&#39;t work while reload=
ing the options in the select control</div><div>- Decrease the wizard openi=
ng timeout</div><div>- Host IP fetch issue due to urllib library upgrade</d=
iv><div><br></div><div>Thanks,</div><div>Khushboo</div></div>

--0000000000009de48605d93b163d--

--0000000000009de48705d93b163f
Content-Type: application/octet-stream; name="cloud_aws_fixes.patch"
Content-Disposition: attachment; filename="cloud_aws_fixes.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_l09ietrj0>
X-Attachment-Id: f_l09ietrj0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FjbG91ZC91dGlscy9taXNjLnB5IGIvd2ViL3BnYWNsb3VkL3V0
aWxzL21pc2MucHkKaW5kZXggNWQ2NmYzNTRjLi5kZGJiZjA0Y2IgMTAwNjQ0Ci0tLSBhL3dlYi9w
Z2FjbG91ZC91dGlscy9taXNjLnB5CisrKyBiL3dlYi9wZ2FjbG91ZC91dGlscy9taXNjLnB5CkBA
IC0xNiwxNiArMTYsMTQgQEAgZGVmIGdldF9teV9pcCgpOgogICAgICIiIiBSZXR1cm4gdGhlIHB1
YmxpYyBJUCBvZiB0aGlzIGhvc3QgIiIiCiAgICAgaHR0cCA9IHVybGxpYjMuUG9vbE1hbmFnZXIo
KQogICAgIHRyeToKLSAgICAgICAgZXh0ZXJuYWxfaXAgPSBodHRwLnJlcXVlc3QudXJsb3BlbigK
LSAgICAgICAgICAgICdodHRwczovL2lkZW50Lm1lJykucmVhZCgpLmRlY29kZSgndXRmOCcpCisg
ICAgICAgIGV4dGVybmFsX2lwID0gaHR0cC5yZXF1ZXN0KCdHRVQnLCAnaHR0cHM6Ly9pZGVudC5t
ZScpLmRhdGEKICAgICBleGNlcHQgRXhjZXB0aW9uOgogICAgICAgICB0cnk6Ci0gICAgICAgICAg
ICBleHRlcm5hbF9pcCA9IGh0dHAucmVxdWVzdC51cmxvcGVuKAotICAgICAgICAgICAgICAgICdo
dHRwczovL2lmY29uZmlnLm1lL2lwJykucmVhZCgpLmRlY29kZSgndXRmOCcpCisgICAgICAgICAg
ICBleHRlcm5hbF9pcCA9IGh0dHAucmVxdWVzdCgnR0VUJywgJ2h0dHBzOi8vaWZjb25maWcubWUv
aXAnKS5kYXRhCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb246CiAgICAgICAgICAgICBleHRlcm5h
bF9pcCA9ICcxMjcuMC4wLjEnCiAKLSAgICByZXR1cm4gZXh0ZXJuYWxfaXAKKyAgICByZXR1cm4g
J3t9L3t9Jy5mb3JtYXQoZXh0ZXJuYWxfaXAsIDMyKQogCiAKIGRlZiBnZXRfcmFuZG9tX2lkKCk6
CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL19faW5pdF9fLnB5IGIvd2ViL3Bn
YWRtaW4vbWlzYy9jbG91ZC9fX2luaXRfXy5weQppbmRleCBiOTRmZDAxOGUuLmMwMzUwMjgxMyAx
MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vbWlzYy9jbG91ZC9fX2luaXRfXy5weQorKysgYi93ZWIv
cGdhZG1pbi9taXNjL2Nsb3VkL19faW5pdF9fLnB5CkBAIC0xMTQsNyArMTE0LDkgQEAgZGVmIHNj
cmlwdCgpOgogICAgICAgICAgICAgICAgICBtZXRob2RzPVsnR0VUJ10sIGVuZHBvaW50PSdnZXRf
aG9zdF9pcCcpCiBAbG9naW5fcmVxdWlyZWQKIGRlZiBnZXRfaG9zdF9pcCgpOgotICAgIHJldHVy
biBtYWtlX2pzb25fcmVzcG9uc2UoZGF0YT1nZXRfbXlfaXAoKSkKKyAgICAiIiJ0ZXN0IiIiCisg
ICAgaXAgPSBnZXRfbXlfaXAoKQorICAgIHJldHVybiBtYWtlX2pzb25fcmVzcG9uc2UoZGF0YT1p
cCkKIAogCiBAYmx1ZXByaW50LnJvdXRlKCcvdmVyaWZ5X2NyZWRlbnRpYWxzLycsCmRpZmYgLS1n
aXQgYS93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3N0YXRpYy9qcy9jbG91ZC5qcyBiL3dlYi9wZ2Fk
bWluL21pc2MvY2xvdWQvc3RhdGljL2pzL2Nsb3VkLmpzCmluZGV4IDQyMDBmMWRiOS4uYjU3MzM3
ZDg3IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3N0YXRpYy9qcy9jbG91ZC5q
cworKysgYi93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3N0YXRpYy9qcy9jbG91ZC5qcwpAQCAtMTI4
LDcgKzEyOCw3IEBAIGRlZmluZSgncGdhZG1pbi5taXNjLmNsb3VkJywgWwogICAgICAgICAgICAg
ICAgIHJldHVybiBzZXRUaW1lb3V0KChmdW5jdGlvbiAoKSB7CiAgICAgICAgICAgICAgICAgICBS
ZWFjdERPTS51bm1vdW50Q29tcG9uZW50QXROb2RlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdj
bG91ZFdpemFyZERsZycpKTsKICAgICAgICAgICAgICAgICAgIHJldHVybiBBbGVydGlmeS5jbG91
ZFdpemFyZERpYWxvZygpLmRlc3Ryb3koKTsKLSAgICAgICAgICAgICAgICB9KSwgNTAwKTsKKyAg
ICAgICAgICAgICAgICB9KSwgMTApOwogICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgfQog
ICAgICAgICAgIH07CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3N0YXRpYy9q
cy9jbG91ZF9kYl9kZXRhaWxzX3NjaGVtYS51aS5qcyBiL3dlYi9wZ2FkbWluL21pc2MvY2xvdWQv
c3RhdGljL2pzL2Nsb3VkX2RiX2RldGFpbHNfc2NoZW1hLnVpLmpzCmluZGV4IDFhNmI1MDk3My4u
NTkzZGViNjAxIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3N0YXRpYy9qcy9j
bG91ZF9kYl9kZXRhaWxzX3NjaGVtYS51aS5qcworKysgYi93ZWIvcGdhZG1pbi9taXNjL2Nsb3Vk
L3N0YXRpYy9qcy9jbG91ZF9kYl9kZXRhaWxzX3NjaGVtYS51aS5qcwpAQCAtODgsMTAgKzg4LDEw
IEBAIGNsYXNzIENsb3VkREJDcmVkU2NoZW1hIGV4dGVuZHMgQmFzZVVJU2NoZW1hIHsKICAgICAg
ICAgbm9FbXB0eTogdHJ1ZSwKICAgICAgICAgaGVscE1lc3NhZ2U6IGdldHRleHQoJ1RoZSBjbG91
ZCBpbnN0YW5jZSB3aWxsIGJlIGRlcGxveWVkIGluIHRoZSBzZWxlY3RlZCByZWdpb24uJykKICAg
ICAgIH0sewotICAgICAgICBpZDogJ2F3c19hY2Nlc3Nfa2V5JywgbGFiZWw6IGdldHRleHQoJ0FX
UyBhY2Nlc3Mga2V5JyksIHR5cGU6ICd0ZXh0JywKKyAgICAgICAgaWQ6ICdhd3NfYWNjZXNzX2tl
eScsIGxhYmVsOiBnZXR0ZXh0KCdBV1MgYWNjZXNzIGtleScpLCB0eXBlOiAncGFzc3dvcmQnLAog
ICAgICAgICBtb2RlOiBbJ2NyZWF0ZSddLCBub0VtcHR5OiB0cnVlLAogICAgICAgfSwgewotICAg
ICAgICBpZDogJ2F3c19zZWNyZXRfYWNjZXNzX2tleScsIGxhYmVsOiBnZXR0ZXh0KCdBV1Mgc2Vj
cmV0IGFjY2VzcyBrZXknKSwgdHlwZTogJ3RleHQnLAorICAgICAgICBpZDogJ2F3c19zZWNyZXRf
YWNjZXNzX2tleScsIGxhYmVsOiBnZXR0ZXh0KCdBV1Mgc2VjcmV0IGFjY2VzcyBrZXknKSwgdHlw
ZTogJ3Bhc3N3b3JkJywKICAgICAgICAgbW9kZTogWydjcmVhdGUnXSwgbm9FbXB0eTogdHJ1ZSwK
ICAgICAgIH0sIHsKICAgICAgICAgaWQ6ICdhd3Nfc2Vzc2lvbl90b2tlbicsIGxhYmVsOiBnZXR0
ZXh0KCdBV1Mgc2Vzc2lvbiB0b2tlbicpLCB0eXBlOiAnbXVsdGlsaW5lJywKQEAgLTIwNSw4ICsy
MDUsNyBAQCBleHBvcnQgY2xhc3MgSW5zdGFuY2VTY2hlbWEgZXh0ZW5kcyBCYXNlVUlTY2hlbWEg
ewogICAgICAgXSwgIG5vRW1wdHk6IHRydWUsIG9yaWVudGF0aW9uOiAndmVydGljYWwnLAogICAg
IH0sewogICAgICAgaWQ6ICdhd3NfaW5zdGFuY2VfdHlwZScsIGxhYmVsOiBnZXR0ZXh0KCdJbnN0
YW5jZSB0eXBlJyksCi0gICAgICBvcHRpb25zOiB0aGlzLmluc3RhbmNlT3B0cywgIG5vRW1wdHk6
IHRydWUsCi0gICAgICBjb250cm9sUHJvcHM6IHsgYWxsb3dDbGVhcjogZmFsc2UgfSwKKyAgICAg
IG9wdGlvbnM6IHRoaXMuaW5zdGFuY2VPcHRzLAogICAgICAgZGVwczogWydhd3NfZGJfdmVyc2lv
bicsICdhd3NfZGJfaW5zdGFuY2VfY2xhc3MnXSwKICAgICAgIGRlcENoYW5nZTogKHN0YXRlLCBz
b3VyY2UpPT4gewogICAgICAgICBpZiAoc291cmNlWzBdID09ICdhd3NfZGJfaW5zdGFuY2VfY2xh
c3MnKSB7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3V0aWxzL19faW5pdF9f
LnB5IGIvd2ViL3BnYWRtaW4vbWlzYy9jbG91ZC91dGlscy9fX2luaXRfXy5weQppbmRleCAwMGFj
OGZjZTguLmJhNGI3MzMzMSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vbWlzYy9jbG91ZC91dGls
cy9fX2luaXRfXy5weQorKysgYi93ZWIvcGdhZG1pbi9taXNjL2Nsb3VkL3V0aWxzL19faW5pdF9f
LnB5CkBAIC0xNCwxMyArMTQsMTEgQEAgZGVmIGdldF9teV9pcCgpOgogICAgICIiIiBSZXR1cm4g
dGhlIHB1YmxpYyBJUCBvZiB0aGlzIGhvc3QgIiIiCiAgICAgaHR0cCA9IHVybGxpYjMuUG9vbE1h
bmFnZXIoKQogICAgIHRyeToKLSAgICAgICAgZXh0ZXJuYWxfaXAgPSBodHRwLnJlcXVlc3QudXJs
b3BlbigKLSAgICAgICAgICAgICdodHRwczovL2lkZW50Lm1lJykucmVhZCgpLmRlY29kZSgndXRm
OCcpCisgICAgICAgIGV4dGVybmFsX2lwID0gaHR0cC5yZXF1ZXN0KCdHRVQnLCAnaHR0cHM6Ly9p
ZGVudC5tZScpLmRhdGEKICAgICBleGNlcHQgRXhjZXB0aW9uOgogICAgICAgICB0cnk6Ci0gICAg
ICAgICAgICBleHRlcm5hbF9pcCA9IGh0dHAucmVxdWVzdC51cmxvcGVuKAotICAgICAgICAgICAg
ICAgICdodHRwczovL2lmY29uZmlnLm1lL2lwJykucmVhZCgpLmRlY29kZSgndXRmOCcpCisgICAg
ICAgICAgICBleHRlcm5hbF9pcCA9IGh0dHAucmVxdWVzdCgnR0VUJywgJ2h0dHBzOi8vaWZjb25m
aWcubWUvaXAnKS5kYXRhCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb246CiAgICAgICAgICAgICBl
eHRlcm5hbF9pcCA9ICcxMjcuMC4wLjEnCiAKLSAgICByZXR1cm4gZXh0ZXJuYWxfaXAKKyAgICBy
ZXR1cm4gJ3t9L3t9Jy5mb3JtYXQoZXh0ZXJuYWxfaXAsIDMyKQpkaWZmIC0tZ2l0IGEvd2ViL3Bn
YWRtaW4vc3RhdGljL2pzL2NvbXBvbmVudHMvRm9ybUNvbXBvbmVudHMuanN4IGIvd2ViL3BnYWRt
aW4vc3RhdGljL2pzL2NvbXBvbmVudHMvRm9ybUNvbXBvbmVudHMuanN4CmluZGV4IGU5ZWRmZDAz
ZC4uY2RjZmFiNjQzIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvY29tcG9uZW50
cy9Gb3JtQ29tcG9uZW50cy5qc3gKKysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2NvbXBvbmVu
dHMvRm9ybUNvbXBvbmVudHMuanN4CkBAIC03NjIsNiArNzYyLDcgQEAgZXhwb3J0IGNvbnN0IElu
cHV0U2VsZWN0ID0gZm9yd2FyZFJlZigoewogICAgIGlmKHR5cGVvZiBvcHRpb25zID09PSAnZnVu
Y3Rpb24nKSB7CiAgICAgICBvcHRQcm9taXNlID0gb3B0aW9ucygpOwogICAgIH0KKyAgICBzZXRG
aW5hbE9wdGlvbnMoW1tdLCB0cnVlXSk7CiAgICAgUHJvbWlzZS5yZXNvbHZlKG9wdFByb21pc2Up
CiAgICAgICAudGhlbigocmVzKT0+ewogICAgICAgICAvKiBJZiBjb21wb25lbnQgdW5tb3VudGVk
LCBkb250IHVwZGF0ZSBzdGF0ZSAqLwo=
--0000000000009de48705d93b163f--