Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEq22-0001KB-7s for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 07:55:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEq21-0005lz-25 for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 07:55:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEq20-0005ls-Iv for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 07:55:56 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEq1u-000168-GT for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 07:55:55 +0000 Received: by mail-lf1-x12c.google.com with SMTP id t21so795997lfe.9 for ; Thu, 19 Mar 2020 00:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JAiOlhfD4Y2yAdY5oWE1twk8UIZyz1yNRIcBZkIbHxo=; b=YE3k6OHNwEnFEGllIinW/YZyCsSb5aLa4kKnGosfzBy/NUIPLh1LhGKxuX+KS+4I/T xM4OkhHYvpuzYTFTEpklApEi10oZ5xFwBLGItcBssWHxIt+nVRVHICcX99UQEg+Xtq7N cErnLcOOqrynON+/wZq+M8b2xmItOLob47YeNgi4G1Mywb5j90ilcjui5kIG+v7Z0/UM J+NGFWdrQ/mRVVRCf9lC5vqIeG8ynneLy9K5h28tmQVX3MbXbXiDZBs6aLAKz+SmrDzs pVddnS4gy5s9GPbIOumDHKDeMVXJrNIWEerclHLC4IKm/wrLYStqL45XrK3/Y307pvwe jAnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JAiOlhfD4Y2yAdY5oWE1twk8UIZyz1yNRIcBZkIbHxo=; b=jqlhQAMd9etYJrfpJhBH2RymF8bIfPsrvDMHJ4qJI5J79XocCg18qar4irRLw8Klbb 2XppOL6DHUeL/Krdg2hQRNja04JV2pTaUeMuTGcz6nNqfotfZj07uh+aIqX6IR3Uk1fp I1p30Jh5Htps1On8poTlNKc+S2ABDMxWXmwQXv5YC1YHJ7qSaTScmGcAFArBnyGbaP3B c+0pki6pVdYcvpCN/5fb5QfrqiagX3sPMY21CPgMPHHogAiHW8sZXiAqTDa08m7JfhJM L0V91bo3j3knkW9JKKS4zVchaDczwrGIjqfhdB/LSgV3HnnYHKlkahuw8OAKrqfFkZP7 BdPg== X-Gm-Message-State: ANhLgQ0WVnNjewFoNq9ZrbNCRAnAmX1wBNDkzxUACpi02Emt3Ux4/pkQ FTqUvtikcEB136PP3VVcSz/tCMw+vwhniN+zn1e9XhhR5cHEUT5KUAED3x/dYg2x4e8qHwYa2i/ 2wYwbw5DuZWLguTnDk1lu2fGuriGyS7lzj7jglkP956XisF59AGU/B/F08lzXNlRySxDRo4j7xw UXeMBz5Z0W0xPGG/DMJNN+qsA2N5HxBGKr6U/U1WMhhsv6t4vna1Y= X-Google-Smtp-Source: ADFU+vunf5uwytW/c5r/H1CXs0RDGY0fNXAjeHHrTsVfsEVfRLOYPpfuFY0IfMxodPBYxHENRJhwMyewMMeMzT7V8xQ= X-Received: by 2002:a19:484a:: with SMTP id v71mr1341865lfa.199.1584604548150; Thu, 19 Mar 2020 00:55:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Thu, 19 Mar 2020 13:25:40 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#5261] Support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Parsers To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000033ccc605a1307fe7" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000033ccc605a1307fe7 Content-Type: text/plain; charset="UTF-8" Hi Akshay, The patch looks good to me. Apart from this patch, I encountered below error. "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/schema_diff_utils.py", line 271, in get_sql_from_submodule_diff parent_target_data=target File "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/__init__.py", line 790, in ddl_compare target_data=parent_target_data) File "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", line 142, in wrap return f(*args, **kwargs) File "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/__init__.py", line 508, in get_sql_from_diff schema_diff=True) File "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", line 1369, in get_partitions_sql part_data['partition_scheme'] = self.get_partition_scheme(row) File "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", line 695, in get_partition_scheme for row in data[part_keys]: KeyError: 'partition_keys' Thanks, Khushboo On Wed, Mar 18, 2020 at 4:28 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to add support for Collation, FTS Templates, FTS > Dictionaries, FTS Configurations and FTS Parsers in Schema Diff Tool. > > The patch contains some minor fix where parameters are added in the > difference list even though it's size is zero. I have also added the test > cases. > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > --00000000000033ccc605a1307fe7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

The patch looks good to me.<= /div>

Apart from this patch, I encountered below error.<= /div>

"/Users/khushboovashi/Projects/pgadmin4= /web/pgadmin/browser/server_groups/servers/databases/schemas/tables/schema_= diff_utils.py", line 271, in get_sql_from_submodule_diff
=C2=A0 =C2=A0parent_target_data=3Dtarget
=C2=A0File &quo= t;/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/= servers/databases/schemas/tables/partitions/__init__.py", line 790, in= ddl_compare
=C2=A0 =C2=A0target_data=3Dparent_target_data)=
=C2=A0File "/Users/khushboovashi/Projects/pgadmin4/we= b/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py&q= uot;, line 142, in wrap
=C2=A0 =C2=A0return f(*args, **kwar= gs)
=C2=A0File "/Users/khushboovashi/Projects/pgadmin4= /web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partiti= ons/__init__.py", line 508, in get_sql_from_diff
=C2= =A0 =C2=A0schema_diff=3DTrue)
=C2=A0File "/Users/khush= boovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databa= ses/schemas/tables/utils.py", line 1369, in get_partitions_sql<= br style=3D"color:rgb(38,50,56);font-family:Roboto,sans-serif;font-size:13p= x">=C2=A0 =C2=A0part_data['partition_scheme'] =3D self.get_pa= rtition_scheme(row)
=C2=A0File "/Users/khushboovashi/P= rojects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schema= s/tables/utils.py", line 695, in get_partition_scheme
=C2=A0 =C2=A0for row in data[part_keys]:
KeyError: 'pa= rtition_keys'

Thanks,
Khushboo

On Wed, Mar 18, 2020 at 4:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
<= /div>
Hi = Hackers,=C2=A0

Attached is the patch to add support for = Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Pars= ers in Schema Diff Tool.

The patch contains some m= inor=C2=A0fix where parameters are added in the difference list even though= it's size is zero. I have also added the test cases.

Please review it.

--
Thanks & Regards
Akshay Joshi
Sr. Software= Architect
EnterpriseDB= Software India Private Limited
Mobile: +91 976-788-8246<= /span>
<= /div>
--00000000000033ccc605a1307fe7--