Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glsQA-0003dk-SH for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 09:32:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glsQ9-0000mR-AZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 09:32:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glsQ9-0000mK-50 for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 09:32:37 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glsQ0-0008As-6y for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 09:32:36 +0000 Received: by mail-oi1-x22b.google.com with SMTP id w13so16829937oiw.9 for ; Tue, 22 Jan 2019 01:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xJEPjCugrurx9v4nd5Ifdy/mQVv84X0kfhBe/0+BED4=; b=NLef+3KapjUZMeHq3Wt9xTmrZQdn+KGbPBSU6odpFjcgWcBTEcnhUKKr1GIdq4iTZj wzdnnjnqn0Nl+kfXTyA3v/q67GHwxOwvdIfb1zZIB3DqocLpQPhqFhfL2t93DicwG4HA Z17R50GBv5Jqr8rn0UNo79UtE/0+PfefrgPThlyf5OLQzsXQyMoXs/9pzu+LccPiiQeR eT38glZjiLx5h1oCjX1Jjh+kwSxwgJ+sHN2Uc+u0QD4bfaEAMDpqTfz1nDScJKGpaVTS 0ipKRM/xtgPOKGgpH70t4YmcD1gZLangmDTnBrZHv89RD+SO+QwP1N7XxgZKs+zkM/Y6 agOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xJEPjCugrurx9v4nd5Ifdy/mQVv84X0kfhBe/0+BED4=; b=s9jkrhkb43wGksU4lzPtXFkLnyC2fH1jajG+CN3fUZSYlKPU354wY+wMBO2vdyiZUv TFIy2nVd0ia95ip/WP8YO+/lavLYE7PmzMJPuyyBmfaxQB7rlGzUUMF6g/tlPR2GK410 zDp8+tQw6JphoXX5qfBNtdzs20ztIeJ5w1QNRUTuZ/80gw9e/raLi3C1se5HupZx3bw8 4lWTRAt2MgjQK19zq6Y0blV72gRHIGumkgwRZkZOMLbCpLdmbGnsLw0xo/E5gn5NHs2Y lhpxn2qB6CUc4SPM5RfDvRjKoxHjUQJyRtwn9gUUlLi//Dac1bh6wdAX0rxvJHGo8LZK P2xQ== X-Gm-Message-State: AJcUukeQMHo2H9NBcVDOzgTQ/X2/blvb4PFZZ/lHHj7GLh0oLaw1Mt8p wTeM7KeMsddk4RTf7wRDx383rC7gLGMi7Npe07VYkQ== X-Google-Smtp-Source: ALg8bN4ooCkVMWUm1d2GO9q140HZAGsDRz7TE6dqtEJHrDURMcjJ+xVxIQM3x850is5gG0GO8PNuHx33aAbAISqjIqY= X-Received: by 2002:aca:c443:: with SMTP id u64mr8139632oif.136.1548149546196; Tue, 22 Jan 2019 01:32:26 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 22 Jan 2019 15:02:15 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell To: Akshay Joshi Cc: Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c2b88d058008a78f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c2b88d058008a78f Content-Type: text/plain; charset="UTF-8" Hi Harshal, The Selec2Cell and PrivilegeCell are working properly but I think we should also consider below: 1. The Backgrid and sub-node should have accessibility including every button, cell and control. 2. The Backgrid table header is accessible through keyboard but it should be highlighted when it gets focus. @Akshay, we can commit this patch but we should create the separate RM for above fixes. Thanks, Khushboo On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it. > > On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> Please find attached patch to fix backgrid navigation using keyboard >> for Select2Cell and PrivilegeCell >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --000000000000c2b88d058008a78f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Harshal,

The Selec2Cell and Pr= ivilegeCell are working properly but I think we should also consider below:=

1. The Backgrid and sub-node should have accessibility = including every button, cell and control.
2. The Backgrid table h= eader is accessible through keyboard but it should be highlighted when it g= ets focus.

@Akshay, we can commit this patch but w= e should create the separate RM for above fixes.

T= hanks,
Khushboo


--000000000000c2b88d058008a78f--