Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOygD-009cYG-25 for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jul 2023 10:57:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qOygB-009dVs-KR for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jul 2023 10:57:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOyg6-009chy-Cz for pgadmin-hackers@lists.postgresql.org; Thu, 27 Jul 2023 10:57:06 +0000 Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qOyg3-000gAu-2X for pgadmin-hackers@postgresql.org; Thu, 27 Jul 2023 10:57:05 +0000 Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-583b47809beso9347717b3.0 for ; Thu, 27 Jul 2023 03:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1690455418; x=1691060218; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=G4LqyUYG1dNZU1/3tvLejADxqa2n4l4MUMukn7u0hRs=; b=ATiMnqfLOuFYYZI0udqXCne7UqvPFJTdmAhwzIXbBTXfi+L+VhJ73nMZPxB9WWENxQ 2BBwMa477aukCdvAZ7pahSvr3TJDoXt0HPzvh0V1fBBcU6GUGo/FKPYpcJYExmFJCk/V KsangVpvtQEqGhL2yGN/PCf5SG6IuntyfHl50ljr+A7sOgwn9npN5WQmondsjWhmfgWK S8d0tWe0HPa+typslmnABaLxT1MCDdD1DpVqAHZsLMpSTnt/Csi1Nm7D5eSS8CHVsMY7 GabtVwlUQqdSq5U9Nh9YaX5er1reyPQ3GUi16WvBr1DShJaMVFN6a+SlTSxvMgjXVOT2 Y2uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690455418; x=1691060218; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G4LqyUYG1dNZU1/3tvLejADxqa2n4l4MUMukn7u0hRs=; b=XDWBf3488HtwpVjIRypW6wm91XyvtlNIYz6GRR3ETAz14EUvXlrOdUuoYP2KvGp/rh iEdikCNS2to7lIDAjTXfcMQTpL2VG5juq1KSnV4VXcUnWBOuV1c8oXT74M/ZX4hcgR98 eAofgrm+SThsUmIuEaeHkB3y+vT+Jr7y2eT9HOooSlaDxkDuaU7ujc3VSWdrEsUOrvKN TaH1pHawV6HgF8xkYA3o/GGkWOe0KJDi+BsMmsWz9hmncgl53WEXUv16Ms56j0LgXAG6 ewQm9x1XPBsY+myz74QZcTRXxWHlbP/9pmKCkXVZ74QdhNjs2aqgBkiWZQPiJiIVjYh3 0KoA== X-Gm-Message-State: ABy/qLZfbHPYALbIa8oi16v5P9xnV5FFWEnfnoYsLb/AfkJxJvstDYMj CQgLarMue23/cTTp/a2ZH+GbQqglMOsyiq5IENGtrQ== X-Google-Smtp-Source: APBJJlF+Dfh7Cukv9gE9XH2td2t0CKjESudlOeqnl3YDd5CQ0QSQNTRdJKssVc+77CKz358sbme1TWCuuWBtyNT8DK4= X-Received: by 2002:a81:7507:0:b0:54f:9cd0:990 with SMTP id q7-20020a817507000000b0054f9cd00990mr4800155ywc.18.1690455418453; Thu, 27 Jul 2023 03:56:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Thu, 27 Jul 2023 16:26:46 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Sahil Harpal Cc: pgadmin-hackers@postgresql.org, Aditya Toshniwal , Ashesh Vashi , Dave Page , Akshay Joshi Content-Type: multipart/related; boundary="000000000000b9fb86060175d226" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000b9fb86060175d226 Content-Type: multipart/alternative; boundary="000000000000b9fb85060175d225" --000000000000b9fb85060175d225 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 27, 2023 at 1:59=E2=80=AFPM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Sahil, > > On Thu, Jul 27, 2023 at 1:09=E2=80=AFPM Sahil Harpal > wrote: > >> On Wed, 12 Jul 2023 at 15:58, Sahil Harpal >> wrote: >> >>> On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> [image: image.gif] >>> >>>> It fails while applying. Can you please rebase your patch and send it= ? >>>> >>> >>> Could you please try the attached patch. >>> >> Just a follow-up email to check if I can proceed with a similar structur= e >> and logic for the remaining disk tab. >> > You have made different files tab-wise; it would be more manageable if yo= u could put them under a subfolder OR start a name with system_state or something like that. > If anyone has faced any issues while using it or has any suggestions for >> improvement, please let me know, and I will make the necessary changes a= nd >> follow the same approach for the disk tab. Although there is an issue wi= th >> drive's letters, the I/O analysis of block devices is working just fine = on >> my system, so I can probably start working on it parallelly. >> >> Some initial review comments. > > - While applying the patch, I got warnings; please fix those. > - Fix PEP-8 errors (yarn run pep8) > - Fix the linter errors. Run *yarn run bundle:dev* instead of *yarn run > webpacker so* you will get the linter errors on every run. > - If the System Stat extension does not exist, display the appropriate > message instead of blank graphs. > - For the first time, graphs start from the opposite side, and after the > following API call, those get adjusted; please fix that. > - Please consider the refresh rate for the API calls (preferences setting= s > > Dashboards > Refresh rates) > > The code review is in progress; I will send my review comments once > completed. > > Thanks, > Khushboo > > >> Thanks, >> Sahil >> >> --000000000000b9fb85060175d225 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Jul 27, 2023 at 1:59=E2=80=AF= PM Khushboo Vashi <kh= ushboo.vashi@enterprisedb.com> wrote:
Hi Sahil,
On = Thu, Jul 27, 2023 at 1:09=E2=80=AFPM Sahil Harpal <sahilharpal1234@gmail.com>= wrote:
3D""
On Wed, 12 Jul 2023 at 15:58, Sahil Harpal <sahilharpal1234@gmail.com> w= rote:
On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi <khushboo.vashi@ent= erprisedb.com> wrote:
3D"=
=C2=A0It fails while applying. Can you please rebase your patch= and send it?=C2=A0

Could= you please try the attached patch.
Just a follow-up email to check if I can proceed with a similar structure= and logic for the remaining disk tab.=C2=A0
=
You have made different files tab-wise; it wo= uld be more manageable=C2=A0if you could put them under a subfolder OR star= t a name with system_state or something like that.
If anyone has faced any issues while using it or has any su= ggestions for improvement, please let me know, and I will make the necessar= y changes and follow the same approach for the disk tab. Although there is = an issue with drive's letters, the I/O analysis of block devices is wor= king just fine on my system, so I can probably start working on it parallel= ly.=C2=A0

Some initial re= view comments.

- While applying the patch, I got w= arnings; please fix those.
- Fix PEP-8 errors (yarn run pep8)
- Fix the linter errors. Run yarn run bundle:dev=C2=A0instead= of yarn run webpacker so=C2=A0you will get the linter errors on eve= ry run.
- If the System Stat extension does not exist, display th= e appropriate message instead of blank graphs.
- For the first ti= me, graphs start from the opposite side, and after the following API call, = those get adjusted; please fix that.
- Please consider the refres= h rate for the API calls (preferences settings > Dashboards > Refresh= rates)

The code review is in progress; I will sen= d my review comments once completed.

Thanks,
=
Khushboo
=C2=A0
Thanks,
<= div>Sahil

--000000000000b9fb85060175d225-- --000000000000b9fb86060175d226 Content-Type: image/gif; name="image.gif" Content-Disposition: inline; filename="image.gif" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: ii_lkkudxyl0 R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7 --000000000000b9fb86060175d226--