Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZXcA-0004uu-Ef for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 06:44:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZXcA-0004rp-0C for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 06:44:58 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZXc9-0004rg-4P for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 06:44:57 +0000 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZXc5-0005UY-I1 for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 06:44:55 +0000 Received: by mail-lf0-x231.google.com with SMTP id x1so5175608lff.0 for ; Thu, 02 Feb 2017 22:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hwcq+ZvKw4rSpufBuLA2Oz7XUrgvrS6apXs6FM8M/OU=; b=VdTns3BajvmjTbU+rBsh6xhOa62+8y7wx0EY4DhsDJ3JeOXijSYPFZa/2kfdnUGfhV HMp3Z2Y+xmhqhGuxYvH2M4WqpILW6mPgEVtJEmXLG/5qU9EnpmeDzWq5qhOA1klZnW5b duJJaxx7o4o7pVulODhY3QH5WkC6ritQUkj8jWYvVSynmCiFOF83PtRNGETUD+CBo8Dm AkhORqmWd38KOaxR1bp10LMSWWxRWdefiE681PmRZywujzpgGinQUUzwVk3o7eB7yzlj oC6UrrhHXQgEEAScRmv6dHczvtIugRxDiNLvZdubJcJrNXlXDPS1XcpPSk6G+q6QvgLG SZuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hwcq+ZvKw4rSpufBuLA2Oz7XUrgvrS6apXs6FM8M/OU=; b=FvIKBa8m0Lvj/3IZ493sXg1faMbx6ShmvD8VtzvmNIftFDxB8j/2etOPu6G+uDYLLH Fq0h7jOiN3BeZ3f75WgMgeXkuO0NOf+lbfOd32KTl+Ju6fTAteuLu91OSwPa3/MeYgu8 7u/mLwIbJXeyrGSNW9xxTH9EMEnMPPmToNDhWFhZD2GZfuO2Qli5ZLIauxPoDteQad0I 6OUy2NNvHAAzMqTOJNGuqYCDZl0b1w8m/1dwPpowGj19m4RsN4H/+A2Fm1OoZhEcIllj JUa7+VVVJz8vmqKi1Mlg9nHhfa0FJG6//8REqETiVWd/R3XopH0Jc8Cr4vP9y57JKl0b P3Rg== X-Gm-Message-State: AIkVDXL+bCcz5L0ZAps2DLue2LkQ1aa7AyE6PTtmtS+qfkqR8dYRq+p+Evp6FoY8UObVS9lkwB6taFXPk0qbhF5J X-Received: by 10.25.141.12 with SMTP id p12mr4480987lfd.147.1486104290916; Thu, 02 Feb 2017 22:44:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.41.201 with HTTP; Thu, 2 Feb 2017 22:44:50 -0800 (PST) In-Reply-To: References: From: Khushboo Vashi Date: Fri, 3 Feb 2017 12:14:50 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11401c145c0fb405479a9e04 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11401c145c0fb405479a9e04 Content-Type: text/plain; charset=UTF-8 Hi, On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached rebased patch. > > This patch also include fix for RM 2139: Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab > Thanks, > Khushboo > > On Mon, Jan 30, 2017 at 6:20 PM, Dave Page wrote: > >> Hi >> >> Can you rebase this please? >> >> Thanks. >> >> On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi >> wrote: >> > Hi, >> > >> > Please find the attached updated patch. >> > >> > Thanks, >> > Khushboo >> > >> > On Fri, Jan 20, 2017 at 5:31 PM, Dave Page wrote: >> >> >> >> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi >> >> wrote: >> >> > Hi, >> >> > >> >> > Please find the attached patch to fix the RM 2069 - Wrong tablespace >> >> > displayed in table properties. >> >> > >> >> > When the table is created without a tablespace, the "pg_default" >> >> > tablespace >> >> > gets selected rather than the default tablespace (the current >> database >> >> > tablespace). >> >> > So, this issue has been fixed. >> >> >> >> Unfortunately more work is required. I started hacking on it (see >> >> attached), but there is more effort needed and I'm out of time. >> >> Specifically: >> >> >> >> - We need to remove 'pg_default' as the default tablespace when >> >> creating objects. Let's have no default, and let PG automatically pick >> >> the right tablespace, unless the user specifically overrides it. My >> >> updated patch removes that default, and fixes some of the SQL to >> >> handle it. >> >> >> > Done >> >> >> >> - Matviews don't list the correct tablespace in their properties list. >> >> >> > Done >> >> >> >> - Unique constraints ignore the tablespace option if the user selects >> >> pg_default, even if the database's default is something different. >> >> >> > Done >> >> >> >> So I think to complete this we need to review all objects that use >> >> tablespaces (databases, tables, matviews, indexes, index-backed >> >> constraints) and ensure: >> >> >> > Done >> >> >> >> - No default tablespace is selected when creating an object. >> >> >> > Done >> >> >> >> - If the user selects a tablespace, the CREATE SQL must handle it >> >> properly. Similarly, if they leave it to the default. >> >> >> > Done >> >> >> >> - The Properties views must display the actual tablespace in use, >> >> whether it is specific to the object, or the database default. >> >> >> > Done >> >> >> >> Thanks. >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11401c145c0fb405479a9e04 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi &l= t;khus= hboo.vashi@enterprisedb.com> wrote:
Hi,

Please = find the attached rebased patch.

This patch also include fix for RM 2139:=C2=A0Message (Connection to the = server has been lost.) displayed with Materialized view and view under sql = tab

=C2=A0
Thanks,
Khushboo=

On Mon, Jan 30, 2017 at 6:2= 0 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Jan 20, 2017 at 5:31 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM 2069 - Wrong tab= lespace
>> > displayed in table properties.
>> >
>> > When the table is created without a tablespace, the "pg_= default"
>> > tablespace
>> > gets selected rather than the default tablespace (the current= database
>> > tablespace).
>> > So, this issue has been fixed.
>>
>> Unfortunately more work is required. I started hacking on it (see<= br> >> attached), but there is more effort needed and I'm out of time= .
>> Specifically:
>>
>> - We need to remove 'pg_default' as the default tablespace= when
>> creating objects. Let's have no default, and let PG automatica= lly pick
>> the right tablespace, unless the user specifically overrides it. M= y
>> updated patch removes that default, and fixes some of the SQL to >> handle it.
>>
> Done
>>
>> - Matviews don't list the correct tablespace in their properti= es list.
>>
> Done
>>
>> - Unique constraints ignore the tablespace option if the user sele= cts
>> pg_default, even if the database's default is something differ= ent.
>>
> Done
>>
>> So I think to complete this we need to review all objects that use=
>> tablespaces (databases, tables, matviews, indexes, index-backed >> constraints) and ensure:
>>
> Done
>>
>> - No default tablespace is selected when creating an object.
>>
> Done
>>
>> - If the user selects a tablespace, the CREATE SQL must handle it<= br> >> properly. Similarly, if they leave it to the default.
>>
> Done
>>
>> - The Properties views must display the actual tablespace in use,<= br> >> whether it is specific to the object, or the database default.
>>
> Done
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a11401c145c0fb405479a9e04--