Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aycGA-0003oC-7A for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 09:41:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aycG9-0005bq-Pw for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 09:41:21 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aycFw-0005Km-L0 for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 09:41:08 +0000 Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aycFu-00064L-AT for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 09:41:07 +0000 Received: by mail-lf0-x22f.google.com with SMTP id j8so124936107lfd.2 for ; Fri, 06 May 2016 02:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to; bh=J6LO7ii6/TieQXsVEVzbUkQXRya4D0hdvTBgRJ4e6k8=; b=htmkrk5kBRNgcnwwSqYH6okGZxckilvTynluWgEZdZnhbZgsbSDJvR/M882oug7yRM 0fLdKREy2j9jRsedvm2OHJNr2GPBeB9Zm0436XkinQZS+Goc0u/nSYZbyOT6FV7jLKxW YwRd89ng6rao93sDwZj59anKy41pcfgckxBbzx5C1pHrkI117yHeE/XZCY4Ej0Z5b60F zn+PJT7+OMAhBqmsm33Ts0VGHZvQ7Chk93oPtclsO8nKj8peoz95Xub3kpNujKAQxAFZ M1AMLOY2RYhmGbYmW8HsSWix1JJY0tVEAVJ0A7mb4GUjfR5+Q03Wo+YuWs3MPCijt3Zu glQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=J6LO7ii6/TieQXsVEVzbUkQXRya4D0hdvTBgRJ4e6k8=; b=CBwnjeqaI8WjXAd8nRhpRoQuzFfU1Z6GBhnPN76dhCSCDyRZMuTK5h2irfqyJ0/DgQ cOYW1JcygXvmj6JnBGkJxTxAuiEBvzLqLn5PEzR8JAw37Rx8/WO396k+1TsBS4Lm3h4s qOxcRh36TIsUbTQfTTu+AXwnucU7h27TOuPQCiFeiE5s6FveXdGpIo2F+objAAn4fwj6 FL3w57P4T7PgdAAoANaW5ctZXqX5KVBSy2cDW2GH360E7ikfL2m0ivg94a6KZknOeZTo ukw/72W7CfyFockNALlxuZifqyqTfUgmUI99NKviiQC6Bg0nMznSkAwlz6F6K6+ZNgnp yXkQ== X-Gm-Message-State: AOPr4FV4sq3NwqQ+wmXxkh3IZxT3S6x/q8PVlpQlyD7h0KQk0QUY64Cv5zKNoR/T08BrJ5IHPAi/lkMaOeJ1UgJw MIME-Version: 1.0 X-Received: by 10.112.141.8 with SMTP id rk8mr9118731lbb.91.1462527664090; Fri, 06 May 2016 02:41:04 -0700 (PDT) Received: by 10.25.144.81 with HTTP; Fri, 6 May 2016 02:41:03 -0700 (PDT) Date: Fri, 6 May 2016 15:11:03 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Fixed an issue related to the Delete/Drop context Menu of the node From: Khushboo Vashi To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11c33d5ee4adb2053229419e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11c33d5ee4adb2053229419e Content-Type: multipart/alternative; boundary=001a11c33d5ee4adac053229419c --001a11c33d5ee4adac053229419c Content-Type: text/plain; charset=UTF-8 Hi, When we try to drop any node and the visibility of the Delete/Drop context Menu of that node is having dependency on some function then, after deleting that node object, it gives a JS error. Please find the attached patch to fix this issue. Thanks, Khushboo --001a11c33d5ee4adac053229419c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

When we try to drop any node and th= e visibility of the Delete/Drop context Menu of that node is having depende= ncy on some function then, after deleting that node object, it gives a JS e= rror.

Please find the attached patch to fix this i= ssue.

Thanks,
Khushboo
--001a11c33d5ee4adac053229419c-- --001a11c33d5ee4adb2053229419e Content-Type: text/x-patch; charset=US-ASCII; name="pgAdmin4_canDrop_fix.patch" Content-Disposition: attachment; filename="pgAdmin4_canDrop_fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_invj55ku0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jy b3dzZXIvanMvbm9kZS5qcyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxh dGVzL2Jyb3dzZXIvanMvbm9kZS5qcwppbmRleCA1ODEwZTc0Li43ODE0OTM0 IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBsYXRlcy9i cm93c2VyL2pzL25vZGUuanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci90 ZW1wbGF0ZXMvYnJvd3Nlci9qcy9ub2RlLmpzCkBAIC04OSw3ICs4OSw3IEBA IGZ1bmN0aW9uKCQsIF8sIFMsIHBnQWRtaW4sIE1lbnUsIEJhY2tib25lLCBB bGVydGlmeSwgcGdCcm93c2VyLCBCYWNrZm9ybSkgewogICAgICAgICAgIGFw cGxpZXM6IFsnb2JqZWN0JywgJ2NvbnRleHQnXSwgY2FsbGJhY2s6ICdkZWxl dGVfb2JqJywKICAgICAgICAgICBwcmlvcml0eTogMywgbGFiZWw6ICd7eyBf KCJEZWxldGUvRHJvcCIpIH19JywKICAgICAgICAgICBkYXRhOiB7J3VybCc6 ICdkcm9wJ30sIGljb246ICdmYSBmYS10cmFzaCcsCi0gICAgICAgICAgZW5h YmxlOiBfLmlzRnVuY3Rpb24oc2VsZi5jYW5Ecm9wKSA/IGZ1bmN0aW9uKCkg eyByZXR1cm4gc2VsZi5jYW5Ecm9wLmFwcGx5KHNlbGYsIGFyZ3VtZW50cyk7 IH0gOiBmYWxzZQorICAgICAgICAgIGVuYWJsZTogXy5pc0Z1bmN0aW9uKHNl bGYuY2FuRHJvcCkgPyAhIXNlbGYuY2FuRHJvcC5hcHBseShzZWxmLCBhcmd1 bWVudHMpIDogKCEhc2VsZi5jYW5Ecm9wKQogICAgICAgICB9XSk7CiAgICAg ICAgIGlmIChzZWxmLmNhbkRyb3BDYXNjYWRlKSB7CiAgICAgICAgICAgcGdB ZG1pbi5Ccm93c2VyLmFkZF9tZW51cyhbewpAQCAtOTcsOCArOTcsOCBAQCBm dW5jdGlvbigkLCBfLCBTLCBwZ0FkbWluLCBNZW51LCBCYWNrYm9uZSwgQWxl cnRpZnksIHBnQnJvd3NlciwgQmFja2Zvcm0pIHsKICAgICAgICAgICAgIGFw cGxpZXM6IFsnb2JqZWN0JywgJ2NvbnRleHQnXSwgY2FsbGJhY2s6ICdkZWxl dGVfb2JqJywKICAgICAgICAgICAgIHByaW9yaXR5OiAzLCBsYWJlbDogJ3t7 IF8oIkRyb3AgQ2FzY2FkZSIpIH19JywKICAgICAgICAgICAgIGRhdGE6IHsn dXJsJzogJ2RlbGV0ZSd9LCBpY29uOiAnZmEgZmEtdHJhc2gnLAotICAgICAg ICAgICAgZW5hYmxlOiAoXy5pc0Z1bmN0aW9uKHNlbGYuY2FuRHJvcENhc2Nh ZGUpID8KLSAgICAgICAgICAgICAgZnVuY3Rpb24oKSB7IHJldHVybiBzZWxm LmNhbkRyb3BDYXNjYWRlLmFwcGx5KHNlbGYsIGFyZ3VtZW50cyk7IH0gOiB0 cnVlKQorICAgICAgICAgICAgZW5hYmxlOiBfLmlzRnVuY3Rpb24oc2VsZi5j YW5Ecm9wQ2FzY2FkZSkgPworICAgICAgICAgICAgICBmdW5jdGlvbigpIHsg cmV0dXJuIHNlbGYuY2FuRHJvcENhc2NhZGUuYXBwbHkoc2VsZiwgYXJndW1l bnRzKTsgfSA6ICghIXNlbGYuY2FuRHJvcENhc2NhZGUpCiAgICAgICAgICAg fV0pOwogICAgICAgICB9CiAgICAgICB9Cg== --001a11c33d5ee4adb2053229419e Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11c33d5ee4adb2053229419e--