Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXSZQ-0003lU-4E for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Jun 2018 14:34:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fXSZO-0000CK-H8 for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Jun 2018 14:34:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXSZO-0000CD-CR for pgadmin-hackers@lists.postgresql.org; Mon, 25 Jun 2018 14:34:18 +0000 Received: from mail-ot0-x241.google.com ([2607:f8b0:4003:c0f::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fXSZH-0004tV-OG for pgadmin-hackers@postgresql.org; Mon, 25 Jun 2018 14:34:17 +0000 Received: by mail-ot0-x241.google.com with SMTP id v24-v6so15260360otk.13 for ; Mon, 25 Jun 2018 07:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3ta8hXMeNg+LHs3QuENY7g9GA9SxGRkBkT1mSCYBAq4=; b=JsmaDGnioy20aDA5f86NUM/MQfk1EoKJ/dj/bKh6sNOBszkzdcDK4WJBeWWEeFwP5F v5VjJQLyOO9Bzg7ApYqAwnr4YxH7ctR4NZtvAkkEsEdoq4lNNNQzZJ+TiJfH9BYFOWka 1XBJSEagUBnfxT96z/01k0SBOWhWoBxIVUnxLNmvXLZZwNjMZqrSNoWqRjik2gXaVFGh +0SzJmQTpgjAE5Lfza6HPXPhykakdqX5d1IIby64jT1OnXJcdA+uA20UHjR9CZaeRtjN 6O/uGod0Tn6hrflH40muPKOIk9JJWpAol94hydS3OCRD3mN4VunsK/xZ8oQCjrWyPyPJ NAnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3ta8hXMeNg+LHs3QuENY7g9GA9SxGRkBkT1mSCYBAq4=; b=gOtNO2/YzWpCmSVK87tSUBlzuYD1ImD8mTs24AmEtcJy582Gs2Nr35mVkd2NvDR8av wPXHkUc4RD3ZmGok4gpFAuWA9OBuSH09u62ibC3GcQtDiAFeYgHmlce+prJQ4BwH1iz8 VHf1VzAuMG6xcws+hCdBW16ee98Nz0VWBjMviFEFZK2bk2xBzRfB6t8qQrfzdTIM1ywz G9Nse1dlqiy7Ubev+CuGAAPlMBrJTyVU1RaH1dk2vfPiVCUssuVEhdkgVGv8qs5ihbP8 ehmCrzNXVwFUVc4EMIiJ2lbxp+HN/osyC3IY+cJ5xNgfHhGm9GBZezpqq1ekhGDM48hA 9bZw== X-Gm-Message-State: APt69E2zpv7DeWKiN/RVJJW9THsEGkvdNvI4rFYFH5FHTwWQOPwGMpG3 C3yxFDRG74EvnuAGKdPZtWxajPAhNcEHioujGC0VWQ== X-Google-Smtp-Source: AAOMgpcpQybWrcWX0ovU4Wt93njB2UJhKXSB6cd1eRlbFF9XLxuJf4Q6bh6nfDh0B29QxtpMH1iRhl55Z0dof1mbAL8= X-Received: by 2002:a9d:75d7:: with SMTP id c23-v6mr7955730otl.121.1529937249321; Mon, 25 Jun 2018 07:34:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Mon, 25 Jun 2018 20:03:58 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000046923a056f7846e9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000046923a056f7846e9 Content-Type: text/plain; charset="UTF-8" On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: > Hi > > On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #3309 - Backup does not work with >> --format=d. >> >> Fixes in the patch : >> >> 1. Format = directory fix for Backup and Restore utilities >> 2. Test cases for format = directory >> 2. File manager fix - The selected directory was not properly populated >> in the text box >> > > The patch disables the file picker button if you select Directory format. > This seems like poor behaviour; I think we need to modify the dialogue to > allow a directory to be selected. > > In the directory format, which ever the folder name given, that will be created by pg_dump, so I have disabled it. > 3. Refactoring of File manager JS file >> > > That's somewhat more readable. Can we add tests? > Will look into it. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --00000000000046923a056f7846e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Mon, 25 Jun 2018, 19:47 Dave Page, <dpage@pgadmin.org> wrote:
Hi

On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi &= lt;khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please= find the attached patch for RM #3309 - Backup does not work with --format= =3Dd.

Fixes in the patch :

1. Format =3D directory fix for Backup and Restore utilities
2.= Test cases for format =3D directory
2. File manager fix - The se= lected directory was not properly populated in the text box

The patch disables the file picker button if y= ou select Directory format. This seems like poor behaviour; I think we need= to modify the dialogue to allow a directory to be selected.
=C2= =A0
In th= e directory format, which ever the folder name given, that will be created = by pg_dump, so=C2=A0 I have disabled it.
=
3. Refactoring of File manager JS file

That's somewhat more readable. Can we add= tests?=C2=A0
Will look into it.

--
Dave Page
Blog: http://pgs= nake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http:= //www.enterprisedb.com
The Enterprise PostgreSQL Company
--00000000000046923a056f7846e9--