public inbox for [email protected]
help / color / mirror / Atom feedFrom: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.
Date: Tue, 13 Mar 2018 10:16:36 +0530
Message-ID: <CAFOhELdZ0uQ_h3t7K=vQTnebd0-1fUq110rKEg_Lj+eFti4LtQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAFOhELf74n8cKE9y_4ppNs31Qi87WDLry+TV7K_bpAmdczM2bg@mail.gmail.com>
<CA+OCxozdsAg3-jv4yhv9G9Kre4KmO+zWYfkzmVTGrfjX=OkvWA@mail.gmail.com>
<CAFOhELfcJSs+nE3Z5bgFfNkVVmuavi8GvQ-uwrKPO7Y+hVf79w@mail.gmail.com>
<CA+OCxowgspEsUwg8cGcyZH=whCS8n26NePw0cPycSJ=H+PZT8Q@mail.gmail.com>
<CAFOhELdv_EFFctXmLNVTeH4dj7EdQ_oabAUxeC+oho+S4Q-Jww@mail.gmail.com>
<CA+OCxoxKoZ7Mijapqb=oFh34jFNrs5xeuRWNH+gZhMtxkGFu3w@mail.gmail.com>
<CA+OCxoz-N=7QMVh05R6dpQxugyx-z=+4TPOYB6z4vhZA_Ks3tA@mail.gmail.com>
<CAFOhELftpncVyoK=H4L-yZco_XWbk+x0XwRx1A5QgLkgXpu2MQ@mail.gmail.com>
<CA+OCxoxajGF0w68UESWB0c_4e=MtoQDsco8DFGtMgpGviiykjA@mail.gmail.com>
<CAFOhELfMzT6uzhR4d_MAA0Rr-0h1Wk1ypj1c3S0gBojoE0NC-Q@mail.gmail.com>
<[email protected]>
On Tue, Mar 13, 2018 at 9:39 AM, Dave Page <[email protected]> wrote:
>
>
> On 12 Mar 2018, at 23:12, Khushboo Vashi <[email protected]>
> wrote:
>
>
>
> On Tue, Mar 13, 2018 at 2:29 AM, Dave Page <[email protected]> wrote:
>
>> So I was trying to test this, and every time I try to run a backup, I'm
>> getting the following, with or without your patch:
>>
>> (sqlite3.ProgrammingError) You must not use 8-bit bytestrings unless you
>> use a text_factory that can interpret 8-bit bytestrings (like text_factory
>> = str). It is highly recommended that you instead just switch your
>> application to Unicode strings. [SQL: u'INSERT INTO process (pid, user_id,
>> command, "desc", arguments, logdir, start_time, end_time, exit_code,
>> acknowledge) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)'] [parameters:
>> (180312205250107339, 1, u'/Library/PostgreSQL/9.4/bin/pg_dump',
>> 'ccopy_reg\n_reconstructor\np0\n(cpgadmin.tools.backup\nBack
>> upMessage\np1\nc__builtin__\nobject\np2\nNtp3\nRp4\n(dp5\nS\'cmd\'\np6\nV
>> --file "/Users/dpage/foo.dmp" --host "127.0.0.1" --port "5432" --username
>> "postgres" --no-password --verbose --format=c --blobs
>> "\xe9"\np7\nsS\'backup_type\'\np8\nI3\nsS\'database\'\np9\nV
>> \xe9\np10\nsS\'bfile\'\np11\nS\'foo.dmp\'\np12\nsS\'sid\'\np13\nI1\nsb.',
>> u'--file,/Users/dpage/foo.dmp,--host,127.0.0.1,--port,5432,-
>> -username,postgres,--no-password,--verbose,--format=c,--blobs,\xe9',
>> '/var/lib/pgadmin/sessions/process_logs/180312205250107339', None, None,
>> None, None)]
>>
>> Any thoughts as to what's going on? I wasn't getting this on my other
>> laptop, and I can't think what else we would have changed to cause this.
>>
>> Deleting all the records from the process table from SQLITE will solve
> this problem.
> There were few issues related to encoding-decoding in my old patches, you
> may have applied those.
>
>
> I deleted the database entirely, and still saw the problem.
>
> I have tried many things to reproduce this but couldn't. I faced this
issue when I was fixing the issue but not now.
Please make sure to delete the old session and a process table (or
database) and apply my latest patch. (of course you do this :) )
I have PY - 2.7.12, psycopg2 - 2.7.4 and SQLAlhemy -1.0.14 to be more
specific.
> On Mon, Mar 12, 2018 at 2:00 AM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>>
>>> Hi Dave,
>>>
>>> On Fri, Mar 9, 2018 at 9:09 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Fri, Mar 9, 2018 at 3:32 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Fri, Mar 9, 2018 at 3:54 AM, Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch to fix below issues:
>>>>>>
>>>>>> 1. #2963 - Backup database, Restore database and Maintenance Database
>>>>>> failed for é object
>>>>>> 2. #3157 - Process viewer doesn't show complete command executed.
>>>>>>
>>>>>> Test cases are not included for these fixes as we don't have test
>>>>>> cases for these modules (backup, restore, maintenance).
>>>>>> I will create one separate RM for the same which will cover this.
>>>>>>
>>>>>
>>>>> Interesting that you fix these together, as together they also exhibit
>>>>> another bug :-). Backing up the é database displays the following
>>>>> command:
>>>>>
>>>>> /usr/local/pgsql/bin/pg_dump --file "/Users/dpage/foo.bak" --host
>>>>> "localhost" --port "5432" --username "postgres" --no-password --verbose
>>>>> --format=c --blobs "é"
>>>>>
>>>>
>>>> I can reproduce this issue only with notification dialogue (which I
>>> have fixed in the attached patch) not with the details dialogue. Please
>>> refer the screenshots for the same.
>>>
>>>> Also, what tests can we add for backup/restore? We have nothing at all
>>>> at the moment, and it is pretty troublesome. I'd like to ensure that we can
>>>> backup and restore a database correctly, and ensure that the displayed
>>>> commands are what we expect and that we get valid output from
>>>> pg_dump/pg_restore (though, it may change from PG version to PG version, so
>>>> maybe we should just check for something small and generic). I guess this
>>>> might need some config parameters for the tests to specify the pg_* utility
>>>> paths for each server.
>>>>
>>>> I'd suggest maybe having a feature test that opens the prefs, sets the
>>>> appropriate path, then runs a backup, waits for it to finish, checks the
>>>> process monitor output, then restores the same backup to a new database,
>>>> checking the process monitor output again, and then checking that the
>>>> restored database contains at least one object from the original database
>>>> (we don't need to check all of pg_dump/pg_restore, just that something
>>>> expected was restored). We should use a (partial) database name and backup
>>>> filename from the advanced test config file, and I think both should
>>>> default to some interesting non-ASCII strings to ensure quoting works.
>>>>
>>> I was thinking of writing the unit test cases for the processes.py file
>>> as all the major functionalities for backup/restore/maintenance jobs done
>>> by this file, but by this we can not achieve the front-end string
>>> validation esp for non-ASCII strings.
>>> So, I am thinking of writing feature tests (as you have suggested) first
>>> and after that if needed I will write unit test cases.
>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.
In-Reply-To: <CAFOhELdZ0uQ_h3t7K=vQTnebd0-1fUq110rKEg_Lj+eFti4LtQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox