Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZeOQ-0002Yj-3o for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 13:59:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZeOP-00047O-LV for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 13:59:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZeOO-000456-PN for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 13:59:13 +0000 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZeOL-0004qH-Gj for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 13:59:11 +0000 Received: by mail-lf0-x234.google.com with SMTP id x1so10586269lff.0 for ; Fri, 03 Feb 2017 05:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QXSLncdsiwEUkFnpfJG6LmJ6ZftwP56Mqbd1KV80fuA=; b=xz6bbvcSg+9v4FBIaFq2k5OxFeg//KnjMcmSRUco88Iu1SxByhkWxLDK7zKcr2lsWi ZhHBurCimkrVdg+3n8WUNchTpu5oUEjmYjx7lq5C3QWTxKRE5Q7xAQK2VPictRjcxrXS h/mXsreb6BrmRoW0OjR9qaGcWKJauaK7dJxEhUsiQL4Kd1cwlEfdmtnc3gSHj3TEtvtE XYJklnBlMT6OoClf9mUZHYuSC5r76n1L6g7vN9fp6X/iF+P2Y01mdlJKHRqMYIkc3oNr NOgtfOqcEYkyDvVm8mHkHT80rwnYL1GfuUQCuiZBbFDtP5Jad5/XKSkJcBPwZoUR64F5 z7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QXSLncdsiwEUkFnpfJG6LmJ6ZftwP56Mqbd1KV80fuA=; b=OGXnCuSAE73RcHclh424j5Ysve4mHTa3b2trD+tUOGKj0yebip5BdW2xGHTRBChz8+ Hoa+WsDZU5sZpEy5H6WRm0j8OjjowFg2bq8vvvfXbbesJCvOqIKELcnbSjKwlhE4yjoa r/ueO8ssYNOC1QyEi0QyLQNFdOIrFGE2CvzhFxbkJmd8fN/V53wQjaLM4asxgC/vuKpQ 8un97sizmYuRkE0oIpngdU1Vf95aNv9GO0H4Q67VP1ivcV5BjiFDNtw6QtYqFItl3rzq 5aPDbZ4ZvaTH4Fi2RFjUH1lWcXo4Kd9NrmxqMDmJly/Qzeey07WQUI9sioWxwRR4Vob1 BZ7A== X-Gm-Message-State: AIkVDXKEX9aByRuI6kYWrD/Tc6hoSSuGa5T/w6+dehrFZ74bY+sDmGVZkgq6+W8ZOhfUqcX/5m54l2OWVI3n7Sed X-Received: by 10.46.20.25 with SMTP id u25mr5952949ljd.61.1486130347326; Fri, 03 Feb 2017 05:59:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.41.201 with HTTP; Fri, 3 Feb 2017 05:59:06 -0800 (PST) In-Reply-To: References: From: Khushboo Vashi Date: Fri, 3 Feb 2017 19:29:06 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=f403045fb96871535d0547a0affb X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f403045fb96871535d0547a0affb Content-Type: text/plain; charset=UTF-8 On Fri, Feb 3, 2017 at 7:02 PM, Dave Page wrote: > I doubt the order matters, but feel free to change it if it bugs you :-) > > I have tried to create the function with both SQL commands. There is no bug, its just in pgAdmin4, if its not leakproof then we mentioned 'NOT LEAKPROOF' in the SQL. So, I am not sure, we should remove it or not. On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi > wrote: > >> Hi Dave >> >> I have reviewed the patch and after applying it output in pgAdmin4 >> >> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 >> geometry) >> RETURNS boolean >> LANGUAGE 'sql' >> COST 100.0 >> *IMMUTABLE NOT LEAKPROOF * >> * PARALLEL SAFE* >> AS $function$ >> SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2) >> $function$; >> >> but as per psql it should be >> >> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 >> geometry) >> >> RETURNS boolean >> >> LANGUAGE sql >> >> *IMMUTABLE PARALLEL SAFE* >> >> AS $function$SELECT $1 OPERATOR(public.&&) $2 AND >> public._ST_Intersects($1,$2)$function$ >> >> >> is this behaviour correct?? >> >> >> >> On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix RM 2089 : PARALLEL SAFE support >>> for functions missing. >>> >>> Fix: Incorporated the PARALLEL SAFE support for the functions and >>> procedures for PostgreSQL 9.6. >>> >>> Thanks, >>> Khushboo >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > --f403045fb96871535d0547a0affb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave.page@enterpri= sedb.com> wrote:
I doubt the order matters, but feel free to change it if it bugs y= ou :-)


I have tried to create the functi= on with both SQL commands.=C2=A0
There is no bug, its just in pgA= dmin4, if its not leakproof then we mentioned 'NOT LEAKPROOF' =C2= =A0in the SQL.
So, I am not sure, we should remove it or not.

=
On Fri, Feb 3, 2017 at 12= :54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com&g= t; wrote:
Hi Dave= =C2=A0

I have reviewed the patch and after applying it o= utput in pgAdmin4 =C2=A0

CREATE OR REPLACE FU= NCTION public.st_intersects(geom1 geometry, geom2 geometry)
=C2= =A0 =C2=A0 RETURNS boolean
=C2=A0 =C2=A0 LANGUAGE 'sql'
<= div>=C2=A0 =C2=A0 COST 100.0
=C2=A0 =C2=A0 IMMUTABLE NOT LEAKPROOF= =C2=A0
=C2=A0 =C2=A0 PARALLEL SAFE
AS $funct= ion$
SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Inte= rsects($1,$2)
$function$;

but as p= er psql it should be=C2=A0

CREATE OR REPLACE FUNCTION = public.st_intersects(geom1 geometry, geom2 geometry)

=C2=A0RETURNS boolean

=C2=A0LANGUAGE sql

=C2=A0IMMUTABLE PARALLEL SAFE

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Inter= sects($1,$2)$function$


is this behaviour correct??



On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi <= khushboo.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
<= div dir=3D"ltr">Hi,

Please find the attached patch to fi= x RM 2089 : PARALLEL SAFE support for functions missing.

Fix: Incorporated the =C2=A0PARALLEL SAFE support for the functions = and procedures for PostgreSQL 9.6.

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
<= div class=3D"m_6627634912362079180m_2874725278825177761gmail_signature" dat= a-smartmail=3D"gmail_signature">
Akshay Joshi
<= font color=3D"#3333FF">Principal Software Eng= ineer=C2=A0





--
Dave Page
VP,= Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: = @pgsnake
--f403045fb96871535d0547a0affb--