public inbox for [email protected]
help / color / mirror / Atom feedFrom: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][Patch]: Fixed RM 1467
Date: Thu, 4 Aug 2016 16:51:09 +0530
Message-ID: <CAFOhELdhbzfBS=NyWJYvWCmycOR4aEP4sv5HA2Dcnxr__3qvVA@mail.gmail.com> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
Please find the attached patch for the fix of RM 1467: Unable to drop
trigger function, function and procedures.
The issue was produced because of execute_2darray function change.
Thanks,
Khushboo
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] RM_1467.patch (1.6K, 3-RM_1467.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
index 810bb49..ca69cac 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
@@ -799,13 +799,11 @@ class FunctionView(PGChildNodeView, DataTypeReader):
)
)
- name, func_args, nspname = res['rows'][0]
-
SQL = render_template("/".join([self.sql_template_path,
'delete.sql']),
- name=name,
- func_args=func_args,
- nspname=nspname,
+ name=res['rows'][0]['name'],
+ func_args=res['rows'][0]['func_args'],
+ nspname=res['rows'][0]['nspname'],
cascade=cascade)
status, res = self.conn.execute_scalar(SQL)
if not status:
@@ -1327,7 +1325,8 @@ It may have been removed by another user or moved to another schema.
if not status:
return internal_server_error(errormsg=res)
- func_def, name = res['rows'][0]
+ func_def = res['rows'][0]['func_def']
+ name = res['rows'][0]['name']
# Fetch only arguments
argString = name[name.rfind('('):].strip('(').strip(')')
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin][Patch]: Fixed RM 1467
In-Reply-To: <CAFOhELdhbzfBS=NyWJYvWCmycOR4aEP4sv5HA2Dcnxr__3qvVA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox