public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Sahil Harpal <[email protected]>
Cc: [email protected]
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Thu, 17 Aug 2023 17:57:43 +0530
Message-ID: <CAFOhELdhcYr9NBNrkEAWt_cwP77U2ANRK4xonqKA1p6WpMBdMA@mail.gmail.com> (raw)
In-Reply-To: <CAKi=nneuTPLMppZaAm-Y1X=4mY3UnbkbJAMCHF=Fu-2+kateRg@mail.gmail.com>
References: <CAKi=nnc6Ze8QWBmSHe9YBYciWeDzMf=-rw9BgyNocFSokrpi6w@mail.gmail.com>
	<CAKi=nneuTPLMppZaAm-Y1X=4mY3UnbkbJAMCHF=Fu-2+kateRg@mail.gmail.com>

Hi Sahil,

Please find the below review comments:


   - Do not use the Title case for the graph/chart’s heading. For example, *CPU
   Usage *should be *CPU usage*.
   - If I select any database without an extension installed and then
   select the database with the extension, the message (Extension is not
   installed) remains on the page. The database change doesn’t reflect on the
   UI.
   - CPU Usage () - What are these empty parentheses?
   - Please use the same grey background shades on the entire page.
   - Storage tab: If possible, please display the disk name in the heading
   - The Tooltip for graph points remains on the page. Please refer to the
   below screenshot.

[image: Screenshot 2023-08-17 at 5.50.19 PM.png]

   - Please use rounded corners for all the tables (same as graphs).
   - Sometimes graphs start from left and then shift to right. This issue I
   have reported in my initial review too.

Thanks,
Khushboo



On Thu, Aug 17, 2023 at 3:43 PM Sahil Harpal <[email protected]>
wrote:

> Hi Khushboo,
>
> I have made the necessary changes and pushed them to the same
> repository. Let me know if that resolves this null value issue.
>
> Thank you,
> Sahil
>
>>


Attachments:

  [image/png] Screenshot 2023-08-17 at 5.50.19 PM.png (190.0K, 3-Screenshot%202023-08-17%20at%205.50.19%20PM.png)
  download | view image

view thread (106+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Pgadmin4 System Stats Extension Design
  In-Reply-To: <CAFOhELdhcYr9NBNrkEAWt_cwP77U2ANRK4xonqKA1p6WpMBdMA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox