Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkMOP-0006J3-5D for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Jul 2019 05:40:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hkMON-0004jm-1j for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Jul 2019 05:40:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkMOM-0004hQ-JU for pgadmin-hackers@lists.postgresql.org; Mon, 08 Jul 2019 05:40:46 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkMOI-0004NY-LT for pgadmin-hackers@lists.postgresql.org; Mon, 08 Jul 2019 05:40:45 +0000 Received: by mail-oi1-x233.google.com with SMTP id a127so11659309oii.2 for ; Sun, 07 Jul 2019 22:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ee4pdCDe+ONYnmNssJcUoWF4QUaxvykvVDiGXrVmiQc=; b=EkYWaiWIr289jxrZbEwlP+b5m6k8L8woBJ3s+sTW9lepP57N0hLkcRVp0O8Y3owdGW isk2vu7Uluc9b5R1KiPoqYFLq+hbhenr7U33aYDQM4LLrvELdS/Fo2tLejXstRrwKEwF +zBWqunQTZdoOcaFcjjNq9QN/bc7CtbSkIyB5H54nucu0Nz7IjrWxCA/Uc0cKi4hyyB2 b9GzC8Svas7BibOCFfr0K82xZgnN/bmgw1uPkz0qjwzioXO4ccb85Pm3vb/VA7U39nNr 6HMy7TAMM+XXH1U7bvOhkIz6keHQrU1EBenMysIJMKaakjvDognznYCJzCps6fgpTDQR tPVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ee4pdCDe+ONYnmNssJcUoWF4QUaxvykvVDiGXrVmiQc=; b=nPCqeSpI4rCiculSEYrEBprXNbi1LJBY2X74BbaK/B1ncZUTjfPVEVckRC0gPUPfbb i+RNPT37qAa8O/XfDhP51WFqrBQ8RMEifnUjSxrgFHSZhHeZa1g0rH8baf6d9F1dezqU pY7HvNVoUgGTkkB+6EotsIrQcIDaz7ySRwuIyYv5nFCsUBIHT87/N3NEMlPMGf5MdpJU ClIqHgZgNOgTmmIsxn8gSJKN8sj1V84YW5ezPh5kFbWPBQBg5cqEpmIO42LE8Y1ZKUK9 b8/VhDwGrXCg5qaVdE4A8hEF6kg3vJm7BsCD/yptKPnNXNOOCj5HJSJoqvWXtgOqbp5j lTJg== X-Gm-Message-State: APjAAAUmB9slE3Z8rBVw1BCC2t44xSup7qUtS2BL1V8MXIyAF8Tskp0t GK0hQBCQhUh8QvmjaI2pn1zllYAuDeE/jb0X4VMbIOvj X-Google-Smtp-Source: APXvYqzt87bWO8rrYvJTJL+xAvxPyLOUgiqQuBEjqjrm6Tt3pRgXPr8mCBZACfuW2fPpv5Q87LVt8d91m/tqKp5F6d0= X-Received: by 2002:aca:4083:: with SMTP id n125mr8092461oia.106.1562564440078; Sun, 07 Jul 2019 22:40:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Mon, 8 Jul 2019 11:10:30 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000063ed18058d24e2c3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000063ed18058d24e2c3 Content-Type: multipart/alternative; boundary="00000000000063ed13058d24e2c1" --00000000000063ed13058d24e2c1 Content-Type: text/plain; charset="UTF-8" Hi, One small change is required to support the custom schema. Please find the attached patch for the same. Thanks, Khushboo On Fri, Jul 5, 2019 at 3:35 PM Akshay Joshi wrote: > Added logic to provide custom schema name in re_sql test framework. > > Branch > ------ > master > > Details > ------- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c6654628 > Author: Khushboo Vashi > > Modified Files > -------------- > web/regression/re_sql/tests/test_resql.py | 30 > +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > --00000000000063ed13058d24e2c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

One small change = is required to support the custom schema.
Please find the attached patc= h for the same.

Thanks,
Khushboo

On = Fri, Jul 5, 2019 at 3:35 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Added logic to provide cust= om schema name in re_sql test framework.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3D954c0d31019a6cd19e15ee024f032f92c6654628
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>

Modified Files
--------------
web/regression/re_sql/tests/test_resql.py | 30 ++++++++++++++++++++++++++++= +-
1 file changed, 29 insertions(+), 1 deletion(-)

--00000000000063ed13058d24e2c1-- --00000000000063ed18058d24e2c3 Content-Type: application/octet-stream; name="re_sql_schema_fixes_v2.patch" Content-Disposition: attachment; filename="re_sql_schema_fixes_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxtyhtrv0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3Rlc3RzL3V0aWxzLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2 ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGVzdHMvdXRpbHMucHkKaW5kZXgg ZTMyODVjZjUuLmFlNDk0MDJhIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZl cl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90ZXN0cy91dGlscy5weQorKysgYi93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1h cy90ZXN0cy91dGlscy5weQpAQCAtNzgsNyArNzgsNyBAQCBkZWYgdmVyaWZ5X3NjaGVtYXMoc2Vy dmVyLCBkYl9uYW1lLCBzY2hlbWFfbmFtZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzZXJ2ZXJbJ3BvcnQnXSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNlcnZlclsnc3NsbW9kZSddKQogICAgICAgICBwZ19jdXJz b3IgPSBjb25uZWN0aW9uLmN1cnNvcigpCi0gICAgICAgIHBnX2N1cnNvci5leGVjdXRlKCJTRUxF Q1QgKiBGUk9NIHBnX25hbWVzcGFjZSBzY2giCisgICAgICAgIHBnX2N1cnNvci5leGVjdXRlKCJT RUxFQ1Qgb2lkLCogRlJPTSBwZ19uYW1lc3BhY2Ugc2NoIgogICAgICAgICAgICAgICAgICAgICAg ICAgICAiIFdIRVJFIHNjaC5uc3BuYW1lPSclcyciICUgc2NoZW1hX25hbWUpCiAgICAgICAgIHNj aGVtYSA9IHBnX2N1cnNvci5mZXRjaG9uZSgpCiAgICAgICAgIGNvbm5lY3Rpb24uY2xvc2UoKQo= --00000000000063ed18058d24e2c3--