Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewKvJ-0006Hq-0j for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 04:55:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewKvH-0005UD-HQ for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 04:55:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewKvH-0005U3-Ac for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 04:55:27 +0000 Received: from mail-ot0-x22d.google.com ([2607:f8b0:4003:c0f::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewKvA-0000nX-SQ for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 04:55:26 +0000 Received: by mail-ot0-x22d.google.com with SMTP id 95-v6so5643484ote.5 for ; Wed, 14 Mar 2018 21:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=27ej50vnX5MqeSYttLxFSKCIj4F9PglKXAEHnrorJsY=; b=IjDrBAfruXPaCz9H5EW3LrBTxMMq0lSSrU7JI9fJTTr4EsGPRvBSxECHGpXIDQ4Hac 5Y4rzII/CFpnMVkITaUPdaBM5LUV1r3QaQ4PuYQs/BlG2XejqH+rXNmXEXqxMo3eSWHk 63nszKH9/F2UpXR+90SB1edPWHdetDXD2BllwGVj3WOlaICKeFhy9pR+sM0CArPbPzed gT3vHQnnuLbmU6PMzqdcXjgD5Oi/Uy+v57xnzvAexMhH2vxIR2gbNd89WuzoNBJ+DmoE J+I2jWK/Uz1DjQ1112QtV+nwa/Em3jODmLP8v+xmC88kjKfkWfloHtTKJiils3rDaSTu VTJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=27ej50vnX5MqeSYttLxFSKCIj4F9PglKXAEHnrorJsY=; b=CvHPW3MWhakLGYYnwtvfKCYTw/duhBtzTnMlHL0rSkluxVOw0DF+su/2rsVLpEOYAo t0rqQ4jth4Rtk4iSuroiuIiNy/3fVSXShOSx+AlWp/7ghyCGl3AojlnA5A9kZ/Hw30N7 9k4+M2D81rBC55MM4P9kPZiMdF/5oJ6IeLvJm+7Pi/HZRRmDa9ID3m2ne3aWI3TFg/du QX+N0bZdOxjoWqaAi5hygPYOKdjRRQuOufaGdkMg2FsSGekAYmsibxwkxGsWIM9uySps YA35KCgp6LA8i5FN8WLtD4+m4pvGTdFLYg1LW9BUnBQ7hXKfvieTSO8x5Eg3iX0Seukl j59A== X-Gm-Message-State: AElRT7FROoxtg/HvXENlGX+zCfxQWeHczyqKFoHzvYCGNuZ8M/r+qKzd erSHa/eIDhnCgn+4rnOHqCmGSgw3MZURkSyi1ydFdQ== X-Google-Smtp-Source: AG47ELv2VlIrt3xHNANBJrxu9rz+7ozVVUYXdavTvv4NOsw6LAbusKzD4BbfJDxPSStx1Y4Z/ua9yPxiwmjzgnAsGJ4= X-Received: by 10.157.64.189 with SMTP id n58mr4369027ote.215.1521089717075; Wed, 14 Mar 2018 21:55:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Wed, 14 Mar 2018 21:55:16 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Thu, 15 Mar 2018 10:25:16 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers To: Dave Page Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c1c0d90421af705676c4ca3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c1c0d90421af705676c4ca3 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 15, 2018 at 3:21 AM, Dave Page wrote: > Hi > > On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> > > Can you add a unit test for set_env_variables() please? > > This function is a part of a BatchProcess class which is used by all backup/restore/maintenance etc modules. So, when we write test cases for this module this function will be covered. I had already created RM for the same (Ref: https://redmine.postgresql.org/issues/3206) and it is in the current sprint. > >> Thanks, >> Khushboo >> >> On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without >>>> your patch applied. >>>> >>>> Yes, good point. Will update and send the patch. >>> >>>> >>>> On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Khushboo, >>>>> >>>>> We can simplify this, we don't need to create any extra column, >>>>> >>>>> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 >>>>> where we are setting ENV variable we can create common utility function >>>>> (let say in ../tools/utils/__init__.py) which will set all required the >>>>> environment variables and then we will pass that function in p.start(..) >>>>> method. >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please find the attached patch to fix RM #3122 : Backup not working >>>>>> on certificate (SSL) protected servers. >>>>>> >>>>>> The attached patch fixes the issue in the following modules: >>>>>> >>>>>> 1. Backup >>>>>> 2. Restore >>>>>> 3. Import/Export >>>>>> 4. Maintenance >>>>>> >>>>>> Thanks, >>>>>> Khushboo >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c1c0d90421af705676c4ca3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 15, 2018 at 3:21 AM, Dave Page <dpage@pgadmin.org><= /span> wrote:
Hi

On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
<= /span>
Hi= ,

Please find the attached updated patch.

Can you add a unit test for set_env_variables= () please?
=C2=A0
<= /div>
This function is a part of a BatchProces= s class which is used by all backup/restore/maintenance etc modules. So, wh= en we write test cases for this module this function will be covered.
=
I had already created RM for the same (Ref: https://redmine.postgresql.org/issues/3206= ) and it is in the current sprint.

Thanks,
Khush= boo

On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Wed, Mar 14, 2018= at 12:48 PM, Murtuza Zabuawala <murtuza.zabuawala@enterp= risedb.com> wrote:
=C2=A0../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310=C2=A0without your patch applied.

<= /div>
Yes, good point. Will update and send the pat= ch.=C2=A0

On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com><= /span> wrote:
= Hi Khushboo,

We can simplify this, we don't need to create any extra colum= n,
<= br>
= Check: ../pgadmin4/web/pg= admin/tools/import_export/__init__.py +322 where we are setting= ENV variable we can create common utility function (let say in ../tools/ut= ils/__init__.py) which will set all required the environment variables and = then we will pass that function in p.start(..) method.


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.= enterprisedb.com
The Enterprise PostgreSQL Company

<= /div>

On Wed, Mar 14, 2018 at 11:03 AM, Khushboo V= ashi <khushboo.vashi@enterprisedb.com> wr= ote:
= Hi,

Please find the attached patch to fix RM #3122 :=C2= =A0Backup not working on certificate (SSL) protected servers.
The attached patch fixes the issue in the following modules:

1. Backup
2. Restore
3. Import/E= xport
4. Maintenance

Thanks,
K= hushboo









--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company
--94eb2c1c0d90421af705676c4ca3--