Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ezFUW-0001bh-6t for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Mar 2018 05:43:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ezFUU-0002ab-Ha for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Mar 2018 05:43:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ezFUU-0002aR-30 for pgadmin-hackers@lists.postgresql.org; Fri, 23 Mar 2018 05:43:50 +0000 Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ezFUP-0001a2-PD for pgadmin-hackers@postgresql.org; Fri, 23 Mar 2018 05:43:48 +0000 Received: by mail-oi0-x22e.google.com with SMTP id 126-v6so3437094oig.0 for ; Thu, 22 Mar 2018 22:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f9sResLc2UNfM521nPzlpULQfrjK0dRNzd146lPybQk=; b=0S40mUpNdU0kmazgcPxuDRHK+ds9JJ9sZ3OrcT/9XN4mnG2jA3btKTV5d9y0MNwzIT gOQZHJnnarTBf1ilerYCCD7PQH93XGMimRQLDSjBBgvMTrPB8LdXxtb89KjpNfX8i68v nMZ6OU7UoDCq0j1hYdqwr0VZFQm7EPlM03qNTT4bu97zC/V2B5P+OAURnYT1NrMKDbPZ EY19cCS2PjXoSrfwzxTH8SLuFHpxDCgPptnBnQiYYuQYyZ4z8uitm3aa19jlDo3Koc0T yLsBaNlIj8JMgeEEX3XUT76+9dZywZzmAku/O7BfGYCeu8FFRBFLIzXXnh/Vn9vTQG3T pN+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f9sResLc2UNfM521nPzlpULQfrjK0dRNzd146lPybQk=; b=ZUZIy1A2ITddNL1Y6Ll0p0GoWmx6VrCTUFqn9Xe5cDO9Yeq0cda6Fd2Ezpcb64BU7M H8denC50QMzULMshyVUR1KBQsuAq5M7Pb3MUXxd7AHmR2HGKObeA3v7RdNselW2R+Nrx uaUkIY8dkIJVEsvaZFAqee1f+a/+PWozZ8G8kDJ9Jyh7EKM5eVPurE4X3Mwd54R20fGq nWidBfouFgqw6/dlArlD6wqggSMQlEMaKIMJKASyLpZhnwVu6MSgyo+QB2LfRdoeJIef G5jzOKnoAHT0gMjxlPZkiFMVlNtQ+CV0HY9DNs/GJPFaAI+ii+kZ+jtXyPlQ7QM9szYE vmvQ== X-Gm-Message-State: AElRT7E+DIjV5mOYBefcNsbZgB7gdKkfYjIYn4cSr6O8DUS/MsysLkX1 iXeUDO0y+PgRKHSpJ54rTfcubO1zNurhFOJZF2pc8g== X-Google-Smtp-Source: AG47ELuicMdOiUoWdjRndpq+OINI8THtPhj68VzM8OuLGlWUnVIb0joveNx8s3bMYZBpMQ5zPvswVSDyG9eJzHpp73I= X-Received: by 10.202.82.82 with SMTP id g79mr13825427oib.83.1521783824613; Thu, 22 Mar 2018 22:43:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.138.251 with HTTP; Thu, 22 Mar 2018 22:43:44 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Fri, 23 Mar 2018 11:13:44 +0530 Message-ID: Subject: Re: v3.0 release on hold To: Dave Page Cc: pgadmin-hackers , Akshay Joshi , Murtuza Zabuawala , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a113d85904a9eaa05680de888" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d85904a9eaa05680de888 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 22, 2018 at 3:42 PM, Dave Page wrote: > > > On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 22, 2018 at 3:20 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >>>> >>>>> We've run into a number of unexpected issues with the v3.0 release >>>>> that I think we need to resolve before moving forwards. For the time being, >>>>> only patches critical to fix these issues should be committed. >>>>> >>>>> I'll try to look at 1, though I do have another deadline I need to >>>>> meet. >>>>> Akshay, can you look at 2 please? >>>>> Fahar is already looking at 3. >>>>> Khushboo, can you look at 4 please? >>>>> >>>>> Thanks all. >>>>> >>>>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus >>>>> the runtime won't initialise in Fedora 27 and later. We need an alternative >>>>> for this, either a tray replacement that the RPM can depend on, or better >>>>> yet, support whatever it is Gnome expect such apps to use these days. >>>>> >>>>> 2) Starting a second instance of the app bundle on Mac doesn't always >>>>> open a new pgAdmin window as it should. It works fine in the debugger, or >>>>> if you start the app with a command like: "/Applications/pgAdmin\ >>>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click >>>>> the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>>>> >>>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my >>>>> copy, but apparently his is a fresh installation. >>>>> >>>>> 4) On my Windows 7 machine, after running a backup I get no status >>>>> window, and see the following in the logs: >>>>> >>>>> >>>> We have tried to reproduce this issue on Windows 7 and Windows 8, but >>>> couldn't reproduce it, It is working fine on both the environments. >>>> Can you please provide the options which you have selected while taking >>>> a backup? >>>> >>> >>> They were all the default options - I just selected a database, >>> right-clicked to select backup, and entered a filename. >>> >>> >> With the default options, it is working fine. >> > > Can you see any way in which the exception below could conceivably > happen? Perhaps if run on a system that has process logs from an older > version of pgAdmin? > > Not sure as this issue was fixed by Ashesh 1 year back as per git logs. > >>>> Traceback (most recent call last): >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>>> line 209, in run_wsgi >>>>> execute(self.server.app) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>>> line 197, in execute >>>>> application_iter = app(environ, start_response) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1997, in __call__ >>>>> return self.wsgi_app(environ, start_response) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1985, in wsgi_app >>>>> response = self.handle_exception(e) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1540, in handle_exception >>>>> reraise(exc_type, exc_value, tb) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1982, in wsgi_app >>>>> response = self.full_dispatch_request() >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1614, in full_dispatch_request >>>>> rv = self.handle_user_exception(e) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1517, in handle_user_exception >>>>> reraise(exc_type, exc_value, tb) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1612, in full_dispatch_request >>>>> rv = self.dispatch_request() >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>>> line 1598, in dispatch_request >>>>> return self.view_functions[rule.endpoint](**req.view_args) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", >>>>> line 792, in decorated_view >>>>> return func(*args, **kwargs) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", >>>>> line 62, in index >>>>> return make_response(response=BatchProcess.list()) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", >>>>> line 584, in list >>>>> details = desc.details(p.command, args) >>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", >>>>> line 190, in details >>>>> res += html.safe_str(cmd + self.cmd) >>>>> AttributeError: 'BackupMessage' object has no attribute 'cmd' >>>>> >>>>> >>>>> Thanks, >>>> Khushboo >>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d85904a9eaa05680de888 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 22, 2018 at 3:42 PM, Dave Page <dpage@pgadmin.org><= /span> wrote:


On Thu= , Mar 22, 2018 at 9:58 AM, Khushboo Vashi <khushboo.vashi@en= terprisedb.com> wrote:


On Thu, Mar 22, 2018 at 3:20 PM, Dave Page <= ;dpage@pgadmin.org> wrote:
Hi<= br>

On Thu, = Mar 22, 2018 at 9:25 AM, Khushboo Vashi <khushboo.vashi@ente= rprisedb.com> wrote:
<= div dir=3D"ltr">
Hi Da= ve,

On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dpage@pgadmin.org><= /span> wrote:
We've run into a number of unexpected issues with the v3.0 release t= hat I think we need to resolve before moving forwards. For the time being, = only patches critical to fix these issues should be committed.

I'll try to look at 1, though I do have another deadline I need = to meet.=C2=A0
Akshay, can you look at 2 please?
Fahar = is already looking at 3.
Khushboo, can you look at 4 please?

Thanks all.

1) There is no lo= nger a system tray in Gnome 3.26 and later, and thus the runtime won't = initialise in Fedora 27 and later. We need an alternative for this, either = a tray replacement that the RPM can depend on, or better yet, support whate= ver it is Gnome expect such apps to use these days.

2) Starting a second instance of the app bundle on Mac doesn't always= open a new pgAdmin window as it should. It works fine in the debugger, or = if you start the app with a command like: "/Applications/pgAdmin\ 4.ap= p/Contents/MacOS/pgAdmin4". It doesn't work if you double-cli= ck the appbundle or use a command like "open /Applications/pgAdmin\ 4.= app"

3) Fahar saw a crash on Windows 7. I cou= ldn't reproduce this on my copy, but apparently his is a fresh installa= tion.

4) On my Windows 7 machine, after running a = backup I get no status window, and see the following in the logs:


We have= tried to reproduce this issue on Windows 7 and Windows 8, but couldn't= reproduce it, It is working fine on both the environments.
Can y= ou please provide the options which you have selected while taking a backup= ?

They were = all the default options - I just selected a database, right-clicked to sele= ct backup, and entered a filename.
=C2=A0
With the default options, it is working fine.= =C2=A0

Can y= ou see any=C2=A0 way in which the exception below could conceivably happen?= Perhaps if run on a system that has process logs from an older version of = pgAdmin?
=C2=A0
Not sure as this issue was fixed by Ashesh 1 yea= r back as per git logs.

= Traceback (most recent call last):
=C2=A0 File "C:\Program F= iles (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py&quo= t;, line 209, in run_wsgi
=C2=A0 =C2=A0 execute(self.server.app)<= /div>
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\si= te-packages\werkzeug\serving.py", line 197, in execute
= =C2=A0 =C2=A0 application_iter =3D app(environ, start_response)
= =C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-package= s\flask\app.py", line 1997, in __call__
=C2=A0 =C2=A0 r= eturn self.wsgi_app(environ, start_response)
=C2=A0 File "C:= \Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py&= quot;, line 1985, in wsgi_app
=C2=A0 =C2=A0 response =3D self.han= dle_exception(e)
=C2=A0 File "C:\Program Files (x86)\pgAdmin= 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_= exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packa= ges\flask\app.py", line 1982, in wsgi_app
=C2=A0 =C2=A0= response =3D self.full_dispatch_request()
=C2=A0 File "C:\P= rogram Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py&qu= ot;, line 1614, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D sel= f.handle_user_exception(e)
=C2=A0 File "C:\Program Files (x8= 6)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, = in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_valu= e, tb)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv= \Lib\site-packages\flask\app.py", line 1612, in full_dispatch_req= uest
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\f= lask\app.py", line 1598, in dispatch_request
=C2=A0 =C2= =A0 return self.view_functions[rule.endpoint](**req.view_args)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-pack= ages\flask_login.py", line 792, in decorated_view
=C2= =A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 File "C:\Prog= ram Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py&qu= ot;, line 62, in index
=C2=A0 =C2=A0 return make_response(respons= e=3DBatchProcess.list())
=C2=A0 File "C:\Program Files = (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line= 584, in list
=C2=A0 =C2=A0 details =3D desc.details(p.command, a= rgs)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pg= admin\tools\backup\__init__.py", line 190, in details
= =C2=A0 =C2=A0 res +=3D html.safe_str(cmd + self.cmd)
AttributeErr= or: 'BackupMessage' object has no attribute 'cmd'

=
Tha= nks,
Khushboo=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Po= stgreSQL Company

--001a113d85904a9eaa05680de888--