Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOwNm-009V0l-DJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jul 2023 08:30:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qOwNk-008kMe-Mg for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jul 2023 08:30:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOwNk-008kMV-Di for pgadmin-hackers@lists.postgresql.org; Thu, 27 Jul 2023 08:30:00 +0000 Received: from mail-yw1-x1132.google.com ([2607:f8b0:4864:20::1132]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qOwNc-000f5O-TC for pgadmin-hackers@postgresql.org; Thu, 27 Jul 2023 08:29:59 +0000 Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-583d702129cso7251237b3.3 for ; Thu, 27 Jul 2023 01:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1690446590; x=1691051390; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uvusqDDOOJ6YtxaZ4j8Okxv7ktawtWuh73WObcHHgh0=; b=RvLOe9UKktP6wnjhJxuqW22peBN4W6bNrd0lAvW7xTLfGO3n8YcLp8ZlXoJlarG/GK oc/RW4Xs+0xJnT1EywyQoDK/2FRXMQK6YkgRCnKX9529MaZ0ZxW30Js4p3mtaoEpyI8V rrE27ppjvzUjNaZjUHRru73E/fBZZQWMjjs8qef7/IjQmBfC5H602oGPJ1AKbs4dFvXX 8Ts4tGeu+IqlO8U6lyEeKjuRo4ueGmHy3Tjhn7WMq2jgrdZ4UA6IoUAvSmBQU7oHaRLK Jnzgcx2Sj6kJ2aOiY3O/fVjQkbMya1v9UeHDbwK0Vl1qkwkOvuzbMKwH/ZZ+1kFn2Phm EnvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690446590; x=1691051390; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uvusqDDOOJ6YtxaZ4j8Okxv7ktawtWuh73WObcHHgh0=; b=g1i5A+lUuFv+BlhCZRuVKkGzfnpqKYRtCGWypTH7xhzFlLh+9bTUls7qyo1+CwkhQE pZIXfVT2D835xxWZkcWIvPlKi3wPb0nzphNbRMmpqUUQ8zpHQqySpQIDL2Uerpm5HrxS Cm5+jhL+qSrHDGMDYnK6AkOFr9Xyj75UqFdy05EJkMm6kKdOZKc4rGPqOPJit6QC3dM9 WpKXvvdMDpZykD4607yX1nUlsySvQs+qEw0tF0U9gQfLR1G47mNFw6BXMlKU93ctly2v XgbQJXLmmkhCw5fWgx/UFWImkKR7chXOBt831M9MbIKhAEH6dNZEsCy6GR0w2/I3KcL8 oBvA== X-Gm-Message-State: ABy/qLa0CGYT4ctqjP1Wi+AtiWbe1CKQ+DkYZEdcHbbxnbn6rm2EBGEc qaXGW593oFlQRKh932QRcMDi4gd5+mSx2hAYTNJhAQ== X-Google-Smtp-Source: APBJJlGZzr9MaX3VdjORfbIpL6Qo9Tuf+RcVUzdR3xwkBi26DsI/zIFf0CrXPD8cjMV07lye+8WdbksR8woDoiU8cRU= X-Received: by 2002:a81:8941:0:b0:583:8c63:c9bb with SMTP id z62-20020a818941000000b005838c63c9bbmr5765499ywf.28.1690446589947; Thu, 27 Jul 2023 01:29:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Thu, 27 Jul 2023 13:59:38 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Sahil Harpal Cc: pgadmin-hackers@postgresql.org, Aditya Toshniwal , Ashesh Vashi , Dave Page , Akshay Joshi Content-Type: multipart/related; boundary="00000000000081bbde060173c413" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000081bbde060173c413 Content-Type: multipart/alternative; boundary="00000000000081bbdd060173c412" --00000000000081bbdd060173c412 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sahil, On Thu, Jul 27, 2023 at 1:09=E2=80=AFPM Sahil Harpal wrote: > On Wed, 12 Jul 2023 at 15:58, Sahil Harpal > wrote: > >> On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> [image: image.gif] >> >>> It fails while applying. Can you please rebase your patch and send it? >>> >> >> Could you please try the attached patch. >> > Just a follow-up email to check if I can proceed with a similar structure > and logic for the remaining disk tab. > If anyone has faced any issues while using it or has any suggestions for > improvement, please let me know, and I will make the necessary changes an= d > follow the same approach for the disk tab. Although there is an issue wit= h > drive's letters, the I/O analysis of block devices is working just fine o= n > my system, so I can probably start working on it parallelly. > > Some initial review comments. - While applying the patch, I got warnings; please fix those. - Fix PEP-8 errors (yarn run pep8) - Fix the linter errors. Run *yarn run bundle:dev* instead of *yarn run webpacker so* you will get the linter errors on every run. - If the System Stat extension does not exist, display the appropriate message instead of blank graphs. - For the first time, graphs start from the opposite side, and after the following API call, those get adjusted; please fix that. - Please consider the refresh rate for the API calls (preferences settings > Dashboards > Refresh rates) The code review is in progress; I will send my review comments once completed. Thanks, Khushboo > Thanks, > Sahil > > --00000000000081bbdd060173c412 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Sahil,

On Thu, Jul 27, 2023 at 1:09=E2= =80=AFPM Sahil Harpal <sahi= lharpal1234@gmail.com> wrote:
3D"=
On Wed, 12 Jul 2023 at 15:58, Sahil Harpa= l <sahilh= arpal1234@gmail.com> wrote:
On Wed, 12 Jul 2023 at 10:47, Khus= hboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
3D"image.gif"
=C2=A0It fails while applying. Can= you please rebase your patch and send it?=C2=A0

Could you please try the attached patch.
Just a follow-up email to check if I can pro= ceed with a similar structure and logic for the remaining disk tab.=C2=A0
If anyone has faced any issues while using it or has any suggestio= ns for improvement, please let me know, and I will make the necessary chang= es and follow the same approach for the disk tab. Although there is an issu= e with drive's letters, the I/O analysis of block devices is working ju= st fine on my system, so I can probably start working on it parallelly.=C2= =A0

Some initial review c= omments.

- While applying the patch, I got warning= s; please fix those.
- Fix PEP-8 errors (yarn run pep8)
- Fix the linter errors. Run yarn run bundle:dev=C2=A0instead of yarn run webpacker so=C2=A0you will get the linter errors on every run= .
- If the System Stat extension does not exist, display the appr= opriate message instead of blank graphs.
- For the first time, gr= aphs start from the opposite side, and after the following API call, those = get adjusted; please fix that.
- Please consider the refresh rate= for the API calls (preferences settings > Dashboards > Refresh rates= )

The code review is in progress; I will send my r= eview comments once completed.

Thanks,
K= hushboo
=C2=A0
Thanks,
Sa= hil

--00000000000081bbdd060173c412-- --00000000000081bbde060173c413 Content-Type: image/gif; name="image.gif" Content-Disposition: inline; filename="image.gif" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: ii_lkkudxyl0 R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7 --00000000000081bbde060173c413--