Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fNsxq-0002r7-4c for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 May 2018 04:43:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fNsxo-0001C7-Kp for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 May 2018 04:43:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fNsxn-0001BR-Uz for pgadmin-hackers@lists.postgresql.org; Wed, 30 May 2018 04:43:56 +0000 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fNsxj-0001GH-KO for pgadmin-hackers@postgresql.org; Wed, 30 May 2018 04:43:54 +0000 Received: by mail-oi0-x234.google.com with SMTP id b130-v6so15139471oif.12 for ; Tue, 29 May 2018 21:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0ldTg1NgM3/x6IRex6gYdsjlZaORAoUhN0n+kfwnF8s=; b=tEgqGD0rG5IDTVxlDUsQmNZwFhAuqVsiv6gOTrVxzaqkCxUt7tGiLLsUxpspSbK8jR d3+eeYCgOQwpH52J4m0gXkLdupCSI0pi05I34WSdR2jsmFFgC2D67cbp5Xn3j27+SYuD pMJGP0BBNXKRz+eYETNOeHSDn4oWLErar3CH1zGHq+Iu1Ngdo7K2Ctnpb3tTUD5IeQa0 8bnApRVl/WGKdSWNsj9pTgvV0ejm+zmSHYdkaiaw3ItVWVJuv89zOI+5sDSbpWx0kiDw OYJHqGG//CTiA85Vh1rJB55KQbTJLzPQFB99sEEQUnCKXwtLFiTbWS6IlP0i3hGvfAUt CehA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0ldTg1NgM3/x6IRex6gYdsjlZaORAoUhN0n+kfwnF8s=; b=iwI14TbCUH45yakaQ/nRT7B/hCEnQekP1rENwIzBcCzZeKeQZuXmtGDCT6fjUSrgBZ oZMt4qMt4niiah6uy3OMrVf4EIHqK5XJ9wqPcgDbvdjPZr254dUWFL4sWZ1jZVC0avTd yaacWTO+OPN+wXbcRbepZ2qQbiTIpgNHtkng15pDtQK10Jpt9O83nJqp3PNY8FAo+yg8 AUL2F0gI3eEBa9vaGWgLLFiiw21nZrHGE+V3f4Vb63IOgN8ZSOsTO7vTUzJVc0wSEOmv HumeosmkTCERdkNHHdJVuHISFn70n7W7USwUEhGuSI7QGaNMbHhoct+6zCgPedNm1iEL HhGw== X-Gm-Message-State: ALKqPwfOrH1uGiCxAxwxKp/7eydX3JbkU+UqtA0JCFnF6tXEsO/wr4zw VPbthWXYdStMOV4BBug1KgDKJbqjFg+8upPEl5KYzw== X-Google-Smtp-Source: ADUXVKIvsN2bSERJGx3z+gpO2KrmkEP43A6qh5MMiv7Jy465wPeahl8bctaOwGEHXH8TuM0/LWGTSSIte4OcKKddaWA= X-Received: by 2002:aca:5a09:: with SMTP id o9-v6mr679922oib.127.1527655430329; Tue, 29 May 2018 21:43:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:5301:0:0:0:0:0 with HTTP; Tue, 29 May 2018 21:43:49 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Wed, 30 May 2018 10:13:49 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: Test cases for the backup module To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000043b332056d64ff1f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000043b332056d64ff1f Content-Type: text/plain; charset="UTF-8" On Wed, May 30, 2018 at 1:05 AM, Dave Page wrote: > Hi > > On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> please find the attached updated patch for the test cases of Backup, >> Restore and Maintenance modules which includes: >> >> 1. Unit test cases >> 2. End to end regression test cases >> 3. Feature test cases >> > > Thanks. I've yet to be able to run the feature tests successfully. Here's > what I've found so far: > > 1) DEFAULT_BINARY_PATHS should be default_binary_paths in the JSON config > file. > > Will do. > 2) I've hit screensize related issues: > > ====================================================================== > > ERROR: runTest (pgadmin.feature_tests.pg_utilities_maintenance_test. > PGUtilitiesMaintenanceFeatureTest) > > Test for PG maintenance: database > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_ > utilities_maintenance_test.py", line 56, in runTest > > self._open_maintenance_dialogue() > > File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_ > utilities_maintenance_test.py", line 75, in _open_maintenance_dialogue > > "*[.='" + self.table_name + "']/../*[@class='aciTreeItem'" > > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webelement.py", line 80, in click > > self._execute(Command.CLICK_ELEMENT) > > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webelement.py", line 628, in _execute > > return self._parent.execute(command, params) > > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", line 312, in execute > > self.error_handler.check_response(response) > > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/errorhandler.py", line 242, in > check_response > > raise exception_class(message, screen, stacktrace) > > WebDriverException: Message: unknown error: Element class="aciTreeItem">... is not clickable at point (223, 604). Other > element would receive the click:
...
> > (Session info: chrome=66.0.3359.181) > > (Driver info: chromedriver=2.38.552518 (183d19265345f54ce39cbb94cf81ba5f15905011),platform=Mac > OS X 10.12.6 x86_64) > > 3) One time the test did start, but then I saw this failure: > > ====================================================================== > > ERROR: runTest (pgadmin.feature_tests.pg_utilities_backup_restore_test. > PGUtilitiesBackupFeatureTest) > > Test for PG utilities - Backup and Restore > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_ > utilities_backup_restore_test.py", line 93, in runTest > > self.page.fill_input_by_field_name("file", "test_backup_file") > > File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", > line 211, in fill_input_by_field_name > > self.wait_for_input_field_content(field_name, field_content) > > File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", > line 251, in wait_for_input_field_content > > "field to contain '" + str(content) + "'", input_field_has_content > > File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", > line 337, in _wait_for > > "Timed out waiting for " + waiting_for_message > > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/support/wait.py", line 80, in until > > raise TimeoutException(message, screen, stacktrace) > > TimeoutException: Message: Timed out waiting for field to contain > 'test_backup_file' > > > > (with screenshot attached) > > Thanks. > > I have ran the feature tests with multiple servers many times but didn't get a single failure. I have asked Akshay to run on his machine, let see what he gets. > > > > >> >> Thanks, >> Khushboo >> >> >> >> >> On Wed, Apr 25, 2018 at 9:40 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Khushboo, >>> >>> We reviewed the patch and it is very nice to see some more coverage in >>> this area. Good job :D >>> >>> We passed the tests through our CI the feature tests are not passing, >>> but the linter fails: >>> >>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:37: [E501] line too long (91 > 79 characters) >>> >>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:53: [E501] line too long (104 > 79 characters) >>> >>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:59: [E501] line too long (85 > 79 characters) >>> >>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:62: [E501] line too long (96 > 79 characters) >>> >>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:63: [E501] line too long (91 > 79 characters) >>> >>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:70: [E501] line too long (118 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:37: [E121] continuation line under-indented for hanging indent >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:48: [E122] continuation line missing indentation or outdented >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251] unexpected spaces around keyword / parameter equals >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251] unexpected spaces around keyword / parameter equals >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:51: [E501] line too long (91 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:52: [E501] line too long (94 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:53: [E501] line too long (108 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:81: [E501] line too long (113 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:82: [E501] line too long (94 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:83: [E501] line too long (108 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:111: [E501] line too long (100 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:113: [E501] line too long (94 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:114: [E501] line too long (108 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_backup_message.py:147: [E501] line too long (93 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:40: [E121] continuation line under-indented for hanging indent >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:51: [E122] continuation line missing indentation or outdented >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:135: [E501] line too long (80 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:137: [E501] line too long (83 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:138: [E122] continuation line missing indentation or outdented >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:139: [E122] continuation line missing indentation or outdented >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:140: [E122] continuation line missing indentation or outdented >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:191: [E501] line too long (81 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:203: [E501] line too long (80 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E128] continuation line under-indented for visual indent >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E501] line too long (94 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E128] continuation line under-indented for visual indent >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E501] line too long (94 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_batch_process.py:216: [W391] blank line at end of file >>> >>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:296: [E501] line too long (97 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:317: [E303] too many blank lines (2) >>> >>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:336: [E501] line too long (84 > 79 characters) >>> >>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:371: [W391] blank line at end of file >>> >>> 2 E121 continuation line under-indented for hanging indent >>> >>> 5 E122 continuation line missing indentation or outdented >>> >>> 2 E128 continuation line under-indented for visual indent >>> >>> 2 E251 unexpected spaces around keyword / parameter equals >>> >>> 1 E303 too many blank lines (2) >>> >>> 24 E501 line too long (91 > 79 characters) >>> >>> 2 W391 blank line at end of file >>> >>> 38 >>> >>> >>> For the feature tests, we realized we had to update the configuration, >>> and we did that, but we get the following error attached. We spent some >>> time trying to understand the problem but we were not successful. >>> >>> >>> Codewise: >>> - We just found some One Letter Variables in the code... >>> - Looks like there is a bug report in this area of the code and we do >>> not have coverage for it: https://redmine.postgresql.org/issues/3232 >>> Looks like in some of the unit tests we only have happy path tests, >>> maybe we should see if there are any sad paths that also need coverage. >>> >>> The configuration change, maybe need to be updated. When we install >>> multiple versions of postgres the binaries live in >>> `/usr/lib/postgresql/{{db_version}}/bin`, which makes us think that >>> this configuration should live near the server configuration, maybe? Also >>> to maintain coherency on the naming maybe we should make it all lower case. >>> Just as an aside, you can add the gpdb configuration as well in you >>> patch. >>> >>> Thanks >>> Victoria & Joao >>> >>> On Wed, Apr 25, 2018 at 5:20 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch which covers test cases for the backup >>>> module (RM #3206). >>>> >>>> 1. Unit test cases >>>> 2. End to end regression test cases >>>> 3. Feature test cases >>>> >>>> Thanks, >>>> Khushboo >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --00000000000043b332056d64ff1f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, May 30, 2018 at 1:05 AM, Dave Page <dpage@pgadmin.org><= /span> wrote:
Hi

On M= on, May 28, 2018 at 8:09 AM, Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Hi,

plea= se find the attached updated patch for the test cases of Backup, Restore an= d Maintenance modules which includes:

1. Uni= t test cases
2. End to end regression test cases=C2=A0
3. Feature= test cases

Thanks. I've yet to be able to run the feature tests successfully. Her= e's what I've found so far:

1) DEFAULT_BIN= ARY_PATHS should be default_binary_paths in the JSON config file.

Will do.=C2=A0
2) I've hit screensize related issue= s:

=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

ERROR: ru= nTest (pgadmin.feature_tests.pg_utilities_maintenance_test.PGUtil= itiesMaintenanceFeatureTest)

Test for = PG maintenance: database

---------= -------------------------------------------------------------

Traceback= (most recent call last):

=C2=A0 File= "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_uti= lities_maintenance_test.py", line 56, in runTest

=C2=A0 =C2=A0 self._open_maintenance_dialogue()

=C2=A0 File= "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_uti= lities_maintenance_test.py", line 75, in _open_maintenance_dialog= ue

=C2=A0 =C2=A0 "*[.=3D'" + self.table_name + "']/../*[@class=3D&= #39;aciTreeItem'"

=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pack= ages/selenium/webdriver/remote/webelement.py", line 80, in click<= /span>

=C2=A0 =C2=A0 self._execute(Command.CLICK_ELEMENT)

=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pack= ages/selenium/webdriver/remote/webelement.py", line 628, in _exec= ute

=C2=A0 =C2=A0 return self._parent.execute(command, params)

=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pack= ages/selenium/webdriver/remote/webdriver.py", line 312, in execut= e

=C2=A0 =C2=A0 self.error_handler.check_response(response)

=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pack= ages/selenium/webdriver/remote/errorhandler.py", line 242, in che= ck_response

=C2=A0 =C2=A0 raise exception_class(message, screen, stacktrace)

WebDriver= Exception: Message: unknown error: Element <span class=3D"aciTreeIt= em">...</span> is not clickable at point (223, 604). Other el= ement would receive the click: <div class=3D"wcFrameCenter wcPanelB= ackground wcScrollableX wcScrollableY" style=3D"left: 0px; right:= 0px; bottom: 0px;">...</div>

=C2=A0 (Ses= sion info: chrome=3D66.0.3359.181)

=C2=A0 (Dri= ver info: chromedriver=3D2.38.552518 (183d19265345f54ce39cbb94cf81ba5f15905011),platform=3DMac OS X 10.12.6 x86_64)


3) One time the test did start, but then I saw this failure:=

=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

ERROR: ru= nTest (pgadmin.feature_tests.pg_utilities_backup_restore_test.PGU= tilitiesBackupFeatureTest)

Test for = PG utilities - Backup and Restore

---------= -------------------------------------------------------------

Traceback= (most recent call last):

=C2=A0 File= "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_uti= lities_backup_restore_test.py", line 93, in runTest

=C2=A0 =C2=A0 self.page.fill_input_by_field_name("file", "test_bac= kup_file")

=C2=A0 File= "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pga= dmin_page.py", line 211, in fill_input_by_field_name

=C2=A0 =C2=A0 self.wait_for_input_field_content(field_name, field_content)=

=C2=A0 File= "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pga= dmin_page.py", line 251, in wait_for_input_field_content

=C2=A0 =C2=A0 "field to contain '" + str(content) + "'", i= nput_field_has_content

=C2=A0 File= "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pga= dmin_page.py", line 337, in _wait_for

=C2=A0 =C2=A0 "Timed out waiting for " + waiting_for_message

=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pack= ages/selenium/webdriver/support/wait.py", line 80, in until

=C2=A0 =C2=A0 raise TimeoutException(message, screen, stacktrace)

TimeoutEx= ception: Message: Timed out waiting for field to contain 'test_backup_f= ile'



(with screenshot attached)

Thanks.<= /div>

I have ran the feature tests with multiple servers many tim= es but didn't get a single failure.
I have asked Akshay to ru= n on his machine, let see what he gets.


=C2=A0

Tha= nks,
Khushboo




On Wed= , Apr 25, 2018 at 9:40 PM, Joao De Almeida Pereira <jdealmeidap= ereira@pivotal.io> wrote:
<= div dir=3D"ltr">Hi Khushboo,

We reviewed the patch and i= t is very nice to see some more coverage in this area. Good job :D

We passed the tests through our CI the feature tests are n= ot passing, but the linter fails:
./pgadmin/feature_tests/pg_utilities_=
backup_test.py:37: [E501] line too long (91 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:53: =
[E501] line too long (104 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:59: =
[E501] line too long (85 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:62: =
[E501] line too long (96 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:63: =
[E501] line too long (91 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:70: =
[E501] line too long (118 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:37: =
[E121] continuation line under-indented for hanging indent

./pgadmin/tools/backup/tests/test_backup_message.py:48: =
[E122] continuation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_backup_message.py:49: =
[E251] unexpected spaces around keyword / parameter equals

./pgadmin/tools/backup/tests/test_backup_message.py:49: =
[E251] unexpected spaces around keyword / parameter equals

./pgadmin/tools/backup/tests/test_backup_message.py:51: =
[E501] line too long (91 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:52: =
[E501] line too long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:53: =
[E501] line too long (108 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:81: =
[E501] line too long (113 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:82: =
[E501] line too long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:83: =
[E501] line too long (108 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:111:=
 [E501] line too long (100 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:113:=
 [E501] line too long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:114:=
 [E501] line too long (108 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:147:=
 [E501] line too long (93 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:40: [=
E121] continuation line under-indented for hanging indent

./pgadmin/tools/backup/tests/test_batch_process.py:51: [=
E122] continuation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:135: =
[E501] line too long (80 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:137: =
[E501] line too long (83 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:138: =
[E122] continuation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:139: =
[E122] continuation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:140: =
[E122] continuation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:191: =
[E501] line too long (81 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:203: =
[E501] line too long (80 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:204: =
[E128] continuation line under-indented for visual indent

./pgadmin/tools/backup/tests/test_batch_process.py:204: =
[E501] line too long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:205: =
[E128] continuation line under-indented for visual indent

./pgadmin/tools/backup/tests/test_batch_process.py:205: =
[E501] line too long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:216: =
[W391] blank line at end of file

./pgadmin/tools/backup/tests/test_create_backup_job.py:2=
96: [E501] line too long (97 > 79 characters)

./pgadmin/tools/backup/tests/test_create_backup_job.py:3=
17: [E303] too many blank lines (2)

./pgadmin/tools/backup/tests/test_create_backup_job.py:3=
36: [E501] line too long (84 > 79 characters)

./pgadmin/tools/backup/tests/test_create_backup_job.py:3=
71: [W391] blank line at end of file

2       E121 continuation line under-indented for hanging ind=
ent

5       E122 continuation line missing indentation or outdent=
ed

2       E128 continuation line under-indented for visual inde=
nt

2       E251 unexpected spaces around keyword / parameter equ=
als

1       E303 too many blank lines (2)

24      E501 line too long (91 > 79 characters)

2       W391 blank line at end of file

38

For the f= eature tests, we realized we had to update the configuration, and we did th= at, but we get the following error attached. We spent some time trying to u= nderstand the problem but we were not successful.

=
Codewise:
- We just found some One Letter Variable= s in the code...
- Looks like there is a bug report in this area = of the code and we do not have coverage for it:=C2=A0https://redmine.postgres= ql.org/issues/3232
=C2=A0 Looks like in some of the unit= tests we only have happy path tests, maybe we should see if there are any = sad paths that also need coverage.

The configurati= on change, maybe need to be updated. When we install multiple versions of p= ostgres the binaries live in `/usr/lib/postgresql/{{db_version}}/bin`,= which makes us think that this configuration should live near the server c= onfiguration, maybe? Also to maintain coherency on the naming maybe we shou= ld make it all lower case.
Just as an aside, you can add the gpdb= configuration as well in you patch.

Thanks
<= div>Victoria & Joao

On Wed= , Apr 25, 2018 at 5:20 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:
Hi= ,

Please find the attached patch which covers test cases= for the backup module (RM #3206).

1. Unit test ca= ses
2. End to end regression test cases=C2=A0
3. Featur= e test cases

Thanks,
Khushboo




--
Dav= e Page
Blog: h= ttp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:= http://www.enter= prisedb.com
The Enterprise PostgreSQL Company
--00000000000043b332056d64ff1f--