Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlQy6-0001pX-Rr for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 04:46:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hlQy5-00033x-3V for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 04:46:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlQy4-00030x-PN for pgadmin-hackers@lists.postgresql.org; Thu, 11 Jul 2019 04:46:04 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlQxn-0003AC-7P for pgadmin-hackers@postgresql.org; Thu, 11 Jul 2019 04:46:03 +0000 Received: by mail-oi1-x22e.google.com with SMTP id t76so3489145oih.4 for ; Wed, 10 Jul 2019 21:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aKUIHByEavVLYxY8J+d0fKIu/+56c7AR8Iqb0k6j5ZI=; b=rYLj6ngdeMCVi4juReZkKzq2TAx2mv8wPwNU3Be5uNPnKPWcHqz8Lu7eVR35HUspRL GQVcGCWEl0cphjkKsa/szv9nEw4a/8BJjzQYuHeVR9e2Nw7KG0rJ/w2en+DN0w0bc1EU GLnAHlzNzRHD7jZ5zBs3Mn5BVtaxQ7fXWY0V4zN9YxhqePQZymDdFHNuTMNb7ImR1gfK BHRaOxJ7XmXWiNeLBEgcSK0778PNx8DDkKAiu+CpHXEPj4OkwkUnjbJtDDgchv7rViMt v6ljhJAYFmG+tX0Pq4YLYCR4zm8I5OpUfPc85Tq59poNx0//Abu2K3h/OSR1c1hqOxFN M4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aKUIHByEavVLYxY8J+d0fKIu/+56c7AR8Iqb0k6j5ZI=; b=Ica7n9kGbFkagqPooGs0UPyDwMimdLaNP0NBizW7awuHsyy+0O5vQNGr7GlxNULLlB VyVrS3FSyKzRg8YQYAuROE7F0mSsDkYZUvbjL4l9o2AfCb8V/oy5SO5+948iHJDf2wxi 2KtAFG212lSptHMyNhUtB20qNzlMV8M3cfgOABLd2C+rHVemqTacFwy3Zwxg8EtNOHNA PuQC8cV23ShUwRpqKBs5f9Z08gMw4K4fubBtJLX+dBy7+pEoHsnwekAE5UeuXDCdb1rW OzloHAGTSNfDgnX+mh4dFtOOXMx0DG4RSbPfrp95r3HTlIFo2IsM3Z8vGAc73dbQjOkG xHpg== X-Gm-Message-State: APjAAAXk4fj38tOnT0Zr04lrq6PLZ2aZm27StNP2x1mJpJZkU5GOGODt 11o2X7qAp2de52c/Xy14noT0bM4Ev59Jlh+5wL5JgXZ0 X-Google-Smtp-Source: APXvYqzoKwVhIUP7V9wJGoudfv/MTN6M8OEwblfG4Oqh73NPchnCOH88jGEhVZV/d4YZ3ZGlL5USu82pC+8mC+O7O4s= X-Received: by 2002:aca:4083:: with SMTP id n125mr1155220oia.106.1562820345937; Wed, 10 Jul 2019 21:45:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Thu, 11 Jul 2019 10:15:36 +0530 Message-ID: Subject: Re: [GSoC] Finalized First Patch To: Yosry Muhammad Cc: Dave Page , pgadmin-hackers , Akshay Joshi Content-Type: multipart/alternative; boundary="0000000000009156ca058d6077da" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009156ca058d6077da Content-Type: text/plain; charset="UTF-8" Hi, On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote: > Hi, > > On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Some points I missed: >> 1. I assumed that in this patch modification in case of OIDs= True >> (without primary key) has not considered as that is not working. >> > > This is not implemented yet. I will work on that in a following patch soon > enough. > > Okay. > 2. As we are already showing the changed Data prompt on closing the Query >> Tool, do we really need the Uncommitted Transaction prompt? >> > > This is needed when auto-commit is off. Saving changes in the data grid is > performed as part of the ongoing transaction (or a new one if none is > ongoing). After saving the data changes the user should still commit the > current transaction for the changes to be commited to the database. This > feature is also useful in general when auto-commit is off as users may > forget to commit ongoing transactions. > > One thing I have noticed, when I add a new row and delete it immediately without saving it and try to close the query tool, the uncommitted prompt is coming. In my opinion, it should not come, what do you think? We should disable the prompt if auto-commit and auto-rollback both are enabled. Thanks, Khushboo > Thanks and Regards :D > --0000000000009156ca058d6077da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jul 10, 2019 at 3:11 PM Yosry = Muhammad <yosrym93@gmail.com&g= t; wrote:
Hi,

On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Some points I missed:
1.=C2=A0 I ass= umed that in this patch modification in case of OIDs=3D True (without prima= ry key) has not considered as that is not working.
=

This is not imple= mented yet. I will work on that in a following patch soon enough.

Okay.=C2=A0
2. As we are already showi= ng the changed Data prompt on closing the Query Tool, do we really need the= Uncommitted Transaction prompt?=C2=A0
=

This is needed when auto-comm= it is off. Saving changes in the data grid is performed as part of the ongo= ing transaction (or a new one if none is ongoing). After saving the data ch= anges the user should still commit the current transaction for the changes = to be commited to the database. This feature is also useful in general when= auto-commit is off as users may forget to commit ongoing transactions.

One thing I have noti= ced, when I add a new row and delete it immediately without saving it and t= ry to close the query tool, the uncommitted prompt is coming.
In = my opinion, it should not come, what do you think?

We should disable the prompt if auto-commit and auto-rollback both are ena= bled.

Thanks,
Khushboo
=C2=A0<= /div>
Thanks=C2=A0and Regards :D
--0000000000009156ca058d6077da--