MIME-Version: 1.0
References: 
 <CANxoLDeV+R-vq6c+ewSWwaa1mQ=OQru0+TJOFdX0ZYO655DMcg@mail.gmail.com>
In-Reply-To: 
 <CANxoLDeV+R-vq6c+ewSWwaa1mQ=OQru0+TJOFdX0ZYO655DMcg@mail.gmail.com>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Thu, 14 Nov 2019 14:48:37 +0530
Message-ID: 
 <CAFOhELdtY_DDEcCz+2eU3wFYQjRr9GbYTFNuw+5Wau3Hufm==A@mail.gmail.com>
Subject: Re: Refactored code for Table and its child nodes.
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000eac14605974af761"
Precedence: bulk

--000000000000eac14605974af761
Content-Type: text/plain; charset="UTF-8"

Hi Akshay,

Everything works fine on Python 3 but not working on Python 2.7.
Code refactoring looks good to me.

Thanks,
Khushboo

On Wed, Nov 13, 2019 at 7:13 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers,
>
> For a couple of days, I was working on the code refactoring of Table and
> it's child nodes.
>
> *Problem*:  In pgAdmin4 child nodes of the table can be created/modified
> from table dialog as well as from individual node. For example: Primary Key
> constraint can be created/updated from tables as well as from individual
> primary key node.
>
> After analyzing the code it seems that we have duplicate logic/functions
> in '*tables/utils.py*' and '*__init__.py*' of the respective node.
>
> So because of the above-described problem, if there is a bug at one place
> we need to fix it on both the places.
>
> *Purpose*:
>
>    1. Remove duplicate logic.
>    2. Child node specific logic should be inside the child node and table
>    node gets the required information from the respective child node.
>
> *Solution*:
>
>    1. Create '*utils.py*' for each child node.
>    2. Move the common logic from '*tables/utils.py*' and '*__init__.py*'
>    of the respective node to '*utils.py'.*
>    3. Both table and its respective child access the functions from the
>    respective '*utils.py*'.
>
>
> *Note*: Refactoring of *columns* node still remaining I'll start working
> on it.
>
> Please review/test the patch thoroughly for tables and it's child nodes.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--000000000000eac14605974af761
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Akshay,</div><div><br></div><div>Everything works =
fine on Python 3 but not working on Python 2.7.</div><div>Code refactoring =
looks good to me.</div><div><br></div><div>Thanks,</div><div>Khushboo</div>=
<br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed=
, Nov 13, 2019 at 7:13 PM Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi@e=
nterprisedb.com">akshay.joshi@enterprisedb.com</a>&gt; wrote:<br></div><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<=
div><br></div><div>For a couple=C2=A0of days, I was working on the code ref=
actoring of Table and it&#39;s child nodes.</div><div><br></div><div><b>Pro=
blem</b>:=C2=A0 In pgAdmin4 child nodes of the table can be created/modifie=
d from table dialog as well as from individual node. For=C2=A0example: Prim=
ary=C2=A0Key constraint can be created/updated from tables as well as from =
individual primary key node.</div><div><br></div><div>After analyzing the c=
ode it seems that we have duplicate logic/functions in &#39;<b>tables/utils=
.py</b>&#39; and &#39;<b>__init__.py</b>&#39; of the respective node.=C2=A0=
</div><div><br></div><div>So because of the above-described problem, if the=
re is a bug at one place we need to fix it on both the places.=C2=A0=C2=A0<=
/div><div><br></div><div><b>Purpose</b>:=C2=A0</div><div><ol><li>Remove dup=
licate logic.</li><li>Child node specific logic should be inside the child =
node and table node gets the required information from the respective child=
 node.</li></ol></div><div><b>Solution</b>:</div><div><ol><li>Create &#39;<=
b>utils.py</b>&#39; for each child node.</li><li>Move the common logic from=
 &#39;<b>tables/utils.py</b>&#39; and &#39;<b>__init__.py</b>&#39; of the r=
espective node to &#39;<b>utils.py&#39;.</b></li><li>Both table and its res=
pective child access the functions from the respective=C2=A0&#39;<b>utils.p=
y</b>&#39;.</li></ol></div><div><br></div><div><b>Note</b>: Refactoring of =
<b>columns</b> node still remaining I&#39;ll start working on it.</div><div=
><br></div><div>Please review/test=C2=A0the patch thoroughly for tables and=
 it&#39;s child nodes.</div><div><div><br></div>-- <br><div dir=3D"ltr"><di=
v dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr">=
<div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0=
,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"=
>Thanks &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><=
b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13=
px;border-collapse:collapse">Akshay Joshi</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Sr. Software Architect<br>=
</span></b></font></div><div><span style=3D"border-collapse:collapse"><font=
 color=3D"#000000" face=3D"arial, sans-serif"><b>EnterpriseDB Software Indi=
a Private Limited</b></font><br></span></div><div><b style=3D"color:rgb(51,=
51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-=
size:13px;border-collapse:collapse">Mobile: +91 976-788-8246</span></b><br>=
</div></div></div></div></div></div></div></div></div></div></div>
</blockquote></div></div>

--000000000000eac14605974af761--