Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etc48-0008Kt-Na for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:37:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etc47-0000Em-OP for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:37:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etc47-0000EZ-HV for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 16:37:19 +0000 Received: from mail-ot0-x230.google.com ([2607:f8b0:4003:c0f::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etc43-0004Bp-7U for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 16:37:18 +0000 Received: by mail-ot0-x230.google.com with SMTP id 108so2625879otv.3 for ; Wed, 07 Mar 2018 08:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d/DZtI0oy+RyrgdbdJqtHIgISmUZX0ga8eYi+aH+ZSA=; b=W4PzpOnA9uDqKblJa154LU6NsyUS5Kih2lh54vhauYVacOTXhKdYMhWRsrCw476AMW R7ueuemfjTA+e+k727iDP6KomCANqoteLpPeZy1xN5lFEiwKNfskX54womuhaOgUFUXa bDpm6pLO1U/h10QVZLGAki5up8SaCP1GpjluLnBPAo3dPAEoeNGsukxJBuzKyZ4drOIk bv9HBQzTA5pnO8URy3v/OBU1xxZ3ZtjvnmIcrbZ+njnrO3IfJmRfsGF+41zDV88nhrNt ndpGELJ1slcv2t03NsbL+EJWKR0fCESxFgbU66FQWYvDC6cFWFzuFX0oKB2zuWLx3UVI Fb0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d/DZtI0oy+RyrgdbdJqtHIgISmUZX0ga8eYi+aH+ZSA=; b=nL9h+tGvAEFR7g7ZjISLyBt0dFdTc3WbqFiGETvrp8TWdJq0EC7Zr9V8illARhC9Aq 4q9Dl64kkiqrZFtKq1t1KTUVQWAN54Zp5Fpq9JkfF0CwNw8eD7wTW75wKLe3L9guvFvU OZm50Cr0a6sAlBovZoR4cCzr53mnX+qrFDpKLquKg5jDDrB+KwQCcyY9oaC/KpbJtoX0 5bzH90Jz2V/JYG/LJ2jp4qg2gdKvTls8uR+pdgRyaWdW4OWOaPQ0r0/fqSAjqdEj2KTk 7mmiMgftu3iJJpza5VzVdBak2FLPKSXHDKWawNFGxcK1ZENgaPXPnCI864Vymkocd5Qf 5log== X-Gm-Message-State: AElRT7EC6D4Y0wLy3SP37CHmDbA1mUgcoMOglWlphzPcSfBcnoWhIGdy FX4WmcnPtLZB0fbD7m4bT4TSecCRWnsQ5QkviCHUvg== X-Google-Smtp-Source: AG47ELs1kyeuMOUjXq/Ra8KeGEej8pG8J/nnWz1cm4EKVq9Bx0rOHMjFOB3VaI0MQ1pPN7tdXVxr7tguZMo+7SjRxJI= X-Received: by 10.157.37.206 with SMTP id q72mr15160496ota.296.1520440632329; Wed, 07 Mar 2018 08:37:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Wed, 7 Mar 2018 08:37:11 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Khushboo Vashi Date: Wed, 7 Mar 2018 22:07:11 +0530 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="001a113d747ccbfdd00566d52bb3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d747ccbfdd00566d52bb3 Content-Type: multipart/alternative; boundary="001a113d747ccbfdcd0566d52bb1" --001a113d747ccbfdcd0566d52bb1 Content-Type: text/plain; charset="UTF-8" Please find the attached updated patch. This should work. On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: > > > On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: >>>> >>>>> Khushboo, can you look at this ASAP please? It passed tests on my >>>>> machine, but Jenkins isn't happy. >>>>> >>>>> I have tried to reproduce the issue with many combination but couldn't >>>> reproduce it. >>>> With the help of logs, I have tried to fix it. Can you please check >>>> this fix is helpful or not? >>>> >>> >>> On my laptop I now get: >>> >>> ====================================================================== >>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>> .test_poll_query_tool.TestPollQueryTool) >>> When query tool polling returns messages with result data-set >>> ---------------------------------------------------------------------- >>> Traceback (most recent call last): >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", >>> line 104, in runTest >>> response_data['data']['additional_messages']) >>> File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", >>> line 802, in assertIn >>> if member not in container: >>> TypeError: argument of type 'NoneType' is not iterable >>> >>> ---------------------------------------------------------------------- >>> >>> Please provide some more details. Is this failing for particular server >> version? >> I am not getting any error with this patch and without this patch on PY2 >> and PY3 with a single/multiple servers. >> > > Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are > the package versions in the venv: > > alabaster==0.7.10 > alembic==0.9.6 > args==0.1.0 > Babel==2.3.4 > backports.csv==1.0.4 > beautifulsoup4==4.4.1 > blinker==1.3 > chromedriver-installer==0.0.6 > click==6.6 > clint==0.5.1 > dateutils==0.6.6 > docutils==0.13.1 > extras==1.0.0 > fixtures==3.0.0 > Flask==0.11.1 > Flask-Babel==0.11.1 > Flask-Gravatar==0.4.2 > Flask-HTMLmin==1.2 > Flask-Login==0.3.2 > Flask-Mail==0.9.1 > Flask-Migrate==2.0.3 > Flask-Paranoid==0.1.0 > Flask-Principal==0.4.0 > Flask-Script==2.0.6 > Flask-Security==1.7.5 > Flask-SQLAlchemy==2.1 > Flask-WTF==0.12 > funcsigs==1.0.2 > html5lib==1.0b3 > htmlmin==0.1.11 > imagesize==0.7.1 > importlib==1.0.3 > itsdangerous==0.24 > Jinja2==2.7.3 > linecache2==1.0.0 > Mako==1.0.7 > MarkupSafe==0.23 > minify==0.1.4 > mock==2.0.0 > passlib==1.6.2 > pbr==3.1.1 > pkginfo==1.4.1 > psycopg2==2.7.3.2 > pycodestyle==2.3.1 > pycrypto==2.6.1 > Pygments==2.2.0 > pyperclip==1.5.32 > pyrsistent==0.14.0 > python-dateutil==2.5.0 > python-editor==1.0.3 > python-mimeparse==1.6.0 > pytz==2014.10 > requests==2.13.0 > requests-toolbelt==0.7.1 > selenium==3.3.3 > simplejson==3.6.5 > six==1.11.0 > snowballstemmer==1.2.1 > speaklater==1.3 > Sphinx==1.5.3 > SQLAlchemy==1.0.14 > sqlparse==0.1.19 > testscenarios==0.5.0 > testtools==2.0.0 > traceback2==1.4.0 > unittest2==1.1.0 > Werkzeug==0.9.6 > WTForms==2.0.2 > yuicompressor==2.4.8 > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d747ccbfdcd0566d52bb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please find the attached updated patch.
This should wo= rk.

On Wed, Ma= r 7, 2018 at 9:46 PM, Dave Page <dpage@pgadmin.org> wrote:


On Wed, Mar 7, 2018 a= t 4:13 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.= com> wrote:


On Wed, Mar 7, 2018 at = 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Mar 7, 2018 at 3= :10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:
Hi Dave,

On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
Khushboo, can you look at this ASAP ple= ase? It passed tests on my machine, but Jenkins isn't happy.

I have tried to reproduce the issue with= many combination but couldn't reproduce it.
With the help of= logs, I have tried to fix it. Can you please check this fix is helpful or = not?=C2=A0

O= n my laptop I now get:

=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgad= min.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)=
When query tool polling returns messages with result data-= set
-------------------------------------------------= ---------------------
Traceback (most recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/s= qleditor/tests/test_poll_query_tool.py", line 104, in runTest
=C2=A0 =C2=A0 response_data['data']['additional_mes= sages'])
=C2=A0 File "/System/Library/Frameworks/Py= thon.framework/Versions/2.7/lib/python2.7/unittest/case.py", line= 802, in assertIn
=C2=A0 =C2=A0 if member not in container:
=
TypeError: argument of type 'NoneType' is not iterable

----------------------------------------------------= ------------------=C2=A0

=
Please provide some more details. Is this fa= iling for particular server version?
I am not getting any error w= ith this patch and without this patch on PY2 and PY3 with a single/multiple= servers.

Py= thon 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are the p= ackage versions in the venv:

alabaster=3D=3D0= .7.10
alembic=3D=3D0.9.6
args=3D=3D0.1.0
Babe= l=3D=3D2.3.4
backports.csv=3D=3D1.0.4
beautifulsoup4=3D= =3D4.4.1
blinker=3D=3D1.3
chromedriver-installer=3D=3D0= .0.6
click=3D=3D6.6
clint=3D=3D0.5.1
dateutil= s=3D=3D0.6.6
docutils=3D=3D0.13.1
extras=3D=3D1.0.0
fixtures=3D=3D3.0.0
Flask=3D=3D0.11.1
Flask-Babe= l=3D=3D0.11.1
Flask-Gravatar=3D=3D0.4.2
Flask-HTMLmin= =3D=3D1.2
Flask-Login=3D=3D0.3.2
Flask-Mail=3D=3D0.9.1<= /div>
Flask-Migrate=3D=3D2.0.3
Flask-Paranoid=3D=3D0.1.0
Flask-Principal=3D=3D0.4.0
Flask-Script=3D=3D2.0.6
Flask-Security=3D=3D1.7.5
Flask-SQLAlchemy=3D=3D2.1
F= lask-WTF=3D=3D0.12
funcsigs=3D=3D1.0.2
html5lib=3D=3D1.= 0b3
htmlmin=3D=3D0.1.11
imagesize=3D=3D0.7.1
= importlib=3D=3D1.0.3
itsdangerous=3D=3D0.24
Jinja2=3D= =3D2.7.3
linecache2=3D=3D1.0.0
Mako=3D=3D1.0.7
MarkupSafe=3D=3D0.23
minify=3D=3D0.1.4
mock=3D=3D2.0.= 0
passlib=3D=3D1.6.2
pbr=3D=3D3.1.1
pkginfo= =3D=3D1.4.1
psycopg2=3D=3D2.7.3.2
pycodestyle=3D=3D2.3.= 1
pycrypto=3D=3D2.6.1
Pygments=3D=3D2.2.0
pyp= erclip=3D=3D1.5.32
pyrsistent=3D=3D0.14.0
python-dateut= il=3D=3D2.5.0
python-editor=3D=3D1.0.3
python-mimeparse= =3D=3D1.6.0
pytz=3D=3D2014.10
requests=3D=3D2.13.0
requests-toolbelt=3D=3D0.7.1
selenium=3D=3D3.3.3
= simplejson=3D=3D3.6.5
six=3D=3D1.11.0
snowballstemmer= =3D=3D1.2.1
speaklater=3D=3D1.3
Sphinx=3D=3D1.5.3
=
SQLAlchemy=3D=3D1.0.14
sqlparse=3D=3D0.1.19
testsc= enarios=3D=3D0.5.0
testtools=3D=3D2.0.0
traceback2=3D= =3D1.4.0
unittest2=3D=3D1.1.0
Werkzeug=3D=3D0.9.6
=
WTForms=3D=3D2.0.2
yuicompressor=3D=3D2.4.8
=
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
=
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113d747ccbfdcd0566d52bb1-- --001a113d747ccbfdd00566d52bb3 Content-Type: text/x-patch; charset="US-ASCII"; name="RM_3094_testcase_fix.patch" Content-Disposition: attachment; filename="RM_3094_testcase_fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jehb2wny0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZXN0cy90ZXN0X3BvbGxf cXVlcnlfdG9vbC5weSBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZXN0cy90ZXN0X3Bv bGxfcXVlcnlfdG9vbC5weQppbmRleCAyNzVlZDljLi5lMGE4ZDM4IDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVzdHMvdGVzdF9wb2xsX3F1ZXJ5X3Rvb2wucHkKKysr IGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3Rlc3RzL3Rlc3RfcG9sbF9xdWVyeV90b29s LnB5CkBAIC05OSw5ICs5OSwxMSBAQCBOT1RJQ0U6ICBIZWxsbywgd29ybGQhCiAgICAgICAgICAg ICBzZWxmLmFzc2VydEVxdWFscyhyZXNwb25zZS5zdGF0dXNfY29kZSwgMjAwKQogICAgICAgICAg ICAgcmVzcG9uc2VfZGF0YSA9IGpzb24ubG9hZHMocmVzcG9uc2UuZGF0YS5kZWNvZGUoJ3V0Zi04 JykpCiAKLSAgICAgICAgICAgICMgQ2hlY2sgdGhlIHJldHVybmVkIG1lc3NhZ2VzCi0gICAgICAg ICAgICBzZWxmLmFzc2VydEVxdWFscyhzZWxmLmV4cGVjdGVkX21lc3NhZ2VbY250XSwKKyAgICAg ICAgICAgIGlmIHNlbGYuZXhwZWN0ZWRfbWVzc2FnZVtjbnRdIGlzIG5vdCBOb25lOgorICAgICAg ICAgICAgICAgICMgQ2hlY2sgdGhlIHJldHVybmVkIG1lc3NhZ2VzCisgICAgICAgICAgICAgICAg c2VsZi5hc3NlcnRJbihzZWxmLmV4cGVjdGVkX21lc3NhZ2VbY250XSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJlc3BvbnNlX2RhdGFbJ2RhdGEnXVsnYWRkaXRpb25hbF9tZXNzYWdl cyddKQorCiAgICAgICAgICAgICAjIENoZWNrIHRoZSBvdXRwdXQKICAgICAgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWxzKHNlbGYuZXhwZWN0ZWRfcmVzdWx0W2NudF0sCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICByZXNwb25zZV9kYXRhWydkYXRhJ11bJ3Jlc3VsdCddWzBdWzBdKQo= --001a113d747ccbfdd00566d52bb3--